Node 12 actions need to be moved to Node 16

[suzialeksander]

Node 12 actions need to be moved to Node 16

[matentzn]

I updated the release workflow, do you want to try running it again?

[suzialeksander]

I tried it twice just now but failed both, looks like it's genuinely unhappy now about something:

Run ./src/scripts/make_release.sh
fatal: detected dubious ownership in repository at '/__w/ascomycete-phenotype-ontology/ascomycete-phenotype-ontology'
To add an exception for this directory, call:

git config --global --add safe.directory /__w/ascomycete-phenotype-ontology/ascomycete-phenotype-ontology
Error: Process completed with exit code 128.

[matentzn]

I will try a few things but will take me a moment or two - are you under great time pressure?

[suzialeksander]

Absolutely not under any pressure. Also, previous issue was only a warning not a failure, so this seems like it will run if reverted for... a few more months? GitHub says "summer 2023" but doesn't say if the old node will be killed off or just throw that error for a long while.

[matentzn]

I will revert it back if I cant figure it out when I try tomorrow :)

[matentzn]

Sorry @suzialeksander I restored the old action now, I couldn't figure out what was wrong. I made the action identical to other repos where it works. I don't think you have to worry about the warning, but when something fails, come back to me and I will sort it out for you!

[suzialeksander]

no worries, thanks for looking into it. I expect this will work for at least a few more months so I'll close this for now.