oca/agreement

agreement's Issues

Migration to version 17.0

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0

Modules to migrate

• agreement
• agreement_legal
• agreement_rebate

Missing module? Check https://github.com/OCA/maintainer-tools/wiki/%5BFAQ%5D-Missing-modules-in-migration-issue-list

16.0 agreement_legal: Menu item access

Hi when the agreement_legal module is installed, users without agreement security rights still see the global "Agreements" menu but they cannot access it:

You are not allowed to access 'Agreement Stages' (agreement.stage)

What should be the right fix?

1. Restrain the global "Agreements" menu to agreement security groups
2. Give anyone (ie base.group_user) read access to agreement.stage and the like, to match access rights to agreements themselves which are on base.group_user

To reproduce, connect to 16.0 runboat with demo/demo and click on the global "Agreements" menu:

Agreement Rebate - Issue in behaviour

Disclaimer

I believe I'm reporting a bug, based on what I suppose should be the behaviour of the module.
The module documentation did not explain this, so I'm reporting so it can be addressed.

Module

agreement_rebate

Describe the bug

If a settlement is already made, the next does not take into the consideration that amount already returned to the client

To Reproduce

V16

Steps to reproduce the behaviour:
1.Define sections
exemple: 0 --> 1k€ get 5% ; them 1001---> 5k€ get 10%, 10k gets 20%
2.Start invoicing the client
3. The client ends hitting the 1000 mark and now as for example, 50 € to receive based on the rebate made.
4. Settlement made and keep invoicing
5. The next mark is achieved, and we invoiced 11.5k to the client, after rebase it gets 3400 € in favour of the client.
6. [Bug] - The previous 50€ are not take into consideration

Expected behaviour

1. Recalculate based on the settlement already made

Migration to version 15.0

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-15.0

Modules to migrate

Missing module? Check https://github.com/OCA/maintainer-tools/wiki/%5BFAQ%5D-Missing-modules-in-migration-issue-list

• agreement_sale - By @nabilragab - #13
• agreement_serviceprofile - By @Saran440 - #11

Migration to version 16.0

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0

Modules to migrate

• agreement - By @FrancoMaxime - #12
• agreement_legal - By @urvisha-serpentcs - #8
• agreement_project - By @len-foss - #15
• agreement_rebate - By @ao-landoo - #21
• agreement_sale - By @vibhascs - #18

Missing module? Check https://github.com/OCA/maintainer-tools/wiki/%5BFAQ%5D-Missing-modules-in-migration-issue-list

First commit

@simahawk Do you do the first commit or do I need to do it with copier?

16.0 agreement_legal and button 'new' on records.

Module

agreement_legal

Describe the bug

When install agreement_legal module, button 'New' disappears when user is inside a record.

To Reproduce

Affected versions: 16.0

Steps to reproduce the behavior:

1. Go to a record(sale order, invoice, partner,etc.
2. Button 'New' missing.