CONTRIBUTING.md import rules conflict

[oca]

CONTRIBUTING.md import rules conflict

[pedrobaeza]

Perfect. Better explicit than implicit

[guewen]

Here's what pep8 says:

Imports should be grouped in the following order:

• standard library imports
• related third party imports
• local application/library specific imports

You should put a blank line between each group of imports.

So it should not be a problem, logging will always be before third party dependencies. Rather than a rule specifically for logging, we should say:

1. standard library imports
2. related third party imports
3. Odoo imports
4. Imports from Odoo modules (rarely, and only if necessary)
5. Local imports in the relative form

Reference: https://www.python.org/dev/peps/pep-0008/#imports

[ajite]

@guewen That is indeed a better solution :)! 👍

[ajite]

I made a pull request for that #121 . Let's continue the discussion in it.