oca/purchase-workflow

Odoo Purchases, Workflow and Organization

purchase-workflow

TODO: add repo description.

Available addons

addon	version	maintainers	summary
procurement_purchase_no_grouping	16.0.1.0.0		Procurement Purchase No Grouping
product_supplier_code_purchase	16.0.1.0.0		This module adds to the purchase order line the supplier code defined in the product.
product_supplierinfo_purchase_contact	16.0.1.0.0		Add Purchase Contact in product supplier info
product_supplierinfo_qty_multiplier	16.0.1.0.0		Product supplierinfo qty multiplier
purchase_advance_payment	16.0.1.0.1		Allow to add advance payments on purchase orders
purchase_all_shipments	16.0.1.0.0		Purchase All Shipments
purchase_allowed_product	16.0.2.1.0		This module allows to select only products that can be supplied by the vendor
purchase_blanket_order	16.0.2.1.0		Purchase Blanket Orders
purchase_commercial_partner	16.0.1.0.0		Add stored related field 'Commercial Supplier' on POs
purchase_date_planned_manual	16.0.1.0.0		This module makes the system to always respect the planned (or scheduled) date in PO lines.
purchase_default_terms_conditions	16.0.1.0.3		This module allows purchase default terms & conditions
purchase_delivery_split_date	16.0.1.0.2		Allows Purchase Order you confirm to generate one Incoming Shipment for each expected date indicated in the Purchase Order Lines
purchase_deposit	16.0.1.0.1		Option to create deposit from purchase order
purchase_discount	16.0.1.3.0		Purchase order lines with discounts
purchase_exception	16.0.1.0.1		Custom exceptions on purchase order
purchase_fop_shipping	16.0.1.0.1		Purchase Free-Of-Payment shipping
purchase_force_invoiced	16.0.1.0.1		Allows to force the billing status of the purchase order to "Invoiced"
purchase_invoice_method	16.0.1.0.0		Allow to force the invoice method of a purchase
purchase_invoice_plan	16.0.1.0.0		Add to purchases order, ability to manage future invoice plan
purchase_landed_cost	16.0.1.0.0		Purchase cost distribution
purchase_last_price_info	16.0.1.0.1		Purchase Product Last Price Info
purchase_line_procurement_group	16.0.1.0.0		Group purchase order line according to procurement group
purchase_location_by_line	16.0.1.0.0		Allows to define a specific destination location on each PO line
purchase_lot	16.0.1.0.0		Purchase Lot
purchase_manual_delivery	16.0.1.1.1		Prevents pickings to be auto generated upon Purchase Order confirmation and adds the ability to manually generate them as the supplier confirms the different purchase order lines.
purchase_merge	16.0.1.0.1		Wizard to merge purchase with required conditions
purchase_no_rfq	16.0.1.0.0		Purchase Order - No Request For Quotation
purchase_only_by_packaging	16.0.1.0.1		Manage purchase of packaging
purchase_open_qty	16.0.2.0.1		Allows to identify the purchase orders that have quantities pending to invoice or to receive.
purchase_order_approved	16.0.1.0.0		Add a new state 'Approved' in purchase orders.
purchase_order_archive	16.0.1.0.0		Archive Purchase Orders
purchase_order_downpayment	16.0.1.0.0		Allow to add payments from Purchase order view
purchase_order_general_discount	16.0.1.0.0		General discount per purchase order
purchase_order_hide_receipt_status	16.0.1.0.1		Purchase Order Hide Receipt Status
purchase_order_line_menu	16.0.2.1.0		Adds Purchase Order Lines Menu
purchase_order_line_receipt_status	16.0.1.0.0		Manage customizations on purchase order line
purchase_order_no_zero_price	16.0.1.0.1		Prevent zero price lines on Purchase Orders
purchase_order_owner	16.0.1.0.0		Purchase Order Owner
purchase_order_price_recalculation	16.0.1.0.0		Price recalculation in purchases orders
purchase_order_product_attachment_mgmt	16.0.1.0.0		Purchase Order Product Attachment Mgmt
purchase_order_product_recommendation	16.0.1.1.0		Recommend products to buy to supplier based on history
purchase_order_purchase_manager	16.0.1.0.1		Purchase Manager from Supplier in Purchase Order
purchase_order_qty_change_no_recompute	16.0.1.0.0		Prevent recompute if only quantity has changed in purchase order line
purchase_order_supplier_return	16.0.1.0.0		Return product to supplier and update quantiy received
purchase_order_supplierinfo_update	16.0.1.0.1		Update product supplierinfo with the last purchase price
purchase_order_type	16.0.1.0.1		Purchase Order Type
purchase_order_type_dashboard	16.0.1.0.0		Purchase Order Type Dashboard
purchase_order_uninvoiced_amount	16.0.1.0.1		Purchase Order Univoiced Amount
purchase_order_weight_volume	16.0.2.2.0		Display purchase order weight and volume
purchase_packaging_default	16.0.1.0.0		Set default packaging in purchase
purchase_packaging_level_qty	16.0.1.0.0		Display purchase order packaging level quantity
purchase_partner_incoterm	16.0.1.0.0		Add a an incoterm field for supplier and use it on purchase order
purchase_partner_selectable_option	16.0.1.0.3		Purchase Partner Selectable Option
purchase_product_packaging_container_deposit	16.0.1.0.0		Purchase Product Packaging Container Deposit
purchase_reception_status	16.0.1.0.1		Add reception status on purchase orders
purchase_reorder_control	16.0.1.0.0		Restrict reordering unpurchaseable product
purchase_request	16.0.1.3.0		Use this module to have notification of requirements of materials and/or external services and keep track of such requirements.
purchase_request_tier_validation	16.0.1.0.0		Extends the functionality of Purchase Requests to support a tier validation process.
purchase_request_type	16.0.1.0.0		Purchase Request Type
purchase_requisition_tier_validation	16.0.1.0.0		Extends the functionality of Purchase Agreements to support a tier validation process.
purchase_return	16.0.1.0.0		Manage return orders.
purchase_sale_link_by_origin	16.0.1.0.0		Link PO/SO by the PO's Origin in addition to the default behavior that only links them by their lines
purchase_security	16.0.2.0.0		See only your purchase orders
purchase_sign	16.0.1.0.0		Purchase Sign
purchase_stock_packaging	16.0.1.0.0		Allows to transmit the product packaging from the procurement values to the generated purchase order line
purchase_stock_price_unit_sync	16.0.1.0.0		Update cost price in stock moves already done
purchase_tag	16.0.1.1.0		Allows to add multiple tags to purchase orders
purchase_tier_validation	16.0.1.1.0		Extends the functionality of Purchase Orders to support a tier validation process.
purchase_triple_discount	16.0.1.0.0		Manage triple discount on purchase order lines
purchase_warn_message	16.0.1.0.0		Add a popup warning on purchase to ensure warning is populated
purchase_work_acceptance	16.0.1.0.0		Purchase Work Acceptance
sale_purchase_force_vendor	16.0.1.0.0		Sale Purchase Force Vendor
supplier_calendar	16.0.1.0.1		Supplier Calendar

Licenses

This repository is licensed under AGPL-3.0.

However, each module can have a totally different license, as long as they adhere to Odoo Community Association (OCA) policy. Consult each module's __manifest__.py file, which contains a license key that explains its license.

---

OCA, or the Odoo Community Association, is a nonprofit organization whose mission is to support the collaborative development of Odoo features and promote its widespread use.

purchase-workflow's Issues

purchase_auto_rfq_bid_selection: restricted tender creates bids, should create rfqs instead

Installing this module the functionality of purchase_requisition_bid_selection gets inverted.
(it creates rfqs instead of bids and vice versa).

Translate Purchase modules

What's the best way to translate some purchase modules? I've requested to join team on transiflex, is it the best solution or maybe I just have to make a PR with .po?

Thanks!

cc @pedrobaeza, @jbeficent

POS returns error after installing purchase_discount

[8.0] purchase_rfq_bid_workflow v8: changing picking type sets destination location to customer

To reproduce:

• create a RFQ
• change the picking type (labeled "Deliver to") to "Chicago"

With the module purchase_rfq_bid_workflow installed, that changes immediately the destination location to "customers". That does not make sense: we are delivering to the (internal) Chicago Warehouse.

This problem is caused by a chained onchange, and because of odoo/odoo#3503 my attempt to show that with a yaml test didn't work (the test does not show this problem).

Discount doesn't goes to the invoice if odoo v8 is configured as invoicing based to incoming shipments.

When Settings => Purchases => Default invoicing control method => is set to "Based to incoming shipments", the discount is set to "0" in the invoice.

In other configurations ("order purchases" or "order lines") it runs ok.

Thank you.

product_by_supplier - weird mandatory field "product" added in supplier edit/add view on product edit

When product_by_supplier installed the overview is nice and useful, but there is a field added when editing or adding a products supplier named "product". A little weird since I am editing a product which the supplier would be for.
Also very uncomfortable, when adding a new product and selecting the supplier I can't select the corresponding product because it's not listed yet.
This field makes no sense at all in my opinion.
If yes, please explain any further what this field would be for...

purchase_order_reorder_lines....Can't get sequence number

Dear Sir

purchase_partial_invoice: purchase line removed from "Invoice control > On Purchase Order Lines" when Invoice is validated

I am experiencing this bug with v8, but, when looking at the code, it seems to be the same on v7. Here is the scenario to reproduce it:

1. install purchase_partial_invoice
2. Create a new PO with 1 PO line quantity 10 and set Invoicing Control = 'Based on Purchase Order lines'
3. validate the PO
4. Go to Invoice Control > On Purchase Order Lines
   Select the purchase order line, start the wizard "Create Invoices" and set "Quantity to invoice" to 3 and validate
   -> it creates a draft supplier invoice. If you look in "Invoice Control > On Purchase Order Lines", the purchase order line is still present (because there is still 7 items left to invoice)
5. Validate the supplier invoice
   Now, if you look in "Invoice Control > On Purchase Order Lines", the purchase order line is NOT there any more... although there are still 7 items left to invoice ! That's the bug !

Code analysis:
In step 5, the purchase order line disappears because it is 'invoiced' = True. The code that writes invoice=True is in addons/purchase/purchase.py line 1470 (on v8) in the inherit of the method invoice_validate() of the object account.invoice:

self.pool['purchase.order.line'].write(cr, uid, invoiced, {'invoiced': True})

I am very surprised by that, because, for me, the module purchase_partial_invoice is not usable with this bug.

A possible solution is to inherit invoice_validate() in the module purchase_partial_invoice to re-write 'invoiced': False for the purchase order lines that are not fully invoiced.

cannot aprove the request

Hi, i trying to approve a requests but i can´t. I use the runboot.

framwork_agreement - agreement line in pricelist must be mandatory

framework_agreement_line_ids = fields.One2many(
    'framework.agreement.line',
    'framework_agreement_pricelist_id',
    'Price lines',
    required=True
)

This required doesn't work as on O2m need to add a constraint

purchase_order_revision...issue question

cancel purchase order.Number: PO1505050001
click new resvision button...show error..

and odoo server log ...

7.0: possible conflict in test run

The 7.0 test run breaks because it does not find an onchange. I haven't investigated further, but the error message

https://travis-ci.org/OCA/purchase-workflow/jobs/31600334#L1125

appears in the tests for purchase_landed_costs, but the it mentions framework_agreement. The modules do not depend on each other.

At a first grance this could be a real incompatibility between the two, or it could be yaml_import.py that struggles with inherited onchange methods.

[purchase_discount] Wrong cost price in product

Hi,
When we select "Average Price" in the costing method of product it's calculated using the field price_unit of stock.move that was generated by purchase order.
This should be fixed for calculate cost price including the discount.

Regards,

purchase_rfq_bid_workflow: on change quantity on sale.order.line

Hi,

Using purchase_rfq_bid_workflow module, at the end of the RFQ that convert it to a draft purchase order, that's is really cool! thanks for that!

I wonder if it's wanted or an issue, when I change the quantity of the product, the onchange method calls it's parent wich reset the unit price that came from the RFQ ?

regards,

[purchase_discount] missing __init__.py inside of models directory

Hi,

After updating directory structure on this module, it now needs init.py inside of models doing import of purchase_discount

Still lacking on git skill, so I still don't know how to do the MP to fix this...

purchase_requisition_multicurrency & purchase_requisition_bid_selecton: Both modules declare "price list" and add it to the view of purchase.requisition

Hi,

I'm new to the module. So there are two fields with the same description and no field help to explain what is the difference between the two fields.

[purchase_request] Non-required field on purchase.request.line

Any technical reason why name or product_id on purchase.request.line is not required? It seems strange if user can add data without both fields.

Thanks is advance.

cc: @jbeficent @aheficent

purchase_landed_costs are red in 7.0

[8.0][purchase_request] Ability to approve items from a purchase request

We have identified a use case by which purchasing wants to be able to decide what items they want to approve for further purchasing (create RFQ or Bid).

SAP uses a similar approach in their Purchase Requisitions. See:
http://web.mit.edu/sapweb/PS1/help/reqs_approve.shtml

What we propose is to introduce a flag 'Approved' in purchase request lines.

Then, have a wizard to approve purchase request lines (so this can done for multiple items at once).

A purchase request that has not been approved cannot be added to a Bid or RFQ.

Another option is to work on an exclusion basis. Have a check 'Rejected' on the purchase request lines. Purchasing can then decide what items are rejected, and those items cannot be purchased.

cc @JonathanNEMRY, @aheficent

product_supplierinfo_discount improvment

hi,

I just saw that this great module was ported in V9.0.

I was thinking to add an extra feature on res.partner. A new field named 'global_discount', that could be the default value on the product supplier info, when created.
What do you think about such feature ?

thanks.

CC @pedrobaeza, @JonathanNEMRY

Migration to version 10.0

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-10.0

Modules to migrate

• framework_agreement
• mrp_smart_purchase
• procurement_batch_generator - By @alexis-via - #483
• procurement_purchase_no_grouping - By @sergio-teruel - #448
• product_by_supplier - By @lreficent - #361
• product_supplierinfo_discount - By @StefanRijnhart - #407
• purchase_all_shipments
• purchase_delivery_address
• purchase_delivery_term
• purchase_discount - By @alexis-via - #316
• purchase_fiscal_position_update - By @alexis-via - #280
• purchase_group_hooks
• purchase_group_orders
• purchase_landed_costs - By @Roodin - #409
• purchase_last_price_info - By @kittiu - #406 By @Abranes - #587
• purchase_multi_picking
• purchase_order_force_number
• purchase_order_line_description - By @cubells - #488
• purchase_order_reorder_lines
• purchase_order_revision - By @cubells - #418
• purchase_order_type - By @kikosanchez - #403
• purchase_origin_address
• purchase_partial_invoicing
• purchase_partner_invoice_method
• purchase_picking_state - By @EBII - #324
• purchase_request - By @adrienpeiffer - #286
• purchase_request_to_rfq - By @adrienpeiffer - #287
• purchase_request_procurement
• purchase_requisition_auto_rfq
• purchase_requisition_auto_rfq_bid_selection
• purchase_requisition_bid_selection
• purchase_requisition_delivery_address
• purchase_requisition_multicurrency
• purchase_requisition_transport_document
• purchase_rfq_bid_workflow
• purchase_transport_document
• vendor_consignment_stock
• purchase_tier_validation

purchase_requisition_bid_selection: Bids selection with unmatched quantity

Test on v8 only.

In the module purchase_requisition_bid_selection when we choose a different quantity as mentioned on the bid (because our supplier won't sale so few products for example) the following message appear which is great::

For some lines, the selected quantity does not match the requested quantity.
Please confirm the    operation.

The user get the choice to confirm the differences or to cancel. I think there is a bug when the user confirm, because the bid state still "Bids selection" instead "Bids selected".

[7.0] 'product_by_supplier' Error in name_search function

At the time of searching for a product the following error appears:

File "/home/jordi/openerp70/openerp70/odoo/openerp/netsvc.py", line 296, in dispatch_rpc
result = ExportService.getService(service_name).dispatch(method, params)
File "/home/jordi/openerp70/openerp70/odoo/openerp/service/web_services.py", line 632, in dispatch
res = fn(db, uid, _params)
File "/home/jordi/openerp70/openerp70/odoo/openerp/osv/osv.py", line 190, in execute_kw
return self.execute(db, uid, obj, method, *args, *_kw or {})
File "/home/jordi/openerp70/openerp70/odoo/openerp/osv/osv.py", line 132, in wrapper
return f(self, dbname, _args, *_kwargs)
File "/home/jordi/openerp70/openerp70/odoo/openerp/osv/osv.py", line 199, in execute
res = self.execute_cr(cr, uid, obj, method, _args, *_kw)
File "/home/jordi/openerp70/openerp70/odoo/openerp/osv/osv.py", line 187, in execute_cr
return getattr(object, method)(cr, uid, _args, *_kw)
File "/home/jordi/openerp70/openerp70/odoo/addons/base_import/models.py", line 325, in do
import_result = self.pool[record.res_model].load(cr, uid, import_fields, data, context=context)
File "/home/jordi/openerp70/openerp70/odoo/openerp/osv/orm.py", line 1383, in load
context=context, log=messages.append):
File "/home/jordi/openerp70/openerp70/odoo/openerp/osv/orm.py", line 1554, in _convert_records
converted = convert(record, lambda field, err:
File "/home/jordi/openerp70/openerp70/odoo/openerp/addons/base/ir/ir_fields.py", line 87, in fn
converted[field], ws = convertersfield
File "/home/jordi/openerp70/openerp70/odoo/openerp/addons/base/ir/ir_fields.py", line 380, in _str_to_many2one
cr, uid, model, column, subfield, reference, context=context)
File "/home/jordi/openerp70/openerp70/odoo/openerp/addons/base/ir/ir_fields.py", line 332, in db_id_for
cr, uid, name=value, operator='=', context=context)
File "/home/jordi/openerp70/openerp70/addons/OCA/purchase-workflow/product_by_supplier/product.py", line 105, in name_search
cr, user, [('partner_ref2', '=', name)] + args,
TypeError: can only concatenate list (not "NoneType") to list

Args is being passed with value 'None', which causes the error.
The +args should be replaced by
args += [('partner_ref2', '=', name)]
and then:
ids = self.search(
cr, user, args,
limit=limit, context=context)

[purchase_discount] missing "view/" path to xml views in __openerp__.py lines #45 and #46

Lines #45 and #46 on openerp.py should change from

    "purchase_discount_view.xml",
    "account_invoice_view.xml",

to

    "views/purchase_discount_view.xml",
    "views/account_invoice_view.xml",

product_by_supplier - add stock info column?

Hi there,
is there any way to get product stock info to this view?
I tried several things in the view.xml but keep getting errors of field not available...

Best,
Thomas

[purchase_request] mutliple PR of the same product by different users

When several users do each a purchase request for the same product, and these requests are grouped in the same purchase order, they end up in the same purchase order line.

After that the tracking is not individualized per purchase request.

For example:

• user A does a PR for qty 1
• user B does a PR for qty 2
• both are grouped in the same RFQ line for a quantity of 3
• the field quantity in RFQ shows 3 for both users
• when receiving, the received quantity is shown in the tracker of both PR

@jbeficent @aheficent given the current data model, I understand why it is so.

Is it by design, do you consider this acceptable or is this an improvement to be considered? Any ideas on this topic?

cc/ @chrisdec @adrienpeiffer @JonathanNEMRY

Purchase discount not taken into account in the purchase report

The module purchase_discount does not overwrite the view of the purchase.report, and therefore the discount is not taken into account into the price.
purchase_report.py, line 99
sum(l.price_unit/cr.rate*l.product_qty)::decimal(16,2) as price_total,

purchase_requisition_bid_selection: Confusion in the naming of the button

This is the description of the functionality: "First, a list of products is established. The call for bid is then confirmed and RFQs can be generated. They are in the state 'Draft RFQ' until sent to the supplier and then marked as 'RFQ Sent'. The bids have to be encoded and moved to state 'Bid Encoded'. When closing the call for bids, in order to start the bids selection, all RFQ that have not been sent will be canceled. However, sent RFQs can still be encoded. Bids that are not received will remain in state 'RFQ Sent' and can be manually canceled."

The problem is that there is no field called "generate bid". The only field is called "encode bid". This creates a confusion by the user as it implies that the bid must be encoded immediately, without doing anything else.

Restrict configuration aspects of an app

Hello!

After fixing a real mess caused by users with Manager that created new units of measure by mistake, I am thinking to restrict some objects, to be changeable only by a specific group for each app.

The concept is that the differences between the typical groups 'User' and 'Manager' are limited to have better visibility, extra functions (such as advanced reports), or the permission to perform certain actions (such as approving timesheets, etc..).

But it's extremely dangerous that a Manager can have access to the most sensitive configuration aspects of the app. Most of the time managers are the clumsiest of users!.

For example, in the inventory, a manager is the only person allowed to perform the action "Validate Inventory", but at the same time he can crate a new unit of measure by mistake when he creates a new product (which is an extremely simple error to make).

I am proposing to create a new group for each app, called "Configuration" (e.g. Purchase / Configuration) that is the only one with permission to change the items defined as 'Configuration' in the menus.

As an example you can see the following:
https://github.com/Eficent/eficent-odoo-addons-wip/tree/7.0/purchase_configuration

Please let me know your views.

Regards,
Jordi.

purchase_order_revision can't working ..on purchase order..partner id same.

Dear Sir:
push this purchase order (PO1601040017)

This is odoo log print.

I dont' know .. WHY?

So..i search purchase order ..from partner...
i get this order...

[purchase_discount] missing trailing parenthesis and "digits_compute" on purchase_discount.py line 43

Line 43 in purchase_discount.py should change from

    'discount': fields.float('Discount (%)', dp.get_precision('Discount'),

to

    'discount': fields.float('Discount (%)', digits_compute=dp.get_precision('Discount')),

purchase_landed_costs

Purchase landed costs doesn't seem to be working on latest V7 addons. When the purchase landed costs are added in the PO and the incoming shipments are processed, the stock journals are being created with the costs not including landed costs. However the same works on previous V7 addons.

[MIG] From 8.0 to 9.0 - Purchase Request modules

purchase_discount: tests failing

https://travis-ci.org/OCA/purchase-workflow/jobs/80804713

framework agreement - get_cheapest_agreement_for_qty fails on sort

https://github.com/OCA/purchase-workflow/blob/8.0/framework_agreement/model/framework_agreement.py#L427

This return a record set. sort() won't work on it.

This raises AttributeError: 'framework.agreement' object has no attribute 'sort' when playing with some onchanges from vertical-ngo/framework_agreement_sourcing

Purchase_discount broken

In the commit 276e53b the module was broken, the columns amount_total, price_subtotal are not affected by discount.

cc @pedrobaeza

Migration to version 9.0

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-9.0

Modules to migrate

• framework_agreement
• mrp_smart_purchase
• procurement_batch_generator #204
• product_by_supplier - By @leemannd - #282
• product_supplierinfo_discount - By @jweste - #272
• purchase_all_shipments
• purchase_analytic_global #228
• purchase_delivery_address
• purchase_delivery_split_date
• purchase_delivery_term
• purchase_discount - #214
• purchase_fiscal_position_update - By @angelmoya - #281
• purchase_group_hooks
• purchase_group_orders
• purchase_landed_costs
• purchase_last_price_info
• purchase_multi_picking
• purchase_order_force_number
• purchase_order_reorder_lines
• purchase_order_revision
• purchase_order_type - @cubells - #310
• purchase_origin_address
• purchase_partial_invoicing
• purchase_partner_invoice_method
• purchase_picking_state - By @chafique-delli - #219
• purchase_requisition_auto_rfq
• purchase_requisition_auto_rfq_bid_selection
• purchase_requisition_bid_selection
• purchase_requisition_delivery_address
• purchase_requisition_multicurrency
• purchase_requisition_transport_document
• purchase_rfq_bid_workflow
• purchase_rfq_number - By @mikevhe18 - #300
• purchase_transport_document
• vendor_consignment_stock

VCI workflow: POS order lines?

What about POS order lines?
How can I include these in the whole product ownership workflow?

Wouldn't it be easier to have the product owner directly saved in the product and start the workflow from there and not from the order lines?

???

Missing labels *needs fixing* and *needs review*

Read OCA/maintainer-tools#29 to know more about it

framework_agreement: should enable group for pricelists by supplier

The configuration for this module is under pricelists/supplier. To show this menuitem, we need to be in group "pricelists by supplier".

It is probably a good idea to add the dependency on purchase/user when installing framework_agreement.

purchase_discount - apps name conflict

Module purchase_discount for series 8.0 belongs to another repository: https://github.com/Vauxoo/addons-vauxoo.git#8.0

@hbto Isn't your version an older one? Can we make this one the reference on apps ?

purchase_reqisition_multicurrency add pricelist but not access right to user purchage requisition

the module purchase_reqisition_multicurrency adds the pricelist to the purchase requisition but not the access right to simple user of purchage requisition. Which make the simple user unable to create a call for bids.

this it what the user get when trying to save the call for bids and obviously and I don't wanna set the user as manager.

"AccessError

Sorry, you are not allowed to modify this document. Only users with the following access level are currently allowed to do that:

• Warehouse/Manager
• Purchases/Manager
• Sales/Manager

(Document model: product.pricelist)"

purchase_requisition_bid_selection: Bids selection I guess `.name` missing somewhere!

Test on v8 only

Using the module purchase_requisition_bid_selection, when selecting products line (click on "Choose product line" in call for bids form). On the grouped line it's display "product.product(4,)" instead the name_get() result.

purchase_requisition_multicurrency: Cannot enter a bid in foreign currency

The system does not allow me to enter a bid in a foreign currency.

I have 2 purchase price lists. one in use and one in euro. When I choose my usd price list in my bid (created via a call for bid), the system automatically changes it in EUR, not letting me enter the price in USD.

Thanks for help

[framework_agreement] Simple framework agreement conflict with warning module

Hi,

On version 7.0, installing both framework_agreement and warning modules break openerp as both modules modify "onchange_product_id" and "onchange_partner_id" functions: It complains that 16 arguments are provided instead of 15 defined in onchange_product_id (respectively 6 instead of 5 defined in onchange_partner_id)

When framework_agreement module is installed after warning module, it works until the next server restart. After the server restart, it seems that the inheritance tree calls the implementation of the above mentionned functions in the warning module first breaking openerp because of the added "agreement" argument in the implementation of the framework_agreement module.

Workaround is to set framework_agreement to depend on the warning module if both are to be installed, but this is quite a dirty fix.
Is there a cleaner solution to this issue ?

Thanks

Tax computation on discounted amount in Purchase Order

After installing the module "purchase_discount", the Discount % field is getting to Purchase Order line. However, tax computation is happening on the line amount before the discount is applied which is wrong.

Ex:

Qty: 1
Unit Price: 100
Disc %: 10.00

Line Amount: 90
VAT 5% amount should be 4.5 instead it is calculating VAT as 5 which is on the before discount amount of 100. This needs to corrected.

Please advice if there is any solution is already available for this issue.

purchase_group_hooks: merge fails if first po has no origin

If you try to merge two POs with a first that has no origin,
the traceback occurs:

  File "/home/rdeheele/machines/openerp_dev/parts/server/addons/web/session.py", line 89, in send
    return openerp.netsvc.dispatch_rpc(service_name, method, args)
  File "/home/rdeheele/machines/openerp_dev/parts/server/openerp/netsvc.py", line 296, in dispatch_rpc
    result = ExportService.getService(service_name).dispatch(method, params)
  File "/home/rdeheele/machines/openerp_dev/parts/server/openerp/service/web_services.py", line 626, in dispatch
    res = fn(db, uid, *params)
  File "/home/rdeheele/machines/openerp_dev/parts/server/openerp/osv/osv.py", line 193, in execute_kw
    return self.execute(db, uid, obj, method, *args, **kw or {})
  File "/home/rdeheele/machines/openerp_dev/parts/server/openerp/osv/osv.py", line 133, in wrapper
    return f(self, dbname, *args, **kwargs)
  File "/home/rdeheele/machines/openerp_dev/parts/server/openerp/osv/osv.py", line 202, in execute
    res = self.execute_cr(cr, uid, obj, method, *args, **kw)
  File "/home/rdeheele/machines/openerp_dev/parts/server/openerp/osv/osv.py", line 190, in execute_cr
    return getattr(object, method)(cr, uid, *args, **kw)
  File "/home/rdeheele/machines/openerp_dev/parts/server/addons/purchase/wizard/purchase_order_group.py", line 71, in merge_orders
    allorders = order_obj.do_merge(cr, uid, context.get('active_ids',[]), context)
  File "/home/rdeheele/machines/openerp_dev/parts/purchase-workflow/purchase_group_hooks/purchase_group_hooks.py", line 233, in do_merge
    grouped_orders = self._group_orders(mergeable_orders)
  File "/home/rdeheele/machines/openerp_dev/parts/purchase-workflow/purchase_group_hooks/purchase_group_hooks.py", line 131, in _group_orders
    input_order
  File "/home/rdeheele/machines/openerp_dev/parts/purchase-workflow/purchase_group_hooks/purchase_group_hooks.py", line 105, in _update_merged_order_data
    order.origin not in merged_data['origin']
TypeError: argument of type 'bool' is not iterable

purchase_requisition_bid_selection - Cancelling Purchase requisition raise an error

When clicking on cancel on a Purchase Requisition in state Draft

  File ".../purchase-workflow/purchase_requisition_bid_selection/model/purchase_requisition.py", line 309, in tender_cancel
    self._cancel_po_with_reason(po_to_cancel, reason_id)
  File ".../server/openerp/api.py", line 235, in wrapper
    return new_api(self, *args, **kwargs)
  File ".../purchase-workflow/purchase_requisition_bid_selection/model/purchase_requisition.py", line 284, in _cancel_po_with_reason
    order.cancel_reason = reason_id
ValueError: "'list' object has no attribute 'cancel_reason'" while evaluating
u'tender_cancel()'

[8.0] [purchase_order_reorder_lines] Error when creatring new purchase order

I'm trying to create a new purchase order and i have that error: ValueError: max() arg is an empty sequence.

File "/home/...../purchase-workflow/purchase_order_reorder_lines/purchase.py", line 71, in _get_max_line_sequence
max(purchase.mapped('order_line.sequence')) + 10
ValueError: max() arg is an empty sequence

Lost return value

I'm grepping community addons to search for a bug I found in the base module.

There is one occurence of this bug in this repository :
https://github.com/OCA/purchase-workflow/blob/8.0/purchase_requisition_multicurrency/model/purchase_requisition.py#L73

See my PR on Odoo : odoo/odoo#11985