ochotonida/bones

A minecraft mod that adds a bunch of skeletal mobs

bones's Issues

need config

spawn rates are ridiculously high! fix it or add config option pls
also would be nice to have an option to blacklist or whitelist biomes for skeletal creatures to spawn

1.18.2 support

Could you port this mod to 1.18.2? Thanks.

Update 1.16 branch

Hi, I'd like to make a pull request to update Bones from 1.16.1 to 1.16.5. However, it seems like the 1.16 branch is the same as the 1.15 branch. Could you please update the 1.16 branch to match the latest 1.16.1 file?

Entity spawn checks can potentially cause a server deadlock

As per #1. From my understanding of the watchdog crash report, the server was waiting on chunk generation, while the chunk generation was waiting on the server. This seems to be a fundamental issue with the mobCondition static function as defined in your Entities class.

The only major difference I can see between that and the default Vanilla is the syntax is slightly different, and possibly in a way that could be causing the issue. Yours:

return spawnReason == SpawnReason.SPAWNER || world.getWorld().getBlockState(blockpos).canEntitySpawn(world, blockpos, entityType);

Vanilla:

return reason == SpawnReason.SPAWNER || worldIn.getBlockState(blockpos).canEntitySpawn(worldIn, blockpos, typeIn);

I believe that dereferencing the IWorld instance into an actual world is what's causing the problem. My understanding of the world generation code in 1.14 is a little bit fuzzy, but I believe what you are actually getting is an instance of WorldGenRegion, which you can use getBlockState etc for all of the relevant blocks as it translates it to the chunk currently being generated (and not yet existing in the world).

By trying to convert that back into the actual World instance and then use that with getBlockState, it then results in some sort of deadlock loop.

Changing your code to remove the getWorld() should fix the problem immeditately.

bones seems to be crashing servers with world gen

https://pastebin.com/hdV7wVDJ - crash report

i don't know what the cause is, but something about your mod causes chunk errors. whenever i enter theses broken chunks the game locks up and my server crashes.