ochotonida/candymod

candymod's Issues

Custom dimension

title

WorldGenGummyWorm can lock server thread

MC: 1.12.2
Forge: 14.23.5.2847
CandyWorld: 1.1.4

Hi!

Darkosto has been using this mod in an upcoming Modpack where the world is generated as large hexes, we use your biomes for some of the hexes.
We have encountered a generation issue when a Gummy Swamp spawns next to a Void hex and the WorldGenGummyWorm happens to run on the edge of the biome the server thread enters an infinite loop.

With some debugging and thread dumping I've found that the findSurfaceBlock() method will run infinitely if it's over a Void. The isAirBlock() check in isAirOrLiquid() always returns true when below 0 so I suggest to add a check of Y being above 0.

I know this very special edge case and not intended by the mod but would appreciate it being fixed.

Weapons and tools not held correctly by player

Easy to replicate, just craft (or spawn in) a tool or weapon and compare how they'd be held to a vanilla item of the same type.

Players respawn in the dimension instead of the overworld

Since it is currently hard to make a teleporter while in the dimension, players might get stuck in the dimension

Sleeping in the dimension does not advance the time

I'm don't know how to fix this at the moment, so this probably won't get fixed anytime soon

Teleporter recipe broken

title

minecraft 1.12.2 error loading candyworld 1.1.4

hello,
that error ocurrs if i start minecraft 1.12.2 :

et.minecraftforge.fml.common.LoaderExceptionModCrash: Caught exception from Candy World (candymod)
Caused by: java.lang.IllegalArgumentException: Failed to register dimension for id 23, One is already registered
at net.minecraftforge.common.DimensionManager.registerDimension(DimensionManager.java:134)
at com.ochotonida.candymod.world.dimension.Dimension.init(Dimension.java:14)
at com.ochotonida.candymod.proxy.CommonProxy.preInit(CommonProxy.java:20)
at com.ochotonida.candymod.proxy.ClientProxy.preInit(ClientProxy.java:44)
at com.ochotonida.candymod.CandyMod.preInit(CandyMod.java:50)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at net.minecraftforge.fml.common.FMLModContainer.handleModStateEvent(FMLModContainer.java:637)
at sun.reflect.GeneratedMethodAccessor14.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at com.google.common.eventbus.Subscriber.invokeSubscriberMethod(Subscriber.java:91)
at com.google.common.eventbus.Subscriber$SynchronizedSubscriber.invokeSubscriberMethod(Subscriber.java:150)
at com.google.common.eventbus.Subscriber$1.run(Subscriber.java:76)
at com.google.common.util.concurrent.MoreExecutors$DirectExecutor.execute(MoreExecutors.java:399)
at com.google.common.eventbus.Subscriber.dispatchEvent(Subscriber.java:71)
at com.google.common.eventbus.Dispatcher$PerThreadQueuedDispatcher.dispatch(Dispatcher.java:116)
at com.google.common.eventbus.EventBus.post(EventBus.java:217)
at net.minecraftforge.fml.common.LoadController.sendEventToModContainer(LoadController.java:219)
at net.minecraftforge.fml.common.LoadController.propogateStateMessage(LoadController.java:197)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at com.google.common.eventbus.Subscriber.invokeSubscriberMethod(Subscriber.java:91)
at com.google.common.eventbus.Subscriber$SynchronizedSubscriber.invokeSubscriberMethod(Subscriber.java:150)
at com.google.common.eventbus.Subscriber$1.run(Subscriber.java:76)
at com.google.common.util.concurrent.MoreExecutors$DirectExecutor.execute(MoreExecutors.java:399)
at com.google.common.eventbus.Subscriber.dispatchEvent(Subscriber.java:71)
at com.google.common.eventbus.Dispatcher$PerThreadQueuedDispatcher.dispatch(Dispatcher.java:116)
at com.google.common.eventbus.EventBus.post(EventBus.java:217)
at net.minecraftforge.fml.common.LoadController.distributeStateMessage(LoadController.java:136)
at net.minecraftforge.fml.common.Loader.preinitializeMods(Loader.java:629)
at net.minecraftforge.fml.client.FMLClientHandler.beginMinecraftLoading(FMLClientHandler.java:252)
at net.minecraft.client.Minecraft.func_71384_a(Minecraft.java:467)
at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:378)
at net.minecraft.client.main.Main.main(SourceFile:123)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
at net.minecraft.launchwrapper.Launch.main(Launch.java:28)

Crash with Primitive Mobs

Forge v14.23.3.2682
Primitive Mobs v1.1.6_beta
Candy World v0.4.3
I got a crash when a Rocket Creeper from Primitive Mobs exploded in the Cotton Candy biome.
Crash Report

Gummy worms load unloaded chunks during worldgen

[ModName] loaded a new chunk (XXXX, X Dimension: XX) during chunk population, causing cascading worldgen lag. Please report this to the mod's issue tracker. This log can be disabled in the Forge config.

Candy cane blocks cannot be mined by hand

Beds explode in dimension

Flowing liquid candy blocks don't emit light

Certain gummy recipes conflict with candy cane recipes

Candy mountain biome

A biome made mostly of crystallized sugar, formed into mountains.

magic piece of candy not teleporting

in the latest version, the magic piece of candy does not work. the candy will not be consumed like you are traveling to the dimension and a portal sound will play but nothing will happen. checking the logs the mod doesnt issue any commands either. when eaten again the magic piece of candy will still not be consumed, unlike when travelling back.

Add readme.md

Should add a readme file to your github with basic information.

Example: https://github.com/BuiltBrokenModding/ICBM/blob/development/README.md

Pick block on crystal sugar cookie ore returns regular cookie ore

.lang files missing entries

Currently, the following .lang files are missing entries:

****:

Gonna leave this open (possibly indefinitely) so I can always add more

Butter's recipe conflict

I found some recipe conflicts whose ingredient is a bucket of milk.
candymod:butter = This mod's butter.
harvestcraft:freshmilkitem = Pam's Harvestcraft's fresh milk.
chinjufumod:item_butter = Chinjufu's butter.
minecraft:milk_bucket->candymod:butter
minecraft:milk_bucket->harvestcraft:freshmilkitem*4
https://github.com/MatrexsVigil/harvestcraft/blob/master/src/main/resources/assets/harvestcraft/recipes/freshmilkitem_minecraft_milk_bucket.json
minecraft:milk_bucket->chinjufumod:item_butter
https://github.com/Ayutaki-Shou/ChinjufuMod3.x/blob/master/1.12.2/src/main/resources/assets/chinjufumod/recipes/item_butter.json

magic candy causes infinite hunger

not sure if this is an intended effect but eating the magic candy causes the player to have infinite hunger and sprint, even the hunger effect does not lower the hunger bar. i had to do hunger 255 to have it even make a dent, and even then it went all the way back up after the effect was over.

Teleporter item can only be used in survival mode

Gummy based food items have grey particles when eaten

Title. This is because they all use the same (grayscale) texture and get colorized with their respective colors, but apparently the particles aren't.

Client-side method gets called by server in BlockCandyGrass causing the game to crash

title