ochotonida/some-assembly-required

Some Assembly Required

Some Assembly Required is a Farmer's Delight addon loosely based on the fabric mod Sandwichable. More information can be found here: https://www.curseforge.com/minecraft/mc-mods/some-assembly-required

Customizing Items on Sandwiches

In version 2.0.0 and above, it is possible to customize the behavior and appearance of items on sandwiches through data packs. Ingredient JSONs are placed in the data/<namespace>/some_assembly_required/ingredients folder. Each JSON file corresponds to a single item. Items with a corresponding ingredient JSON can be added onto a sandwich even if the item is normally not edible. The following fields can be customized (All fields are optional except item):

• item: (required) The corresponding item id for this ingredient. (The file name does not need to correspond to the item name. However, if there are multiple ingredient JSONs for a single item, only one will be loaded)
• food: A json object, replaces the item's food stats when it is on a sandwich.
  • nutrition: (required) The amount of hunger the item heals.
  • saturationModifier: (required) The amount of saturation the item restores per point of hunger healed.
  • canAlwaysEat: (default = false) When true, sandwiches containing this item can be always eaten.
• displayName: The name of the item as it should appear in the name of the sandwich. This is a text component, information on how to format these can be found here. (You can also use a string)
• fullName: The name of the item as it should appear in the tooltip of the sandwich. (If the display name is omitted, and the full name is set, the full name is also used as the display name)
• displayItem: A json object describing an item stack, overrides which item is rendered when this item is on a sandwich
  • item: (required) The item ID of the item to render instead.
  • count: The size of the item stack.
  • nbt: The NBT of the item stack, either as a JSON object or stringified NBT.
• renderAsItem: (default = true) Set this to false when the display item has a custom model. Flat item models are rotated and translated by default.
• height: (default = 1) The height of the model of this item, in pixels. (Determines the size of the gap between the previous item on the sandwich and the next)
• container: A json object describing an item stack (see displayItem). If an item has a container, the container item will be returned to the player when the item is put on a sandwich. When an item with a container is removed from a sandwich, the item is voided instead of returned.
• soundEvent: A sound event id. Changes the sound this item makes when added or removed from a sandwich.

For some example ingredients, see the default data pack.

some-assembly-required's Issues

[Request] Whitelist of non-food items

Description
Being able to put certain configurable items in a sandwich that aren't directly edible, such as sugar, or salt from other mods

Problem or Reasoning
Mainly this would be for aesthetic reasons, but might also add something to the sandwich like mayonnaise does. I wanna put pepper on my BLT's!

How it will work
A whitelist in the config would determine what items should be used in sandwiches regardless of edibility. These could either just do nothing, or perhaps give a small boost to saturation of the finished product.

[1.18.1] Crash when Diet tries to render nutrition tooltips on Sandwiches with any Potion added

Crash report:
crash-2022-03-12_13.19.18-client.txt

starts at

some-assembly-required/src/main/java/someassemblyrequired/integration/diet/DietCompat.java

Line 34 in fd08836

new ImmutableTriple<>(handler.getItems(), handler.getTotalNutrition(), handler.getAverageSaturation())

where

some-assembly-required/src/main/java/someassemblyrequired/common/item/sandwich/SandwichItemHandler.java

Lines 67 to 73 in fd08836

	public int getTotalNutrition() {
	int result = 0;
	for (ItemStack stack : items) {
	result += Ingredients.getFood(stack).getNutrition();
	}
	return result;
	}

but

some-assembly-required/src/main/java/someassemblyrequired/common/ingredient/Ingredients.java

Lines 51 to 53 in fd08836

	public static FoodProperties getFood(ItemStack item) {
	return IngredientPropertiesManager.getOrDefault(item).getFood(item);
	}

some-assembly-required/src/main/java/someassemblyrequired/common/ingredient/PotionProperties.java

Lines 27 to 29 in fd08836

	public FoodProperties getFood(ItemStack item) {
	return null;
	}

[Suggestion] JEI Integration

I'm not sure if the title is worded correctly but what I mean is adding the toaster to the left of the JEI interface when a recipe is selected that requires the toaster (for example). It's a small thing but it saves a bit of time when you want to know a crafting recipe.

Example: when selecting a recipe, you'll see all the, in this case, crafting table variants on the left.

The recipes from this mod don't have that.

The item lays vertically on the cutting board in the newer version of forge

I don't have much time to check since what version does this but it works fine in 43.1.43 and looks vertically in 43.1.57
here's the image of the bug

Cutting Board Server & Client Crash

Minecraft v1.16.4
Forge v35.1.13
Some Assembly Required v1.1.0
Pokecube AIO v3.4.1
Fariy Lights v4.0.3

When I tried to place a cutting board, the server crashed with Pokecube AIO, while at the same time, the client crashed with Fairy Lights...
Client Crash Report
Server Crash Report

Multiplayer Crash on block destroy

When breaking a placed sandwich, or breaking the sandwich assembly table, any other players on a multiplayer server within a certain range crash to desktop.

crash-2020-12-26_17.34.09-client.txt

Food doesn't update right.

Sometimes when a sandwich is being eaten, it doesn't update hunger correctly.
I've just eaten 5 sandwiches, took damage and the hunger was back to where it was before.

Missing Piglin Tag

Minecraft v1.16.4
Forge v35.1.28
SAR v1.2.4

The golden apple and carrot slices are missing the tag #minecraft:piglin_loved.

[Suggestion]When the stacking of sandwiches meets certain conditions, specific food can be output.

Just a whim, can a new 'sandwich recipes' be created in the data package so that a specific food can be stacked by modifying the data package?For example, when I stack in the order of bread slices, cooked bacon, cabbage, tomatoes, and bread slices on the Sandwich Assembly Table, I can ultimately output a bacon sandwich of farmer's delight.

[1.16.5-1.3.0] List of missing/incomplete translation keys

This issue is here to provide an overview of missing translation keys for people that want to contribute.
I'll keep this comment updated when new versions are released.

Currently:
de_de is up to date.
pt_br is missing the following entries from update 1.16.5-1.3.0:

• advancements:
  • all titles & descriptions
• blocks:
  • lettuce (crop)
  • tomatoes (crop)
• items:
  • tomato, tomato slices/seeds
  • ketchup
  • lettuce head/leaf/seeds
• sandwich item names:
  • BLT
  • most of the other sandwich names could use another look as well, I changed how sandwich names are generated and had to extrapolate a bit
• ingredient names: (these are the names of items as they appear in the display name of a sandwich)
  • everything except toast
• spread types:
  • mayonnaise
• JEI descriptions:
  • tomato, tomato slices, ketchup
  • lettuce head/leaf
  • a lot of these have changed since I've moved them from the tooltip to JEI, could use a check if these are still accurate

Achievements for 1.18

Hey,
I compared 1.16 translation files with 1.18's and noticed the BLT achievement was missing in the newer version. I'm guessing it's on purpose, so my question is:
What changes regarding achievements have you planned? Anything new and/or anything less?

Crash with Create spout recipes

On latest version of Create, FD, and SAR. Was playing on a server with a friend. Added a half-complete sandwich to a spout with chocolate and the server crashed until we relaunched it without this mod loaded.

latest.log

Tomato/Onion Slices unobtained via cutting board

When I cut tomatoes/onions using the cutting board, I don't get anything forcing me to resort to using the mechanical saw.

Huge Error (Crashes) With Corail Recyler. (1.18.2)

Seems to be an issue with a recipe

Description: Exception in server tick loop

java.lang.NullPointerException: Cannot invoke "net.minecraft.world.item.ItemStack.m_41619_()" because "recipeItem" is null
at org.cursegame.minecraft.dt.recipe.RecipeProvider.loadRegisteredRecipes(RecipeProvider.java:93) ~[Corail-DT-1.18.2-465.jar%2362!/:465] {re:classloading}
at org.cursegame.minecraft.dt.recipe.RecipeProvider.loadRegisteredRecipes(RecipeProvider.java:151) ~[Corail-DT-1.18.2-465.jar%2362!/:465] {re:classloading}
at org.cursegame.minecraft.dt.recipe.RecipeService.loadRecipes(RecipeService.java:97) ~[Corail-DT-1.18.2-465.jar%2362!/:465] {re:classloading}
at org.cursegame.minecraft.dt.recipe.RecipeService.initialize(RecipeService.java:73) ~[Corail-DT-1.18.2-465.jar%2362!/:465] {re:classloading}
at org.cursegame.minecraft.dt.ModDT.onServerStarted(ModDT.java:67) ~[Corail-DT-1.18.2-465.jar%2362!/:465] {re:classloading}
at net.minecraftforge.eventbus.ASMEventHandler_288_ModDT_onServerStarted_ServerStartedEvent.invoke(.dynamic) ~[?:?] {}
at net.minecraftforge.eventbus.ASMEventHandler.invoke(ASMEventHandler.java:85) ~[eventbus-5.0.3.jar%232!/:?] {}
at net.minecraftforge.eventbus.EventBus.post(EventBus.java:302) ~[eventbus-5.0.3.jar%232!/:?] {}
at net.minecraftforge.eventbus.EventBus.post(EventBus.java:283) ~[eventbus-5.0.3.jar%232!/:?] {}
at net.minecraftforge.server.ServerLifecycleHooks.handleServerStarted(ServerLifecycleHooks.java:103) ~[forge-1.18.2-40.1.52-universal.jar%23145!/:?] {re:mixin,re:classloading}
at net.minecraft.server.MinecraftServer.m_130011_(MinecraftServer.java:662) ~[server-1.18.2-20220404.173914-srg.jar%23140!/:?] {re:mixin,pl:accesstransformer:B,re:computing_frames,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:APP:terrablender.mixins.json:MixinMinecraftServer,pl:mixin:A}
at net.minecraft.server.MinecraftServer.m_177918_(MinecraftServer.java:261) ~[server-1.18.2-20220404.173914-srg.jar%23140!/:?] {re:mixin,pl:accesstransformer:B,re:computing_frames,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:APP:terrablender.mixins.json:MixinMinecraftServer,pl:mixin:A}
at java.lang.Thread.run(Thread.java:833) [?:?] {re:mixin}

And yes. It's only when SAR is installed.

Farmer's Delight 0.4.2 and Some Assembly Required incopatibilities

I just noticed a recent update with "Farmer's Delight" (0.4.2) that "Cabbage Rolls now consult the tag farmersdelight:cabbage_roll_ingredients"

-It seems like with Some Assembly Required and Farmer's Delight installed it seems to throw an error when you have both.

• Unsure if this is something on your side with the compatiblity you have or on Farmer's Delights side.

[1.18.1] Recipe Overlaps make certain automation impossable

I was experimenting around and found that the sandwich system seems to break other recipes for some unknown reasons

for example, anything using the spout gets turned into a sandwich for some reason (bucket fluid sandwich)

please look into this, its kind of annoying

Repoducing this should be as simple as having the spout trying to fill a fluid up in an item that should NOT be a sandwich

Any items on sandwich

IllegalStateException error on world creation / load with Immersive Engineering

Generating or loading a world gives this error ever since installing this mod

This only happens with Immersive Engineering
https://pastebin.com/Kn0cnh5T
I have no actual datapacks installed

JEI does not render

Minecraft v1.18.1
Forge v39.0.88
Farmer's Delight v1.0.3
Some Assembly Required v2.0.0
JEI v9.4.1.110

After installing Some Assembly Required, I noticed that JEI would not load. After removing SAR, JEI started working again. I'm not sure what is causing this error when connecting to my server.
Latest.log

There is a conflict between SAR and ExtraDelight

Hello, I noticed a conflict between [SAR] Some Assembly Required and another mod {ExtraDelight}. Both can obtain bread slices by cutting bread, but the obtained items are not interchangeable and I am currently unable to obtain bread slices from SAR. So, could you please solve this problem? It would be best to merge the two types of bread slices, thank you very much!

[Suggestion] Customizable Sandwich Bases

Before we start, I'm not talking about the already existing method to add other items that function as bread, I'm more suggesting a "sandwich" type system, if that makes sense (which is why there's more to this suggestion :P).

My idea is that there could be a similar format to registering ingredients for registering bread types. This format would include the specifications of the sandwich it was meant to create, for example, if you wanted to create a salad bowl "sandwich" you could only allow it to create open faced sandwiches, whitelist / blacklist ingredients, and perhaps modifiers to the sandwiches effects and/or nutrition.

Also, in the future you could extend this idea:

• multiple "bites" per sandwich type
• a liquid only "sandwich" (smoothie?)
• different top and bottom bread types (i.e. burger buns)
• limits on the number of ingredients per sandwich type instead of globally

Create Error?

An odd error pops up when using latest forge version for 1.18.2, and latest version for both create and sar(some assembly required).

The error: Exception caught during firing event: BUILDERS_TEA

The entire log:
8-15-7.log
.

Onions not able to be cut.

Not really a bug but it seems odd that you made all the other items able to be cut into pieces. Apples, tomatoes, beets, carrots. But for some reason, there was no love for the onion. Would you consider adding that?

Thanks!

Broken Tag

Minecraft v1.16.5
Forge v36.1.4
SAR v1.3.4

I found this in my log: Couldn't load item tag forge:raw_pork as it is missing following references: minecraft:raw_porkchop.
I believe the item id is simply minecraft:porkchop.

Suggestion: Vegan patty from miner delight

just a suggestion to make a 3d variant for the vegan patty from Miner's Delight (like the patty from Farmer's Delight)

Sorry to bother you. (also didn't know if this was the place to suggest the variant or not, just took a guess, sorry to bother)

[Enhancement] Any items on sandwich

It would be cool if there was a config to allow you to put any items on sandwiches.

Farmer Delight's advancement

Can you include SAR's cutting board to FD cutting board advancement trigger?
Background: I want to unify the mods, so i disabled FD cutting board, but it's impossible to get FD's cutting board advancement without using FD's.

:)