Comments (1)
john-u
commented on May 27, 2024
2
This is related to #453 which impacted our project as well. We have a command that opens up an SSE connection for message streaming that was all of the sudden timing out after upgrading to newer versions of @oclif/core. It seems like commands that hit this issue violate an undocumented assumption from oclif: if the Node process is still busy after Command.run() resolves, something went wrong in the framework. Any command logic should either complete synchronously or await a Promise before the end of the run context. In this case, the flush function had a bug that made it not work and a recent PR fixed this which surfaced the issue for us and others. Here is an example of how we resolved it in our command.
Would it be worth updating the docs to point this out?
from core.
Related Issues (20)
- TypeScript 4.8 complains `*.d.ts` HOT 2
- Boolean flags don't read environment variables
- Argument parsing fails with `TypeError: Cannot use 'in' operator to search for 'default' in undefined` HOT 1
- argument not read, if after a flag with multiple: true HOT 4
- Errors with 1.16.4 and typescript 4.8.3 HOT 1
- Deno Support for Packaging HOT 5
- if a command has a flag with `multiple:true` it will not error out on a non-existent flag (the non-existent flag ends up as the arg) HOT 3
- Hooks are not working properly HOT 4
- Can you release new version of @oclif/core to npm? HOT 1
- help for a command: description section adds an extra newline per line HOT 1
- Unnecessary warnings when command flags are marked as deprecated
- Adding `strict=false` parses a non-existing flag as a `arg`
- TypeError: Cannot read properties of undefined (reading 'warnIfFlagDeprecated') HOT 16
- Issues when running script from Usage in readme HOT 2
- Import packge.json (using esm) HOT 1
- Adding plugins from GitHub/Gitlab repositories HOT 2
- topics with no same-name command give odd help info HOT 2
- when does not support flags with false values
- [observed in v2] cli exits with code 0 even when the command is incorrect HOT 2
- `./bin/dev` loads from /src/commands ONLY if `/dist` does not exist HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from core.