ocochard/graphpath

Graphpath generates an ASCII network diagram from the route table of a Unix/Linux

graphpath's Issues

Minor formatting error on Fedora 27

+----------------------------+    +----------------------------+
| SOURCE HOST                |    | DESTINATION HOST           |
| IP:   xxxxxxxxxxxxx        |    | IP:  xxxxxxxxxx            |
| ARP:  xxxxxxxxxxxxxxxxx    || ARP:  xxxxxxxxxxxxxxxxx    |    |                            |
+----------------------------+    +----------------------------+
                  |                             |
                  |               +----------------------------+
                  |               | ROUTER TOWARDS DESTINATION |
                  |               | IP:   xxxxxxxxxxxxx        |
                  |               | ARP:  xxxxxxxxxxxxxxxxx
xxxxxxxxxxxxxxxxx|
                  |               +----------------------------+
                  |                             |               
            --+---+-----------------------------+---
                  |
...

Looks like src_gateway_arp is coming out as:

"xxxxxxxxxxxxxxxxx\n
xxxxxxxxxxxxxxxxx"

so changing to:
printf '| ARP: %-18s |' "${src_gateway_arp:0:17}"
works.

Testing on Darwin/MacOS

Hello!

As this script is written, once installed on a Mac, and the user enters graphpath $source-ip $destination-ip, the user gets the following output:

-n EXIT:
This script was not tested on Darwin

I am not certain if this is on the roadmap, but I would love to test this on MacOS/Darwin. I know it would be as simple for me as editing the case statement, but if you have no plan to support Darwin in the future, it probably wouldn't be worth my time. If you do, however plan on supporting Macs, I would be more than happy to help.

Thanks again!

packing up new version for homebrew formula

Hello!

Thanks for making such a great tool. I've made a homebrew formula around it, but I'm seeing an error when building, because it appears that the v1.0 release is two commits behind current HEAD. I can add some handling to work around this, but I figured I would ask if it was all right for me to create a v1.1.0 release for these commits before I write the work-around in the homebrew formula.

Thanks!

No IPv6 Support

I can't use this for IPv6 addresses.

graphpath: 179: local: |: bad variable name

Hi there,

I'm testing this script on Debian sid and I see the error in the title.

More complete the more complete output:

$ ./graphpath 192.168.20.132 8.8.8.8
+-----------------------------+  +-----------------------------+
| SOURCE                      |  | DESTINATION                 |
| IP:   192.168.20.132        |  | IP:   8.8.8.8               |
| ARP:                        |  |                             |
+-----------------------------+  +-----------------------------+
              |                            |
./graphpath: 179: local: |: bad variable name

I was able to fix this and make the script run correctly by changing the she-bang on line one like this:

diff --git a/graphpath b/graphpath
index c00e722..7842cc5 100755
--- a/graphpath
+++ b/graphpath
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
 #
 # Graphpath generates an ASCII network diagram from the route table of a Unix/Linux
 # https://bsdrp.net

It seems as though the script makes the assumption that /bin/sh is bash, which is not true on many distros / platforms.

on debian, /bin/sh is normally linked to dash which has very limited functionality and has more a feeling of plain-old-sh-before-bash.