octopus-network/pallet-octopus-appchain

FRAME pallet for joining the octopus network as an appchain.

moved to https://github.com/octopus-network/octopus-pallets/tree/main/appchain

Octopus Appchain Pallet

A pallet for integrating Substrate-based blockchain as Octopus Appchain.

Reference Docs

You can view the reference docs for this pallet by running:

cargo doc --open

pallet-octopus-appchain's Issues

Batch processing observations

pallet-octopus-appchain/src/lib.rs

Line 657 in e018695

Self::fetch_facts(T::RELAY_CONTRACT.to_vec(), appchain_id, next_fact_sequence, 1)

pallet-octopus-appchain/src/lib.rs

Line 672 in e018695

observation: obs[0].clone(),

Currently, we fetch only one observation from mainchain and process it.
We should fetch multiple observations at a time, change observation of payload to observations, then make the corresponding changes to Call::submit_observation

Add an integration test to observe mainchain events

change FactSequence to NextFactSequence

pallet-octopus-appchain/src/lib.rs

Line 249 in 1ccea1c

pub type FactSequence<T: Config> = StorageValue<_, u64, OptionQuery>;

FactSequence currently tracks the current fact seq_num of appchain.
Changing its meaning to NextFactSequence would greatly simplify the code.
And its type will change from Option<u64> to 64.

Move `RELAY_CONTRACT` to chain storage

pallet-octopus-appchain/src/lib.rs

Line 223 in e018695

const RELAY_CONTRACT: &'static [u8];

so we can switch an appchain to the dev testnet to test it.
refer to:

pallet-octopus-appchain/src/lib.rs

Line 237 in e018695

pub(super) type AppchainId<T: Config> =

Fix tests

$  cargo test -p pallet-octopus-appchain

error[E0046]: not all trait items implemented, missing: `PalletId`, `Currency`
   --> bin/node-template/pallets/octopus-appchain/src/mock.rs:187:1
    |
187 | impl pallet_octopus_appchain::Config for Test {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `PalletId`, `Currency` in implementation
    | 
   ::: bin/node-template/pallets/octopus-appchain/src/lib.rs:244:9
    |
244 |         type PalletId: Get<PalletId>;
    |         ----------------------------- `PalletId` from trait
245 | 
246 |         type Currency: Currency<Self::AccountId>;
    |         ----------------------------------------- `Currency` from trait

error: aborting due to previous error

For more information about this error, try `rustc --explain E0046`.
error: could not compile `pallet-octopus-appchain`

Adjust token decimals

Use the same decimal as on the mainchain.
USDC: 6
OCT: 18

Add a limit to the cross-chain messages submitted

see snowfork:

134         /// Submit message on the outbound channel
135         pub fn submit(who: &T::AccountId, target: H160, payload: &[u8]) -> DispatchResult {
140                 ensure!(
141                         MessageQueue::decode_len().unwrap_or(0) < T::MaxMessagesPerCommit::get(),
142                         Error::<T>::QueueSizeLimitReached,
143                 );
144                 ensure!(
145                         payload.len() <= T::MaxMessagePayloadSize::get(),
146                         Error::<T>::PayloadTooLarge,
147                 );

Look up asset name in AssetIdByName

pallet-octopus-appchain/src/lib.rs

Line 560 in 1ccea1c

token_id: "USDC.testnet".as_bytes().to_vec(), // TODO

The name of the asset should be looked up before burn_from, return an error if the asset doesn't exist.

mainchain endpoint should be specified by the node's command-line argument

pallet-octopus-appchain/src/mainchain.rs

Line 65 in e018695

.url("https://rpc.testnet.near.org")

so different nodes can use different endpoints to access mainchain.