after update to 0.27.0 Edm.Decimal as string

[bi-tm]

after update to 0.27.0 Edm.Decimal as string

[texttechne]

Hi @bi-tm,

yeah that was a breaking change in the v2-to-v4-converter: here's the commit

Does it really make sense to convert Edm.Decimal to number? You could have a potential precision loss...

[texttechne]

Ok, I've introduced this breaking change in the wake of developing the converter-ui5-v2: The V2 OData model of SAP doesn't convert Edm.Int64 or Edm.Decimal. I think I was a little helpless there...

I've found a better solution now:

• by default, the converter-v2-to-v4 will transform both types to number
• this is how V4 behaves anyway
• I've added a bigNumberNoopConverter which overrides this behaviour and leaves the types to be string
  • this is used by the converter-ui5-v2

Please update @odata2ts/converter-v2-to-v4 to version 0.3.0.

[texttechne]

@bi-tm if this works for you, then please close the ticket.

And the question from my side remains: Don't you have any concerns regarding precision loss? Or is this data type mapping just a little bit imprecise (like Edm.Double would be already enough but it's mapped to Edm.Decimal anyway)?