odex64/sfr

Extensive mod for Superfighters Deluxe

sfr's Issues

[editor] Graphical editor

[bug] Unable to update spawn chances for SFR items via Script API

Game.GetWeaponSpawnChances and Game.ClearWeaponSpawnChances methods work as expected, however Game.UpdateWeaponSpawnChances method won't mutate the values of SFR items.

The game does not start, installed everything correctly

The game throws an error when starting:
Unhandled Exception: System.AccessViolationException: Attempted to read or write protected memory. This is often an indication that other memory is corrupt.
at MonoMod.Core.Platforms.Architectures.x86Shared.TryRel32Detour(IntPtr from, IntPtr to, Int32 sizeHint, NativeDetourInfo& info)
at MonoMod.Core.Platforms.Architectures.x86Arch.ComputeDetourInfo(IntPtr from, IntPtr to, Int32 maxSizeHint)
at MonoMod.Core.Platforms.PlatformTriple.CreateSimpleDetour(IntPtr from, IntPtr to, Int32 detourMaxSize, IntPtr fromRw)
at MonoMod.Core.Platforms.PlatformTripleDetourFactory.Detour.CreateDetour()
at MonoMod.Core.Platforms.PlatformTripleDetourFactory.DetourBase.Apply()
at MonoMod.Core.Platforms.PlatformTripleDetourFactory.CreateDetour(CreateDetourRequest request)
at MonoMod.Core.DetourFactory.CreateDetour(IDetourFactory factory, MethodBase source, MethodBase target, Boolean applyByDefault)
at HarmonyLib.PatchTools.DetourMethod(MethodBase method, MethodBase replacement)
at HarmonyLib.PatchFunctions.UpdateWrapper(MethodBase original, PatchInfo patchInfo)
at HarmonyLib.PatchClassProcessor.ProcessPatchJob(Job job)
at HarmonyLib.PatchClassProcessor.PatchWithAttributes(MethodBase& lastOriginal)
at HarmonyLib.PatchClassProcessor.Patch()
at HarmonyLib.Harmony.b__10_0(Type type)
at HarmonyLib.CollectionExtensions.Do[T](IEnumerable1 sequence, Action1 action)
at HarmonyLib.Harmony.PatchAll(Assembly assembly)
at HarmonyLib.Harmony.PatchAll()
at SFR.Program.Main(String[] args)

[editor] Support for SFD's proprietary formats

[bug] Claymores will be tripped before arming in Offline lobbies

_tripped is set to true in two different places (idk why?), and the one inside the Draw() method causes this issue.
I removed the one in the Draw() method which seemingly worked just as fine, both for offline and networked lobbies.

[editor] Encode/decode .xnb files

Does not launch through Proton on Linux

I just want to leave this issue here in case someone who has more experience with Proton is able to find a solution.

First of all, you need to put %command%/../SFR.exe in launch options - note how the slashes are reversed compared to the usual way.
Then when you try to launch the game you will be presented with a choice, if you choose 1. SFR, then another terminal window called "Wine Debugger" will briefly open and that's it. That's how far I got.
If you choose option 2. SFD then vanilla sfd will launch with no issues.

Tested with Proton5.0-10, GE-Proton8-14, GE-Proton8-25.
Also installed dotnet45 with winetricks as required for vanilla sfd

A screenshot of the terminal, maybe that could be a lead. (I'm only seeing the exception on GE-Proton8-14 though)

this doesn't mine bitcoin

I was hoping this was a bitcoin miner so i could distribute it and take some free money but it's not the case. 0/10

[editor] Basic window for converting files

[feature request] Add transparent - invisible player skin for use in scripts

A scriptable, but not user selectable invisible player skin could be used for various mechanics such as a powerup, or a boss ability.
BotExtended already has one Invisible.xnb but it is user selectable.

[editor] Items editor

Experimental editor to edit/create custom items for SFD/SFR

• #16
• #17
• #18
• #20

Optimization

• Multiple patches of the same method should be merged to reduce overhead.
• Long patches or code that modifies methods in the middle should be turned into transpilers.
• Improve existing code where possible.