[Request] Implement Private Profiles

[Aluerie]

[Request] Implement Private Profiles

[howardchung]

Made some more fixes for recentMatches--should work again!

As for the storing all data for players, we have not made that change yet. It requires some more planning around how we store the data. So for now, if you want to have data available, you will need to make your profile public temporarily, request a refresh, and then turn it off again.

[howardchung]

Updated to hide last 20 matches, MMR (although this is many years out of date anyway) and rankings as well.

The showing an improved message is tracked in odota/web#3133

[hanselviva]

Agree on this one. Came here to ask the same thing.

[howardchung]

I'm on board with this change if someone wants to create a PR, but don't currently have the bandwidth to work on it directly.

I think we have the necessary data to do it already--we can just not load the matches list for players in all the player data endpoints if fh_unavailable (we set this when we try to fetch match history for a player) in the SQL database is true and the cookie doesn't match the user ID.

In the UI if we want to create a message showing that the player is private, that's a bonus

This would also allow us to start storing match data for all users (including anonymous ones) from the GC since it'll be hidden from the profiles of players who toggle the option off

[Aluerie]

Erm, sorry, but does it fully work actually? Am I missing something?

Opening my profile both logged in and incognito (https://www.opendota.com/players/112636165) leads to the attached picture below:

While it clearly has a lot of zeros and doesn't show data like "Counts", "Players Played With". etc. - It still shows my match history from before I last enabled Expose Setting and "Averages/Maximums" in those games. And yes, I played quite a bit of dota after "25 days ago" mark. Also MMR and Rankings tabs have some info :D

Also there is no clear message that my profile is supposed to be private, like we discussed stratz/dotabuff examples. Plus, I thought you wanted to make it so we can see our own data if we login despite the setting state.

Do I need to toggle the setting 🤔

[howardchung]

Also put in a fix for the showing matches to logged in users, but haven't tested it directly since my own account is not private

[Aluerie]

Doesn't look like it.

[howardchung]

Tried another fix (web client wasn't passing login info)

[Aluerie]

thanks a lot, looks good except "Recent Matches", "Averages/Maximums" now don't load if I'm private+signed in. Other tabs look fully functional.

Another thing I'm not sure about it - Matches still shows data only before 25 days ago. However, you mentioned storing data for all users/all matches so I thought it means if my profile is private and I login - I should be able to see my recent games (as in yesterday) despite the setting. That the setting should only control who can see the information.