Add a couple decimal points to KDA Query for players in matches.

[yungbuck81]

Add a couple decimal points to KDA Query for players in matches.

[howardchung]

Do you have a sample API call where this is happening?

[yungbuck81]

Match ID 7329517346. The KDA value on tide is rounded down from 2.55555556 to 2. In our league of 12-20 teams playing two games per week we've seen some kda discrepancies for a while now when we avg the two games.

[yungbuck81]

Similarly in Match ID 7329550501, player 9 has their KDA rounded down from what would be 3.5 to 3. https://api.opendota.com/api/matches/7329550501

[builder-247]

Yeah looks like it's indeed rounded down, wonder what the plan was here

core/util/compute.js

Line 74 in 7f122c9

pm.kda = Math.floor((pm.kills + pm.assists) / (pm.deaths + 1));

Anyways you could also just calculate the kda from the kills, assists and deaths yourselves

[howardchung]

Looks like I wrote that code like 8 years ago haha so it's probably my fault. We probably could just replace it with Math.round and add a few decimals

[yungbuck81]

That would be awesome if you would be willing to do that!

[yungbuck81]

Thanks so much for doing this!