The odra from odradev

Add `odra-modules`.

Add odra-modules crate to the repo and reexport it in odra.
odra-modules should contain:

ERC20 token.
Wrapped CSPR based on ERC20 token.

Unnecessary `deploy()` method.

When the #[deploy(init)] method is specified don't generate Module::deploy() method. It's like this here: https://github.com/odradev/odra-template/blob/3259626c1a123a295ea56f5d6070b59bc3662917/src/flipper.rs#L47

Fix odradev/odra-template afterwards.

Module with multiple #[odra::module] impl block does not compile

By now the only correct implementation of a module is having a struct and a single implementation block. If for some reason, a developer would like to have a module with more than one implementation block marked as odra::module, compilation will fail.
We need to come up with a solution that gently informs a user that he should put all the entry points in a single impl block or allow having multiple blocks.

Module's private function should not be consider as an entrypoint

Inside an implementation block, only public functions should be converted to entry points.

Currently, a module with a private function does not compile to a wasm.

Test U256 overflow.

If conversion U512 -> U256 is required, the value may exceed the max value of U256. This scenario should be gently handled (e.g, the state should be reverted) and tested.

Inherit `Cargo.toml`'s from the root `Cargo.toml`

https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#inheriting-a-dependency-from-a-workspace

U256::Max as U512

Consider this implementation of getter max of U256 as U512:

U512::from(<casper_types::U256 as AsPrimitive<casper_types::U512>>::as_(U256::MAX))

in

odra/odra-casper/types/src/uints.rs

Line 175 in 74bbf2c

fn exceeds_u256(value: casper_types::U512) -> bool {

Build `getter_proxy.wasm` in build.rs

Build getter_proxy.wasm in build.rs. Now it is included in the repo.

Implement `no_std` mode.

By default compile contracts as no_std. Allow contracts to use std if needed.

Detect bad argument name in `odra::external_contract`.

When the external_contract is wrongly defined, MockVM should throw an error like missing argument: "b":

use odra::types::Address;

#[odra::module]
pub struct Contract {}

#[odra::module]
impl Contract {
    pub fn add(&self, a: u32, b: u32) -> u32 {
        a + b
    }
}

#[odra::external_contract]
trait WrongInterface {
    fn add(&self, a: u32, wrong_name: u32) -> u32;
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_add() {
        let contract = Contract::deploy();
        let reference = WrongInterfaceRef::at(contract.address());
        let _ = reference.add(1, 2);
    }
}

Featues check.

Check if only one feature is enabled. Fail the compilation if two or more featues are on.

execution_error macro causes clippy warning

Sample logs:

execution_error! {
    | ^^^^^^^^^^^^^^^^
    = note: `-D clippy::from-over-into` implied by `-D warnings`
    = help: consider to implement `From<erc20::Error>` instead
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into
    = note: this error originates in the attribute macro `odra::odra_error` (in Nightly builds, run with -Z macro-backtrace for more

Make `ContractDeployer` public

It's required so I can use the contract defined in one file in tests in another file.

Reuse `cargo-purse` in Casper

Currently every time CSPR is passed to the contract new purse is created. It should be just one both for users and contracts.

Modules in Mapping.

It should be possible to use a module or another mapping as a mapping's value.

Example:

use odra::modules::tokens::ERC20;

#[odra::module]
struct Contract {
    tokens: Mapping<String, ERC20>,
    nested: Mapping<String, Mapping<u32, u64>>
}

Add cargo-odra e2e tests for Github Actions

Implement Assign traits for U256 and U512 in Casper

Implement AddAssign, SubAssign, MulAssign, DivAssign in casper-types uints.
Then remove -A clippy::assign-op-pattern from justfile.

Allow for blocktime manipulation in TestEnv.

Developer should be able to advance a block time in tests.

Run getters as special account

Running getter functions should not deduct gas, so in Casper all getters should be run as a special system account.

Tests for Mapping and Variable.

Add tests for Mapping and Variable that runs against MockVM.

Add `List` collection.

Allow for:

use odra::List;

#[odra::module]
pub struct Contract {
    list: List<u8>
}

#[odra::module]
impl Contract {
    pub fn add(&self, value: u8) {
        self.list.append(value);
    }

    pub fn get(&self, index: u32) -> Option<u32> {
        self.list.get(index)
    }
}

It should be implemented using Mapping and indexed from 0.

Odra 0.1.0 Milestone

Repos:

[KUBA] Cargo Odra

[MACIEJ] Odra Casper

[KUBA] Odra Template

[KUBA] Owned Token

Prepare reposiotry for publishing
Rename to odra-examples
README
CHANGELOG.md
add MIT LICENCE
setup repo:
- master restructed
- develop restricted
- feature
Enable Casper tests when cargo odra test -p casper compiles getter_proxy.
Use Error macro when available.

[KRZYSIEK] Odra

Code publishing process.

Odra

publish odra 0.0.1
make remaining changes (README and changlog) and change to 0.1.0.
make new tag, observe release.

Odra Casper

change to use odra 0.0.1
publish odra-casper 0.0.1
make remaining changes (changlog, docs) and change to 0.1.0.
make new tag, observe release.

Odra Template

change to use odra 0.0.1
point at odra 0.1.0

Cargo Odra

change to use odra 0.0.1
publish 0.0.1
make remaining changes (changlog) and change to 0.1.0.
make new tag, observe release.

Odra Examples

point at odra 0.0.1
enable casper tests
point at odra 0.1.0

Publishing

Cargo.toml example

authors = ["Jakub Płaskonka [email protected]", "Krzysztof Pobiarżyn [email protected]", "Maciej Zieliński [email protected]"]
license = "MIT"
repository = "https://github.com/odradev/odra" // set to proper
description = "High-level smart contract framework for Rust" // different for each. This one is for core.
keywords = ["wasm", "webassembly", "blockchain"]
categories = ["wasm", "smart contracts"]

Catch calling constructors in MockVM

When calling a constructor, MockVM should return VmError(InvalidContext) instead of VmError(NoSuchMethod(constructor_name)).

Example test:

#[test]
fn second_initialization_fails() {
    let (owner, ownable) = setup();
    TestEnv::assert_exception(OdraError::VmError(VmError::InvalidContext), || {
        ownable.init(owner);
    });
}

Native token interface.

Handle native token:

standard transfers,
passing tokens with contract calls when calling contract from the outside,
passing tokens with contract to contract call.
proper gas metering in tests that allows testing token transfers. The best would be zero-cost gas table.
#[odra(payable)] to mark entrypoint that accept tokens. (also in #[odra::external_contract]?).
TestEnv check of token.
Handle potential different types of integers for native tokens in backends (Casper has u512, Ethereum u256).

In test script.

let one = TestEnv::one_token();
TestEnv::with_tokens(1000 * one);
TestEnv::set_caller(user1);
contract.deposit();

assert_eq!(
    TestEnv::token_balance(user1),
    TestEnv::token_balance(contract.address())
)

In contract.

#[odra(init)]
#[odra(payable)]
pub fn start() {
    let caller = ContracEnv::caller();
    let contract_balance = ContracEnv::self_balance();
    let transfered_amount = ContracEnv::attached_value();
    let threshold = ContractEnv::one_token() * 100;
    if contract_balance > threshold {
        ContractEnv::transfer_tokens(caller, transfered_amount);
    } else {
        ContracEnv::with_tokens(contract_balance);
        AnotherContract::at(caller).do_something();
    }
}

Missmatch types in `call_contract` return.

Missmatch of types in call_contract method in Odra and Odra Casper. #[no_mangle] call_contract in Odra Casper returns Bytes instead of Option<Bytes>.

Reexport expicitly in `odra-core`.

In odra/src/lib.rs remove all * in exports.

odradev / odra Goto Github PK

odra's People

Contributors

Stargazers

Watchers

odra's Issues