ofai/puncat

Interactive prototype tool for the computer-assisted translation of puns

puncat's Issues

Duplicate "algorithm changed" messages in log

When PunCAT is first started, and again whenever a new corpus XML file is opened, the log gets spammed with a large number of "Semantic algorithm changed" and "Phonetic algorithm changed" messages:

2020-12-11 11:33:38.269 {event=PunCAT started}
2020-12-11 11:33:40.965 {event=Semantic algorithm changed, Selected algorithm=JiangAndConrath}
2020-12-11 11:33:40.966 {event=Phonetic algorithm changed, Selected algorithm=ALINE}
2020-12-11 11:34:55.576 {event=Corpus xml file opened, file=C:\Users\pcexp\Desktop\puns_old\puncat.xml}
2020-12-11 11:34:55.622 {event=Semantic algorithm changed, Selected algorithm=JiangAndConrath}
2020-12-11 11:34:55.623 {event=Phonetic algorithm changed, Selected algorithm=ALINE}
2020-12-11 11:34:57.882 {event=Semantic algorithm changed, Selected algorithm=JiangAndConrath}
2020-12-11 11:34:57.882 {event=Phonetic algorithm changed, Selected algorithm=ALINE}
2020-12-11 11:34:58.795 {event=Semantic algorithm changed, Selected algorithm=JiangAndConrath}
2020-12-11 11:34:58.796 {event=Phonetic algorithm changed, Selected algorithm=ALINE}
2020-12-11 11:34:59.416 {event=Semantic algorithm changed, Selected algorithm=JiangAndConrath}
2020-12-11 11:34:59.416 {event=Phonetic algorithm changed, Selected algorithm=ALINE}
2020-12-11 11:35:00.955 {event=Semantic algorithm changed, Selected algorithm=JiangAndConrath}
2020-12-11 11:35:00.955 {event=Phonetic algorithm changed, Selected algorithm=ALINE}

Log: Inconsistent field names for source/target keyword change

The "Source keyword changed" event stores the new keyword in a field called "newValue", but the "Target keyword changed" event stores the new keyword in a field called "newKeyword". The field names should be unified.

JSON log omits trailing ]

The JSON logs output by PunCAT are all missing the final ] delimiting the array.

WordNet-specific log messages are missing POS

Log messages that include a WordNet synset include only the synset offset, but not the part of speech. Both of these pieces of information are required to uniquely identify a synset.

Log current task ID when opening a corpus file

When a corpus XML file is opened, PunCAT should log the ID of the current task.