ogame-infinity/web-extension

Repository for the web extension code (coming)

web-extension's Issues

Incorrect fuel consumption sum

Users report the fuel consumption in the expedition statistics is too low.

Track items collected from Expeditions

https://discord.com/channels/735582742435201114/735584342830612540/784009678191329280

In stats the total of debris are not counted

As of new version 2.2.7 debris reports seems not to be parsed.

Empire view no longer is a Commander only feature

Next ogame version is coming. Announced today:

Version 9.0.5

🔸 Changelog

The Empire View no longer is a Commander only feature and is available for all players instead.

As Commander is no needed anymore to the related OGI features can work, I think code should be cleaned for references to this:

Wrong resource totals after recalling overnight deployment

I save my rips on 10% deployment with resources and pull the next morning.

Doesn't seem to happen when recalling a deployment on the same day.

Sometimes, "ogi-players" event is triggered before dataHelper was loading in main.js

I got an error when i try to send expeditions, this is not systematic but almost.

The corresponding code location is the "DataHelper::getPlayer()" function where "this.players" is undefined.
I debugged that when this happen, "this.loading" is true.

The solution to this is to wait that this.loading is loaded is false before treating "ogi-players" event.
It might convenient to make this part of the code cant crash by checking players array is not empty and id exists. What makes it even more pertinent is that some value checking is done after this part.

Reference #112

On the one quick hand,
We can fix errors introduced since this repository creation by reverting 6d59219 and adding the 10ms setTimeout() delay parameter.

But on the other clean hand,
"ogi-players" event processing must wait for "this.hasLoaded" DataHelper property.

New setting for type of/number of ships to send for expeditions as standard

When sending expedition from the fleet screen, we can click the button to profile probe, reaper, cargos, etc. But (for me) it always only adds 417 Large Cargo, and usually I would want to send 2000 or 4000. Let's add some settings to specify exactly what and how many ships that button actually selects.

Add column for fly-time and Profit/minute in Spy Table to sort by profit pr. hour fx.

https://discord.com/channels/735582742435201114/735584342830612540/793560096852279316

[PTRE] Test PTRE Team Key before saving it

OG Infinity does not check PTRE Team Key format. This is bad and can lead to issues.

OG Infinity needs to test it before saving it.

Correct format is: TM-XXXX-XXXX-XXXX-XXXX

To validate a PTRE Team Key before saving it to storage:

1. Substr the string with only the 22 first characters: TK = substr(TK, 0, 22)
2. Test it: remove all dashes - and test if result starts with TM and has a 18 length
   If yes, store original TK (22 length with dashes). If not, drop it.

You may do this check on each and every Infinity start, to remove false Team Key previously added to storage (i can say, they are some).

thx

Alliance members table

Hey,
it would be nice to see alliance members in tooltip in Galaxy view as we have for player already :) It may contain at least (top) players list.
wdyt?

Auto harvest all planets to bank

Lots of people been complaining missing this feature from OGLight.

Ressources needed for building mines is NaN

As in title. Problem seems to be limited to only mines. See image

Update Expedition Messages: Turkish

Rounding errors in building locks

Users end up -1 resource short. Can be Very frustrating.

Easy solution = Just add a safety buffer of 10 resources?

Update Expedition Translations: Polish

https://discord.com/channels/735582742435201114/735583479252910130/779311059000361001

8.0.0-pl6 mess spy report parsing

Update Expedition Messages: Polish

https://discord.com/channels/735582742435201114/735583479252910130/795971322475053076

Improvement - Sensor Phalanx Range

I as a user
Want to see the phalanx range
when I'm in the Phalanx building details

Enter key when sending attaks from the spy table doesn't bring back to the spy table

No settings for disabling auto fetch empire data

Even the previous settings are honored, there is no settings now for disabling auto fetch empire data. Thus there is no way to disabling it in new OGI installations aside importing previous data.

Settings for this were disabled here:

There is no need to remove auto fetch empire data settings. The only change that were necessary was changing text in settings 'Disable auto fetch Empire (Commander only)' for 'Disable auto fetch Empire' then when Empire got free to everybody.

Space Dock cost-calculations wrong

https://discord.com/channels/735582742435201114/735582967564468237/790497894221873184

Alliance Stats

Since we have our own stats, I thought it might be useful to have alliance stats.

Moon Facility: Resource Lock not functional & level toggle unavailable

Clicking the lock does not result in the familiar red lock next to the planet.
Can also not toggle building levels.

Bug is not due to moon being fully built. This is what it should look like:

Tooltip recycling in galaxy view is broken

Multiple people complain about sending recyclers (or pathfinders) in galaxy view is broken.

First report:

https://discord.com/channels/735582742435201114/735582967564468237/1050307263543390299

Code onclick="sendShips(... for sending the ships in tooltip is missing:

Problem seems to be related to this change:

https://github.com/ogame-infinity/web-extension/commit/e0a88503e5b45c13844bc71bb3630127c646c1e4#diff-f2b432ede3c31e63fa6cf860d68e4c4661a705712d3ce4e89a5137d5705ba90a

Adding players to block list links to lobby (fr)

Clicking the button highlighted in orange (block player) leads to https://lobby.ogame.gameforge.com/fr_FR/hub .
It does not destroy the session (can go back and keep playing).

Perhaps an incomplete feature that was postponed and forgotten.

Combat reports tab with >10 reports/page are not fully registered

Seems that from a few months ago visiting combat reports with >10 reports/page makes that only get registered a few first 11-13 combat reports and then stops:

For the rest of the reports, fetch attempt gives error:

Reports of this issue in discord:

https://discord.com/channels/735582742435201114/735582967564468237/1034033731977084938
https://discord.com/channels/735582742435201114/735582967564468237/1038924328756056074
https://discord.com/channels/735582742435201114/735582967564468237/1047989839343140937

Setting reports/page to 10 works as a workaround.

Setting to specify what fleet to leave behind when Moon-jumping

https://discord.com/channels/735582742435201114/735584342830612540/783292996098457629

The code crashes on black hole messages

It seems like the script crashes on black hole message as shown in the screenshot below.
This also prevents the script from registering expedition message on the next pages.

Mark reports in Spy table with Star if messages are favorited

I have a pain in the Spy table. I like to Favorite reports that are targets, but sometimes I accidentally delete them via the Spy table, because they are not visibly marked favorites there.

I have two suggestions: 1. add a star in the spy table, or some other form of marking it, and 2: dible the trash-icon for those particular reports.

Target bug

Target deleted the account and continues to appear in the list of targets

Allow users to add players (and all their planets) as targets

https://discord.com/channels/735582742435201114/735584342830612540/771790706053349426

Currently it is only possible to add certain planets as targets. It would be awesome to add entire players, so all their planets are automatically added to the list. Even more awesome would it be, if once you add a player, and they create/move a colony, that those changes would also be reflected.

Fleet Movement Layout

Stretches too far down the page, occluding the recall time of the last fleet.

Espionage report resource parsing NaN

Most likely because of "Mn" string in the report, anything under 1Mn works fine

Black hole registration fails on numbers with DOT

It seems like, when adding black holes it takes the dot for precision.
So it registers 16 LF instead of 16500 (screenshot)

This might also be related to the found resources not being registered. (The wrong language setting 1 instead of 0)

Harvest reports are not parsed correctly. Point&comma attacks again.

Harvest reports are not parsed correctly.

https://discord.com/channels/735582742435201114/735582967564468237/1053984222387376188

Localized thousands separators are not being considered in harvest reports parsing. Hardcoded "." is used instead.

Wrong resources production calculation and average mine levels

The sum of the empire production in the "General" graphics view appear to be wrong, for all resources.
There are differences between real production and what is calculated and displayed by Infinity.

Almost all bonuses are in the screenshots below.

There is also a difference between the average mine levels displayed and the ones calculated.

Add setting to define what rentability-ratio should be used

https://discord.com/channels/735582742435201114/735584342830612540/785216536239276053

Update Expedition Translations: Portuguese (Portugal)

Portuguese - nothing found

De: Comando da frota
A tua frota entrou no campo gravitacional de uma estrela de neutrões. Para conseguir escapar à enorme força da gravidade teve de gastar grande parte do Deutério e cancelar a expedição.

De: Comando da frota
Um virus de computador atacou o sistema de navegação mesmo antes da frota sair do nosso sistema solar. O virus fez com que a frota andasse a voar em círculo. Não deverá ser necessário dizer que a missão falhou.

https://cdn.discordapp.com/attachments/735583479252910130/796690766474641418/unknown.png

De: Comando da frota
Bem, agora sabemos que aquelas anomalias vermelhas de classe 5 para além de ter efeitos caóticos nos sistemas de navegação também são altamente alucinogénos.

https://cdn.discordapp.com/attachments/735583479252910130/796690945092747284/unknown.png

"+" button to show ressources fields not displayed when ressources are locked

universeview links (trashsim/ogotcha) for .us servers

Cannot just pull from server url. Needs language lookup.
Example: ogame.us language -> "en", not "us"

needs to be
https://trashsim.universeview.be/en?SR_KEY=sr-us-163

instead of
https://trashsim.universeview.be/us?SR_KEY=sr-us-163

Feature request: Balanced exploration send

Is it possible to get a new exploration button on fleet window that when clicked would see how many free explorations do you currently have and then use that to divide all your cargo ships such as i can do 8 explorations and if i have 260 large cargo ships that would mean 32.5 so 32 large cargo ships, if i now send out a exploration with 32 large cargo ships then i will have 228 large cargo ships but only 7 explorations slots which again would divide to be 32 large cargo ships and it would use this to send out a balanced fleet setup everytime you click it and then ofc the general of 1 probe, 1 pathfinder if you got pathfinders, 1 of your best combat ships. it would balance out your cargo ships up to the max amount needed for optimal cargo space needed

this would be a huge QOL and makes it a lot easier to send out mass explorations

NaN in total flying resources for .en servers when resources >999

Also fleets with more than 999 units does not get take into account in flying stats.

Seems to be another point&comma madness left in the code.

Research time when -25% bonus event is active get bugged and displays NaN

Because the research() time and cost calculation function do not take into account the -25% bonus event, the getLabs() calculation funtion that use it returns undefined when this event is active. This causes a NaN next time research() is used as labs parameter is undefined, now to calculate times to update research time info.

Auto fetch of empire slowing down page reload

This is not new, but it has to be better :)

Resources Images in Stats are displaced

Small issue

The resource icons (Crystal and Deuterium) appear displaced too far to the left.

Point & comma known nightmare seems to be not fixed in .ro servers

One player of a .ro server reports that the point&comma known problem is not fixed:

https://discord.com/channels/735582742435201114/735582967564468237/1048553053332181043

The game is using point for decimal separator and comma for thousand separator:

This specification from GF in LocalizationStrings seems to be wrong, as formal Romanian separators format seems to be comma for decimal separator and point for thousand separator:

https://en.wikipedia.org/wiki/Romanian_numbers

Seems that this conflicts with separator format assign code in OGI:

'ro-RO' locale get separatorLang = 'de-DE' as it should be if GF used right specification in LocalizationStrings.

Maybe this block of code should have a temporary quirk assigning separatorLang = 'en-US' until GF fixes their faulty LocalizationStrings for .ro servers.

Resource-icons in Overview are "shifted" (on Microsoft Edge)

https://discord.com/channels/735582742435201114/735582967564468237/786298848577847306

0 in total flying resources in special case

It seems that some special cases, some users are getting 0 in total flying resources and total ships not taken into account for some specific fleets but working ok for anothers.

https://discord.com/channels/735582742435201114/735582967564468237/1070468997486747769

In this case, the user only have the problem in 2 .fr universes of 5 .fr universes.

Some fleets seems to work ok, as small expedition fleets. This is where OGI gets the info to extract flying ships and resources:

But for large fleet in a deploy mission, there are a small difference in the event:

If we search for first tooltip class as the first example, we get a useless text that give us a 0 ships and 0 resources. This is because for unknown reason it seems that server is adding tooltip class to a span inside 'td class=​"originFleet"'. Thus this span is find instead the right one with the fleet info.

Cannot write more than 3 carachters in the fleet tab for resources and ships.

Only on version 2.0.17 and 2.0.18

In the fleet tab when I write a number over 3 digits everything is erased to leave only the first digit.

Overlapping letters

If we click too fast in research, the letters overlap.