ohansemmanuel/fake-medium

💥 A tiny (super tiny) medium article page + clap animation for demo purposes.

✨ Read the book ✨

fake-medium's Issues

License File

Hi Ohansemmanuel

Nice work - this was very helpful to me.

It looks like you don't have a license file in this repo. Would you mind adding one? Without this, the code can not legally be used in other applications.

Thanks

onFailure displaying automatically in console

Hi, I just noted that in the function actions/index.js you have specified a onFailure function equal to console.log("Error occured loading articles") , I suppose what you meant there is an arrow function like this ? : () => { console.log("Error occured loading articles"); } So that IF there is an error that lambda function is called.
Really nice tutorial, it helped me a lot!
Best, Phil

Actions must be plain objects. Use custom middleware for async actions.

export function newProfile(data) {
    return new Promise((resolve) => (dispatch) => {
        apiAction({
            url: '/profile',
            data,
            onSuccess: ((response) => {
                dispatch({
                    type: NEWPROFILE,
                    payload: response.id
                });
                resolve(response.id);
            }),
            label: LOADING,
        });
  });
}

props.newProfile(data).then((id) => {
    // get id
});

¿How to solved?

question regarding axios requests

HI,
that data fetching with redux middleware is really good but I'm thinking what we should do when we don't want to pass request data into store every-time? For example I have small component which should store some data from api request in the state, I don't want to push everything into store. Do you have any idea how to manage this?

How to wait for promise object ?

Hi,

Your way of implementing a generic api middleware is great.

I am using 'UseDispatch' from react-redux library, here i will dispatch to an action and do an api call and update the redux store using reducer.

But my requirement is "need to wait till the redux store has data and then proceed further". Any idea how to get this ?

Can i make a specific api call from action method as async await when i call that action method from functional component or inside useEffect() i need to wait till i have data in redux store.

Regards,
Sandesh

Add another reducer

Hello,

Allow me to first give you a round of applause and a huge thanks, your middleware is quite perfect, very beautiful coding. Yet I failed to see on how I could use it while working with several reducers because as you work with the article_details reducer when adding another reducer and duplicating the code to hold another set of actions, my two reducers collide and having this error :

Given action "API_START", reducer "reducerOne" returned undefined. To ignore an action, you must explicitly return the previous state. If you want this reducer to hold no value, you can return null instead of undefined.

=> both reducers hold the same case API_START when the middleware dispatch it on onSuccess(data)

My guess is that I would have to split the actions for the middleware to remain untouched and then try to keep the structure of the reducers as it is. What is your opinion ?

While thanking you again,

the response for delete request would be empty ,how to delete an item from store ,how should be the onsuccess callback

Im not able to perform delete action in store because no id