okbob/pgimportdoc

command line utility for importing XML, JSON, BYTEA document to PostgreSQL

pgimportdoc's Issues

Build error against PostgreSQL 11

Hi,

pgimportdoc cannot be built against PostgreSQL 11 -- can you please take a look?

Thanks!

Build error against PostgreSQL 9.5

Hi Pavel,

This is also failing against PostgreSQL 9.5:

+ /usr/bin/make -j3
pgimportdoc.c: In function 'pgimportdoc':
pgimportdoc.c:84:3: warning: passing argument 2 of 'simple_prompt' makes integer from pointer without a cast [enabled by default]
   simple_prompt("Password: ", password, sizeof(password), false);
   ^
In file included from /usr/pgsql-9.5/include/server/c.h:1114:0,
                 from /usr/pgsql-9.5/include/server/postgres_fe.h:25,
                 from pgimportdoc.c:13:
/usr/pgsql-9.5/include/server/port.h:205:14: note: expected 'int' but argument is of type 'char *'
 extern char *simple_prompt(const char *prompt, int maxlen, bool echo);
              ^
pgimportdoc.c:84:3: error: too many arguments to function 'simple_prompt'
   simple_prompt("Password: ", password, sizeof(password), false);
   ^
In file included from /usr/pgsql-9.5/include/server/c.h:1114:0,
                 from /usr/pgsql-9.5/include/server/postgres_fe.h:25,
                 from pgimportdoc.c:13:
/usr/pgsql-9.5/include/server/port.h:205:14: note: declared here
 extern char *simple_prompt(const char *prompt, int maxlen, bool echo);
              ^
pgimportdoc.c:130:4: warning: passing argument 2 of 'simple_prompt' makes integer from pointer without a cast [enabled by default]
    simple_prompt("Password: ", password, sizeof(password), false);
    ^
In file included from /usr/pgsql-9.5/include/server/c.h:1114:0,
                 from /usr/pgsql-9.5/include/server/postgres_fe.h:25,
                 from pgimportdoc.c:13:
/usr/pgsql-9.5/include/server/port.h:205:14: note: expected 'int' but argument is of type 'char *'
 extern char *simple_prompt(const char *prompt, int maxlen, bool echo);
              ^
pgimportdoc.c:130:4: error: too many arguments to function 'simple_prompt'
    simple_prompt("Password: ", password, sizeof(password), false);
    ^
In file included from /usr/pgsql-9.5/include/server/c.h:1114:0,
                 from /usr/pgsql-9.5/include/server/postgres_fe.h:25,
                 from pgimportdoc.c:13:
/usr/pgsql-9.5/include/server/port.h:205:14: note: declared here
 extern char *simple_prompt(const char *prompt, int maxlen, bool echo);
              ^
In file included from pgimportdoc.c:24:0:
/usr/pgsql-9.5/include/internal/pqexpbuffer.h:60:9: warning: the comparison will always evaluate as 'false' for the address of 'data' will never be NULL [-Waddress]
  ((str) == NULL || (str)->maxlen == 0)
         ^
pgimportdoc.c:243:11: note: in expansion of macro 'PQExpBufferBroken'
  else if (PQExpBufferBroken(&data))
           ^
make[1]: *** [pgimportdoc.o] Error 1
error: Bad exit status from /var/tmp/rpm-tmp.ttuzGu (%build)
    Bad exit status from /var/tmp/rpm-tmp.ttuzGu (%build)
make: *** [build] Error 1

real    0m4.168s

Can you please take a look?

Thanks

GCC 13 build failure

Hi,

pgimportdoc fails to build against GCC 13 (Fedora 38). Can you please take a look? Thanks!

gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wimplicit-fallthrough=3 -Wcast-function-type -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -I/usr/pgsql-14/include -I. -I./ -I/usr/pgsql-14/include/server -I/usr/pgsql-14/include/internal  -D_GNU_SOURCE -I/usr/include/libxml2  -I/usr/include  -c -o pgimportdoc.o pgimportdoc.c
/usr/lib64/ccache/clang -Wno-ignored-attributes -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Xclang -no-opaque-pointers -Wno-unused-command-line-argument -Wno-compound-token-split-by-macro -Wno-deprecated-non-prototype -O2  -I/usr/pgsql-14/include -I. -I./ -I/usr/pgsql-14/include/server -I/usr/pgsql-14/include/internal  -D_GNU_SOURCE -I/usr/include/libxml2  -I/usr/include -flto=thin -emit-llvm -c -o pgimportdoc.bc pgimportdoc.c
pgimportdoc.c:106:3: error: call to undeclared function 'simple_prompt'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
                simple_prompt("Password: ", password, sizeof(password), false);
                ^
pgimportdoc.c:162:4: error: call to undeclared function 'simple_prompt'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
                        simple_prompt("Password: ", password, sizeof(password), false);
                        ^
2 errors generated.
make[1]: *** [/usr/pgsql-14/lib/pgxs/src/makefiles/../../src/Makefile.global:1071: pgimportdoc.bc] Error 1
make[1]: *** Waiting for unfinished jobs....
pgimportdoc.c: In function 'pgimportdoc':
pgimportdoc.c:106:17: warning: implicit declaration of function 'simple_prompt' [-Wimplicit-function-declaration]
  106 |                 simple_prompt("Password: ", password, sizeof(password), false);
      |                 ^~~~~~~~~~~~~

Build warning against PostgreSQL 10

Hi Pavel,

This is the warning against PostgreSQL 10, on RHEL 7 and Fedora 25:

+ /usr/bin/make -j3
In file included from pgimportdoc.c:24:0:
pgimportdoc.c: In function 'pgimportdoc':
/usr/pgsql-10/include/internal/pqexpbuffer.h:60:9: warning: the comparison will always evaluate as 'false' for the address of 'data' will never be NULL [-Waddress]
  ((str) == NULL || (str)->maxlen == 0)
         ^
pgimportdoc.c:243:11: note: in expansion of macro 'PQExpBufferBroken'
  else if (PQExpBufferBroken(&data))
           ^~~~~~~~~~~~~~~~~
+ exit 0

Regards, Devrim

Build error against PostgreSQL 9.6

Hi Pavel,

pgimportdoc fails to build against PostgreSQL 9.6, on all RPM platforms that we support:

+ /usr/bin/make -j3
pgimportdoc.c: In function 'pgimportdoc':
pgimportdoc.c:84:3: warning: passing argument 2 of 'simple_prompt' makes integer from pointer without a cast [enabled by default]
   simple_prompt("Password: ", password, sizeof(password), false);
   ^
In file included from /usr/pgsql-9.6/include/server/c.h:1105:0,
                 from /usr/pgsql-9.6/include/server/postgres_fe.h:25,
                 from pgimportdoc.c:13:
/usr/pgsql-9.6/include/server/port.h:206:14: note: expected 'int' but argument is of type 'char *'
 extern char *simple_prompt(const char *prompt, int maxlen, bool echo);
              ^
pgimportdoc.c:84:3: error: too many arguments to function 'simple_prompt'
   simple_prompt("Password: ", password, sizeof(password), false);
   ^
In file included from /usr/pgsql-9.6/include/server/c.h:1105:0,
                 from /usr/pgsql-9.6/include/server/postgres_fe.h:25,
                 from pgimportdoc.c:13:
/usr/pgsql-9.6/include/server/port.h:206:14: note: declared here
 extern char *simple_prompt(const char *prompt, int maxlen, bool echo);
              ^
pgimportdoc.c:130:4: warning: passing argument 2 of 'simple_prompt' makes integer from pointer without a cast [enabled by default]
    simple_prompt("Password: ", password, sizeof(password), false);
    ^
In file included from /usr/pgsql-9.6/include/server/c.h:1105:0,
                 from /usr/pgsql-9.6/include/server/postgres_fe.h:25,
                 from pgimportdoc.c:13:
/usr/pgsql-9.6/include/server/port.h:206:14: note: expected 'int' but argument is of type 'char *'
 extern char *simple_prompt(const char *prompt, int maxlen, bool echo);
              ^
pgimportdoc.c:130:4: error: too many arguments to function 'simple_prompt'
    simple_prompt("Password: ", password, sizeof(password), false);
    ^
In file included from /usr/pgsql-9.6/include/server/c.h:1105:0,
                 from /usr/pgsql-9.6/include/server/postgres_fe.h:25,
                 from pgimportdoc.c:13:
/usr/pgsql-9.6/include/server/port.h:206:14: note: declared here
 extern char *simple_prompt(const char *prompt, int maxlen, bool echo);
              ^
In file included from pgimportdoc.c:24:0:
/usr/pgsql-9.6/include/internal/pqexpbuffer.h:60:9: warning: the comparison will always evaluate as 'false' for the address of 'data' will never be NULL [-Waddress]
  ((str) == NULL || (str)->maxlen == 0)
         ^
pgimportdoc.c:243:11: note: in expansion of macro 'PQExpBufferBroken'
  else if (PQExpBufferBroken(&data))
           ^
make[1]: *** [pgimportdoc.o] Error 1
error: Bad exit status from /var/tmp/rpm-tmp.6t0e9g (%build)
    Bad exit status from /var/tmp/rpm-tmp.6t0e9g (%build)

Can you please take a look?

Thanks!
Devrim