omaralvarez/conan_dlib

Conan recipe for dlib library http://dlib.net

conan_dlib's Issues

Does not work with visual studio

There is an issue when this recipe is being used with visual studio.
It is because under visual studio dlib decorates .lib file like so:
dlib19.16.0_release_32bit_msvc1916.lib
Therefore conan is unable to find dlib.lib file and does not setup CONAN_PKG::dlib target properly.

See dlib's CMakeLists causing it:
https://github.com/davisking/dlib/blob/a53354eb79e34b89d5566228bd0872664d14f161/dlib/CMakeLists.txt#L943

Review

Hi Omar!

I think DLib is a very cool library, thanks for creating a package for it.
I would like to see it in conan-center, so here there is some initial advice:

• "os_build", "arch_build" Are not really necessary. Please check the changelog and the Upgrading to 1.0 guide, there were some mistakes in the docs that were suggesting using them for all libraries, while it is not necessary.

• You can set a homepage attribute in the recipe, that means the original library url

• Instead of print you can use self.output.info("your text") for nice colored and scoped output.

Of course we need to do the inclusion-requests of the dependencies first (gif, jpeg, sqlite..) even if they are conditional, and that might take some time.
Also, a necessary step for conan-center is to enable some CI to automatically create packages for multiple OSs and configurations, and that might require a bit of work, specially if it is the first time. If you intend to do so, please ask for help (also to the bincrafters and conan communities in CppLang slack channels).

Great job, thanks a lot!

GUI is not supported

Hi,

thanks for the effort to make dlib into a conan package. It was really helpful! Can you confirm that the GUI part is not compiled in your conan package? If it is the case, is it in the plan to include it in the future release? :)

upgrade to 19.19

Please upgrade package to the latest version.