omarsalem7/catalog-of-things

Hello, I'm Omar Salem!

I’m Omar, a Software Engineer, with a love for React and Redux creative coder and self-proclaimed designer who specializes in front-end development. I make it my mission to translate user-focused designs into pixel-perfect websites or applications that run blazing fast. Open to new opportunities.

Want to know more about me? Check out my portfolio.
Reach me by email: [email protected]

My Rank

GitHub Stats 📈

Languages and Tools 💼⚙️

catalog-of-things's Issues

[Xpt] Title

Description to be added

[Xpt] Title

Description to be added

[2pt] Create MusicAlbum class in a separate .rb file.

• All MusicAlbum class properties visible in the diagram should be defined and set up in the constructor method.
• Implement methods:
  • can_be_archived?() in the MusicAlbum class
    • should override the method from the parent class
    • should return true if parent's method returns true AND if on_spotify equals true
    • otherwise, it should return false

[2pt] - Create a Label class with an association to the Item class (in a separate .rb file).

• All Label class properties visible in the diagram should be defined and set up in the constructor method.
• Implement methods:
  • add_item method in the Label class
    • should take an instance of the Item class as an input
    • should add the input item to the collection of items
    • should add self as a property of the item object (by using the correct setter from the item object)

[2pt] Create an Author class with an association to the Item class (in a separate .rb file).

• All Author class properties visible in the diagram should be defined and set up in the constructor method.
• Implement methods:
• Implement methods:
  • add_item method in the Author class
    • should take an instance of the Item class as an input
    • should add the input item to the collection of items
    • should add self as a property of the item object (by using the correct setter from the item object)

[Xpt] Title

Description to be added

[2pt] Create a Book class in a separate .rb file.

• All Book class properties visible in the diagram should be defined and set up in the constructor method.
• Implement methods:
  • can_be_archived?() in the Book class
    • should override the method from the parent class
    • should return true if parent's method returns true OR if cover_state equals to "bad"
    • otherwise, it should return false

[2pt] Create Item class

• All Item class properties visible in the diagram should be defined and set up in the constructor method. Exception: properties for the 1-to-many relationships should NOT be set in the constructor method. Instead, they should have a custom setter method created.
• Add all methods visible in the diagram.
• Implement methods:
  • can_be_archived?() in the Item class
    • should return true if published_date is older than 10 years
    • otherwise, it should return false
  • move_to_archive() in the Item class
    • should reuse can_be_archived?() method
    • should change the archived property to true if the result of the can_be_archived?() method is true
    • should do nothing if the result of the can_be_archived?() method is false

[2pt] All data should be preserved by saving collections in .json files.

All data should be preserved by saving collections in .json files.

[Xpt] Title

Description to be added

[2pt] Add unit tests for all implemented methods.

Add unit test for all implemented methods

[2pt] Create a main.rb file that will serve as your console app entry-point.

• Implement startup actions:
  • Present the user with a list of options to perform.
  • Let users choose an option.
  • If needed, ask for parameters for the option.
  • Have a way to quit the app.

[2pt] Add unit tests for all implemented methods.

• Add unit tests for all implemented methods for @omarsalem7

Peer-to-peer code review: Ruby capstone

Hello team,

You have done a great job building this console app! 🎆

Highlights 🥇

✔️ Requirements are implemented well
✔️ The console app is working as expected without crashing
✔️ No linter errors
✔️ Use of Ruby best practices
✔️ All the unit tests are passing
However, there are some issues that I would like to present to you so that when you correct them, your codes will be clean and more maintainable than they are now.

Requested improvements ♻️

While looking through this project, I have noticed a lot of repetition of the similar blocks of codes while it is the best programming practice to always keep our codes DRY which means "Not Repeating similar codes multiple times". Every piece of knowledge must have a single, unambiguous, authoritative representation within a system (Andrew Hunt & David Thomas, "The Pragmatic Programmer"). Please try to look at these code snippet screenshots I took from some of your project files.

case 1

case 2

case 3

There is the repetition of the block of codes that is responsible to read data from the storage in every module which is the same for the case of writing data in the storage.

Suggested solution

I kindly recommend that you may create a Ruby module that handles all data manipulation operations (reading and writing data) and then include that module in every class that is responsible for displaying data in the storage or saving data in the storage.
For example

Then, after this module is included in a particular class, you can perform read operations

And also the write operations like this;

Thank you, happy coding! 👏

[2pt] All data should be preserved by saving collections in .json files.

All data should be preserved by saving collections in .json files.

[4pt] User interface for entry points

• The following options should be available:
  • List all books
  • List all labels (e.g. 'Gift', 'New')
  • Add a book

[4pt] User interface for entry points

• The following options should be available:
  • List all music albums
  • List all genres (e.g 'Comedy', 'Thriller')
  • Add a music album

[2pt] All data should be preserved by saving collections in .json files.

All data should be preserved by saving collections in .json files.

[1pt] Create a schema.sql file with tables that will be analogical to the structure of the classes that you created:

Create a schema.sql file with tables that will be analogical to the structure of the classes in your app. As you cannot implement inheritance in the database tables - add all properties and associations from the parent Item class as table columns to all tables based on the child classes. Thanks to that it can be used to store data in the future.

[1pt] Create a schema.sql file with tables that will be analogical to the structure of the classes that you created:

• books table (add all properties and associations from the parent Item class as table columns)
• labels table

[2pt] Create Genre class with an association to the Item class (in a separate .rb file).

• All Genre class properties visible in the diagram should be defined and set up in the constructor method.
• Implement methods:
  • add_item method in the Genre class
    • should take an instance of the Item class as an input
    • should add the input item to the collection of items
    • should add self as a property of the item object (by using the correct setter from the item object)

[1pt] Create a schema.sql file with tables that will be analogical to the structure of the classes that you created:

Create a schema.sql file with tables that will be analogical to the structure of the classes in your app. As you cannot implement inheritance in the database tables - add all properties and associations from the parent Item class as table columns to all tables based on the child classes. Thanks to that it can be used to store data in the future

- genres table

Ruby group capstone: set up your Kanban board

This is our set-up for our kanban project: Kanban ruby group capstone
We are {number} members
Team member #1⇾ @omarsalem7
Team member #2⇾ @BertrandConxy
Team member #3⇾ @Yerimah

[4pt] User interface for entry points

Create a main.rb file that will serve as your console app entry-point.
Your console app, at the start, should:
Present the user with a list of options to perform.
Let users choose an option.
If needed, ask for parameters for the option.
Have a way to quit the app.

Ruby group capstone: set up your Kanban board

Prioject Kanban board

We are a group of three working on this project

omarsalem7 was assigned the tasks of Team member #1
Yerimah was assigned the tasks of Team member #2
BertrandConxy was assigned the tasks of Team member #3

[2pt] Add unit tests for all implemented methods.

Add unit test for all implemented methods

[2pt] Add unit tests for all implemented methods.

Add unit test for all implemented methods

[2pt] Create a Game class in a separate .rb file.

• All Game class properties visible in the diagram should be defined and set up in the constructor method.
• Implement methods:
  • can_be_archived?() in the Game class
    • should override the method from the parent class
    • should return true if parent's method returns true AND if last_played_at is older than 2 years
    • otherwise, it should return false