omgnetwork/community-points

Community points monorepo

community-points's Issues

fee-relayer: add DB layer for cross-instance communication

Extension: Error message not rendering the close button correctly

fee-relayer: support multiple spendable tokens

extension: link to leaderboard

• Link to the awesome https://omgnetwork.rocks/ in the extension
• use shortlink https://omg.eco/CPEleaderboard

extension: 1.0.2 update

• include new assets in build
• update listing icon/promo tiles/screenshots
• final testing with new changes

allow only integers in the amount fields

Currently users are allowed to send in decimals, such as 1.1. We should forbid users from typing decimals in the input box

fee-relayer: validate http api params

extension: flair tx to moderator

send points to a moderator address

fee-relayer: more validation of txs before signing

make Pong the only person to advanceToNextRound

Pong said he wants to control the point distribution!

extension: reduce bundle size of bridge

Web3 is fat

Extension: input bug

Extension: fix source maps

extension: flushing tx history

problem: when user closes extension during a pending transaction, user loses that state when opening the extension again (we flush the history on boot as an easy fix to when the user switches accounts in metamask)

solution: only flush the tx history when the address has changed (keeping any pending states). requires logic for detecting this address change and flushing only when necessary.

another potential solution: key the tx history in global state by address, so when switching accounts we maintain pending states

extension: transaction pagination bug

short poll of transactions will reset pagination state when on transaction history, losing page position.

extension: gracefully handle any errors in app/Main

potential holes for uncaught exceptions on app initialization

Add metadata to txs

2 options:

1. The fee relayer can add the same metadata field e.g. Community Point Transferto every tx
2. The front end can specify the metadata, so allowing different metadata per subreddit

extension: user dropdown

Fetch user-address map from thread and create searchable dropdown in ui

https://www.reddit.com/r/OMG_test_yolo/comments/ho07gz/romg_test_yolo_lounge

flairs: update script levelups

update flair script to accommodate flair levels (already implemented in extension)

• flair levels are shown in the metadata as follows
  • level 1 = flair_rock
  • level 2 = flair_rock:2
  • level 3 = flair_rock:3
  • and so on...

This way we can level up any flair -> flair_wave:2, etc, and we don't have to modify existing metadata ids

Script should replace user flairs on reddit with upgraded flairs if they have been purchased

mod: script for flair purchases

script to parse specified address for flair transactions and award flairs accordingly

fee-relayer: auto increase utxos if necessary

The fee-relayer could have a desired number of utxos.

If the current number of utxos is below that level, on each relay tx it could split its change output into 2 or 3 outputs until it reaches the desired level

load tests

extension: handle errors

currently errors are not shown in ui

• implement banner design
  https://www.figma.com/file/7sLpcyPt4jrctHobEcbqef/Reddit_Webwallet?node-id=95%3A302

• add sentry for reporting

error ui

Open source clean up 🧹

• ensure all sensitive information is removed
• licenses
• readme
• CI badge(?)

fee-relayer: implement cancel-tx

fee-relayer: auto merge small value utxos

utxos with a value of less than the fee are useless - they can be periodically merged into a larger value utxo

fee-relayer: Use Curvegrid HSM with multiple addresses

extension: 1.0.0 bugs

list of bugs discovered so far

• error parser not picking up unexpected objects https://sentry.io/organizations/omisego/issues/1818062246/?project=5338840&referrer=slack
• handle invalid extension context gracefully
• support old.reddit
• extension doesn't block user from trying to submit more than 4 input utxos. if there are more than 4 utxos needed to cover the transfer amount, the server responds with the error "Number of non-empty inputs should match signatures count. Remove redundant signatures." We should build in a way to create and submit a merge tx when this happens or prompt the user to merge them in webwallet
• user-address parser not parsing comments with new lines correctly
• show purchased flairs next to username
• check behavior on brave when metamask not set as the default provider
• handle "Permissions request already pending" gracefully https://sentry.io/organizations/omisego/issues/1801689554/?project=5338840&query=is%3Aunresolved
• add "refresh page" to "restart extension" prompt
• add support link in extension

Flair service is running as root

https://github.com/omgnetwork/community-points/pull/83/files#diff-fb3fa3247fdd2026088800e297d482e2

Introduces a Dockerfile to run the flair update script. It's running as root which is discouraged:

docker run -ti --entrypoint /bin/sh flair                                                                                    
/app # whoami
root

Consider adding a user to run this service.

extension: handle fee-relayer busy

If the fee-relayer is under heavy load it may not have an available utxo to pay the fee, but it should have one after the next block.

The extension should handle an error from create-relay-tx that starts the string Insufficient funds to cover fee amount and display something like "Server busy, try again later"

fee-relayer: make pendingUtxos time out, and remove cancel-tx endpoint

fee-relayer: reduce logs

extension: user avatar from user/address mapping

Extension: add version to sentry errors

We’re gona run into an issue of ppl running old versions and sentry still throwing

Use manifest version to filter out old errors
https://stackoverflow.com/questions/14149209/read-the-version-from-manifest-json

extension: double check useraddress mapping limits

double check limit on query does indeed fetch all top level thread comments

fee-relayer: Use Curvegrid HSM for signing

Extension: notification on incoming transfer

When app is open, diff transaction poll

extension: metamask issues

• better ux when metamask doesnt want to popup. how to recognize this event in the extension and add appropriate messaging
• sometimes metamask is not ready when extension tries to access it, leaving it in a blank state unless restarted. investigate how to avoid this race condition

Extension: dynamic flair config fetch

fee-relayer: clean up pending utxos

Extension: upgrade prompt

While distribution is on gh, check if newer release exists and prompt user to upgrade

extension: bugz

• notification in lowest denomination

extension: 0.1.0 bugz

• dont report 500's from extension, let feerelayer report them
• prompt to login to metamask -> dont login -> restart extension -> "already processing eth_requestAccounts. Please wait." error
• notification in lowest denomination
• gray out extension icon unless on reddit.com/*

fee-relayer: releasing accounts from DB on shutdown is unreliable

If the pod doesn't shutdown gracefully the account is not marked as available in the DB, so we can run out of available accounts.

One solution is to use timed leases that are constantly renewed while the pod is up.

extension: 1.0.2 improvements

• lazy load user avatars, currently they are fetched all at once which is getting heavier as user base grows
• block merch screen when tx loading And calculating if flairs already purchased or not (delay in showing owned state)
• fill inputs with utxos to reduce overall utxos
• flair levels (extension)
• transaction flush only when address changed, or key by address #117

Publish contract ABI as artifect

Have been thinking about possible solutions:

1. use ethPM as the package management. Not sure how to get the ABI out though. Supposedly do-able
2. use npm as the package management. However, limited to npm to get the ABI out
3. use a artifact branch in this repo, whenever there is a new release, we publish the ABI with the semver in a folder the branch there. eg. abi/v0.0.1/ and abi/v0.0.2/ ...
4. Just manual put the ABI under contracts/ as Pong suggested.

fee-relayer: add Sentry error reporting

fee-relayer: dockerize

extension: call fee-relayer

create transaction with signed fees from fee-relayer

extension: updated extension behavior

scenario:

• user uploads new version of extension
• user doesnt do a full refresh of the page
• certain scripts already loaded in the browser may not be updated leaving extension in a weird state and failing

to investigate:

• what is the behavior when the extension is hosted from the store and auto-updating takes place
• is it possible for the extension to recognize the inconsistent state and force the refresh or provide appropriate message
• potential refactor around the re-injection of scripts in dom