Giter Site home page Giter Site logo

Comments (3)

igroomgrim avatar igroomgrim commented on August 28, 2024 2

Hi @pauloec
Thanks for your comment. We understand your point. Apple has a lot of changes in View Controller Presentation on iOS13 and because not all OTP pages are the same. You can provide a cancel or done button by yourself by programmatically in your OTP page on iOS12 like

if #available(iOS 12, *) {
      navigationController.navigationItem.rightBarButtonItem = UIBarButtonItem(title: "Done", style: .done, target: self, action: #selector(dismissOTPPage))
}

@objc func dismissOTPPage() {
      dismiss(animated: true)
}

That would be support for iOS12 and the button will be hiding from iOS13.
😄

from omise-ios.

pauloec avatar pauloec commented on August 28, 2024 2

Hey @igroomgrim!

Yes, you're correct! I've done that before you've mentioned. I'm just concerned by the fact that the SDK could perhaps come ready outside of the box, if you know what i mean! This can lead to confusion, especially to small teams that are trying your product. I do understand that this will only happen while we're transitioning to iOS 13 though :)

Thanks for your feedback

from omise-ios.

igroomgrim avatar igroomgrim commented on August 28, 2024

Hi @pauloec
Thank you for your advice and support.
We'd love to hear your feedback that very useful for our SDK.
🙇

from omise-ios.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.