Giter Site home page Giter Site logo

omise-ios's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

omise-ios's Issues

Alipay Jump Alipay APP payment

In AuthorizingPaymentViewController
It seems that you need to implement the

func open(_ url: URL, options: [UIApplication.OpenExternalURLOptionsKey : Any] = [:], completionHandler completion: ((Bool) -> Void)? = nil)

method in

 public func webView(_ webView: WKWebView, decidePolicyFor navigationAction: WKNavigationAction, decisionHandler: @escaping (WKNavigationActionPolicy) -> Swift.Void)

to jump to the Alipay app

Roadmap & Issues

Would love to see some documentation on getting started / product roadmap and having more issues available on github (assuming you have some sort of private PM software). Thanks!

OMSAuthorizingPaymentViewController NSInvalidArgumentException

Since the past year, our production environment has reported several crashes

*** -[__NSCFString stringByReplacingCharactersInRange:withString:]: nil argument

And page tracking shows that the last few pages are

...
13 07-12 16:51:09.627 [ UISystemKeyboardDockController ] WillAppear
14 07-12 16:51:16.630 [ OMSAuthorizingPaymentViewController ] WillAppear
15 07-12 16:51:20.999 [ UISystemKeyboardDockController ] WillAppear
16 07-12 16:51:21.003 [ UICompatibilityInputViewController ] WillAppear
17 07-12 16:51:21.003 [ UICompatibilityInputViewController ] WillAppear
18 07-12 16:51:21.005 [ UICompatibilityInputViewController ] WillAppear
...

I found that OMSAuthorizingPaymentViewController is just a webView. Any suggestions on this problem? Thanks.

CocoaPods?

Previously, some people ask how to use cocoapods, but that issue thread says not to make it.
But do you change your mind?

Omise 3.7.1 (XCode 12.1) -- Previous Solutions Not Working

I've tried the previous solutions used in other threads, including running the cleaning Derived Data, running scripts, etc., and none are working.

I am receiving the following message after running (carthage update --platform iOS --cache-builds):

Building scheme "OmiseSDK" in OmiseSDK.xcodeproj
Build Failed
Task failed with exit code 1:
/usr/bin/xcrun lipo -create /Users/jhareinger/Library/Caches/org.carthage.CarthageKit/DerivedData/12.1_12A7403/omise-ios/v3.7.1/Build/Intermediates.noindex/ArchiveIntermediates/OmiseSDK/IntermediateBuildFilesPath/UninstalledProducts/iphoneos/OmiseSDK.framework/OmiseSDK /Users/jhareinger/Library/Caches/org.carthage.CarthageKit/DerivedData/12.1_12A7403/omise-ios/v3.7.1/Build/Products/Release-iphonesimulator/OmiseSDK.framework/OmiseSDK -output /Users/jhareinger/Documents/proj/Carthage/Build/iOS/OmiseSDK.framework/OmiseSDK

This usually indicates that project itself failed to compile. Please check the xcodebuild log for more details: /var/folders/yf/ntpxp9sx213bn11wxv0vzj5r0000gn/T/carthage-xcodebuild.xtUwJP.log

XCode 12 (Swift 5.3) supported

Currently SDK seems not to support latest XCode 12 yet. Please provide the update

Compile error:

Module compiled with Swift 5.2.4 cannot be imported by the Swift 5.3 compiler

XCode: Version 12.0 (12A7209)

Issues with Setting Up Promptpay

Screen Shot 2021-06-25 at 10 15 16 AM

I followed the integration process and received the following error. Although it is not related specifically to PromptPay, it is an issue that arises when utilizing the Request tied to payment Source.

I am using Omise 4.3.0 and Xcode 12.5

Cannot tokenizing a Credit Card

SDK V. "omise/omise-ios" "v3.1.0"

Hi omise team,

I'm trying to tokenizing credit card and following the documentation as bellow code.
`let tokenParameter = Source.CreateParameter(
name: "JOHN DOE",
number: "4242424242424242",
expirationMonth: 11,
expirationYear: 2019,
securityCode: "123"
)

let request = Request(parameter: tokenParameter)`

I'm facing Source.CreateParameter unable initiate as instruction.
Source.CreateParameter(paymentInformation: <#T##PaymentInformation#>, amount: <#T##Int64#>, currency: <#T##Currency#>)

Thanks in advance

An error is reported when debugging and compiling a real machine

The following error log is displayed?
'/private/var/containers/Bundle/Application/31B25E35-5321-493C-8964-CABDECC5A5E4/Konvy.app/Frameworks/OmiseSDK.framework/OmiseSDK' (errno=2), '/private/var/containers/Bundle/Application/31B25E35-5321-493C-8964-CABDECC5A5E4/Konvy.app/Frameworks/OmiseSDK.framework/OmiseSDK' (errno=2)

OmiseSDK need support for xcode 11

Hi OmiseSDK Team,

OmiseSDK cannot support for xcode 11, can you provide a solution for this please ?

following issue i'm facing Module compiled with Swift 5.0.1 cannot be imported by the Swift 5.1.3 compiler:

Architecture x86_64-apple-ios-simulator

Running our project that used to work in Xcode 11 gives the following error for Omise:

Could not find module 'OmiseSDK' for target 'x86_64-apple-ios-simulator'; found: arm64, armv7-apple-ios, arm64-apple-ios, arm, armv7

Does x86_64-apple-ios-simulator exist in any specific build version?
I've ran 3.8.0, 3.7.1, and 3.3.0

Appicon file name error

When we archive our project to apple store.
Apple reject because App icon name is duplicate from omise.
How to fix it ?

[!] Error installing omise-ios

Hi
I am getting this error on xcode 12 after adding
pod 'omise-ios', '~> 1.0'
then
pod install

Terminal returns this error.

`Installing omise-ios (1.0.2)

[!] Error installing omise-ios
[!] /usr/bin/git clone https://github.com/omise/omise-ios.git /var/folders/x7/ftlk688d3s95d4jr9tzydsc40000q3/T/d20210520-36807-2l6eb8 --template= --single-branch --depth 1 --branch v1.0.2

Cloning into '/var/folders/x7/ftlk688d3s95d4jr9tzydsc40000q3/T/d20210520-36807-2l6eb8'...
warning: Could not find remote branch v1.0.2 to clone.
fatal: Remote branch v1.0.2 not found in upstream origin`

Please help resolve

Installation hangs via Carthage

Hi,

I was trying to integrate Omise iOS SDK into my project via Carthage, which is the only supported package manager by now, but failed. Here are some details:

  • carthage version: 0.26.2
  • xcodebuild -version: Xcode 9.1 Build version 9B55
  • Are you using --no-build? no
  • Are you using --no-use-binaries? no
  • Are you using --use-submodules? no
  • Are you using --cache-builds? no

After adding omise-ios to my Cartfile and run carthage update, the update process hangs after
the line

*** Checking out omise-ios at "v2.6.0"

If I remove omise-ios and run again, it will go through to the build phase.

I've worked around this issue by requesting Omise Token API by myself, so it's not urgent for me, but I think I should report this to you guys anyways.

CocoaPods support

I'm trying to update but I see that you are only supporting CocoaPods for v1.
Are you planning on releasing a pod anytime soon?
Normally every SDK has both options or only pods.

Thank you,

Andoni

how can i extract the specific error message??

I can't extract the error message from omise delegate method "func tokenRequest(request: OmiseTokenRequest, didFailWithError error: ErrorType)". i have converted as
let nsError = error as NSError
print(nsError.localizedDescription)
print(nsError.localizedFailureReason)
print(nsError.domain)
print(nsError.code)
but don't get the exact error message by contrast error message is visible in API(code: String, message: String, location: String). But i am unable to get that message.

Weird UI on iOS 11

Xcode 9.0 beta 6 (9M214v)
iOS 11 beta 8 (15A5368a)
OmiseSDK version 2.5.0
img_2dbbb15d4eb3-1

doesn't work on iphone simulator

after integrating this SDK, we can't build our app into simulator
it only works on real iPhone, so it's slower our development process
could you suggest how to configure this SDK to work with simulator?

iOS Visa OTP page no cancel button

Hi!

The visa OTP page has no cancel button and so the user has no option to just close the page on iOS 12.2

presenter.present(handlerController, animated: true, completion: nil)

presenter is a UINavigationController and while in iOS 13 you have the option to slide down the page, the same doesn't happen on iOS 12. I do understand that not all OTP pages are the same and some contain the cancel button but that isn't the best approach IMO

React Native support

I know this might not be directly related to this repo, but I would like to know if Omise have any plan on React Native support?

The ideal case would be react native library with native code bridge to both iOS and android platform, which have the API similar to Omise.js.

import Omise from 'react-native-omise';
Omise.setPublicKey('<public key>');
...
Omise.createToken('card', { ... }, (statusCode, response) => {
  ...
})

I could create the lib my my own but it would take quite a time so I want to ask you guys first if you have any plan on this.

Also, I am waiting for https://github.com/omise/omise.js/issues/11 to be resolved (Sorry for all the diverse tech stacks I have been using.)

Cheers,

Default (selected) year in CardExpiryDatePicker

CardExpiryDatePicker has default year = 0.
Is it possible to set it to currentYear?

When user choose not to scroll(select) pickerView and continue, the month return current one in picker view but the year stays 0.

class CardExpiryDatePicker: UIPickerView {
    //...
    /// Currently selected year.
    public var year: Int = 0
    //...
    private let years: [Int] = {
        let currentYear = Calendar.creditCardInformationCalendar.component(.year, from: Date())
        return Array(currentYear...(currentYear.advanced(by: maximumYear)))
    }()
    //...
}

Demo project - Umbrella header 'CardIO.h' not found

I'm trying out the example app and see the following compilation error:
Umbrella header 'CardIO.h' not found, which causes:
Could not build Objective-C module 'OmiseSDK'

I checked the web for solutions and it appears to be something around Carthage dependency manager not handling Swift language changes (AliSoftware/OHHTTPStubs#168)

Just letting you guys know what's up.
screen shot 2018-03-28 at 10 04 06 am

XCode Version 9.2 (9C40b)

Built for iOS

Running our project in Xcode 12 to a simulator gets the following build error:

Building for iOS Simulator, but the linked and embedded framework 'OmiseSDK.framework' was built for iOS.

Has anyone else seen this issue?

Custom Payment Form Icons

I'm working custom payment method selection + custom credit card form.
Is it possible to use/access Omise's credit card/payment method icon images?

I tried to get it like this, but the image is nil. Is this the correct approach?

let bundle = Bundle(for: CreditCardFormViewController.self)
let image = UIImage(named: "Visa", in: bundle, compatibleWith: nil) //image == nil

If it's possible to use Omise's icon, would it be possible to create an extension for this? i.e.

public extension CardBrand {
    var iconName : String { self.description }
    var iconImage : UIImage? {
        //...
        return UIImage(named: iconName, in: Bundle.module, compatibleWith: trait)
    }
}
public extension OMSSourceTypeValue {
    var iconName : String { self.rawValue }
    var iconImage : UIImage? {
        //...
        return UIImage(named: iconName, in: Bundle.module, compatibleWith: trait)
    }
}

Thanks!

Request Token, Omise sdk iOS

Hi omise team,

I'm trying to tokenizing credit card and following the documentation as bellow.
let tRequest = Request.init(parameter: Token.CreateParameter(
name: "JOHN DOE",
number: "4242424242424242",
expirationMonth: 11,
expirationYear: 2019,
securityCode: "123"
))

But Request cannot be identified, it gives me error: Generic parameter 'T' could not be [inferred.]
Screenshot 2020-02-25 at 12 10 39 PM

please update version

I saw that you added Prompt Pay feature
but the readme says

github "omise/omise-ios" ~> 3.0

README file last update is months ago, so is it still relevant to use 3.0 version?
I am not iOS dev, so might be I'm wrong, just need clarification before informing this to my team

cross button on card Screen

Found an issue if you show the card screen using the code given in documentation will get a cross button on the right top of the screen and thats useless .

Simulator Screen Shot - iPhone 8 Plus - 2019-04-16 at 16 28 26

Here is the fix

let creditCardView = CreditCardFormViewController.makeCreditCardFormViewController(publicKey)
creditCardView.delegate = self
creditCardView.handleErrors = true
creditCardView.navigationItem.rightBarButtonItem = nil
show(creditCardView, sender: self)

Asset validation failed when upload to AppStore

When I package and upload the APP, an error is displayed:

I use carthage update --use-xcframeworks install omise sdk

I've tried deleting the build and upgrading Carthage and then rebuilding, but the error remains.

The bundle 'Payload/{name}.app/Frameworks/OmiseSDK.framework' is missing plist key. The Into.plist file is missing the required key: CFBundleShortVersionString. Please find more information about CFBundleShortVersionString at https://developer.apple.com/documentation/ bundleresources/intormation_property_list/cfbundleshortversionstring (ID: feea7145-1c7a-489f-80bf-5d9b13d32cb8)
image

Manually install sdk

Hi, now I use cocoapod in my project and I want to use omise sdk. I can do manual install sdk or not?
Please help me.

Can I integrate omise-ios using CocoaPods in my project?

I'm using CocoaPods to integrate all third-party repositories or SDKs in my project currently. As the docs said, omise-ios can be integrated by Carthage but not CocoaPods. My question is : can I integrate omise-ios using CocoaPods in my project? To be honest, I'd like not to mix both of them in my project.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.