oneclick/rubyinstaller2-packages

MSYS2-MINGW packages for RubyInstaller2

rubyinstaller2-packages's Issues

libffi in PKGBUILD ?

I was checking rbconfig.rb to see if there were any 'system specific' artifacts that shouldn't exist. The only ones I found were a few in the compile flags referencing msys64/mingw64/lib/libffi-3.2.1/include.

Checked the ruby travis and appveyor files, and no mention, then looked around the repo and found a commit of Nobu's referencing build issues on mswin. Nobu is generally aware of mswin and MinGW issues, so he would normally pick up both if required. It was done in 2.4 days, and backported to 2.3 and maybe 2.2.

Anyway, both of our PKGBUILD files have something similar in the build section:

local FFI_INC=$(pkg-config --cflags libffi)
CPPFLAGS+=" -DFD_SETSIZE=2048 ${FFI_INC}"
CFLAGS+=" ${FFI_INC}"

See 2.4 PKKBUILD and 2.5 PKGBUILD.

I removed anything related to libffi, and built trunk and 2.3.4. Both had the same amount of test-all failures/errors as previous builds. There were actually increases in tests and assertions, and the two measures of skips dropped. Both of the rbconfig.rb files were artifact free. I also ran the fiddle tests in a windows cmd shell (no make), and they passed.

I haven't checked thouroughly, but I think this may be something that's out of date, and has never been checked for whether it's still required. It's listed in the original PKGBUILD from 2013-12-03. fiddle.so still requires libffi-6.dll, but the flags may not be needed.

Hence, you might have a look, as I'm rather 'c' challenged...

Sorry about forgetting the dll in GDBM...

Json - may require ragel package for building

Testing a bunch of builds, and I noticed the issue with 2.4.1.

Most tests I can run on 2.4.1 with something similar to

ruby -v runner.rb -I. --show-skip json

Json has a seg fault.

EDIT: I can do a PR and add it to the PKGBUILD depends section, wasn't sure if you had any other PR's/commits ready. Have to be a bit later...

Might ruby-loco use dll_directory?

Lars,

Good day.

Would you mind if I used dll_directory in ruby-loco's mingw & ucrt builds?

I am asking, so feel free to say no...

Thanks, Greg

MSYS2 updated to OpenSSL 3

And, cert & conf files are in etc/ssl, not ssl…

Question - Will Ruby 3.1 continue with OpenSSL 1.1.1?

Asking because GitHub Actions code will need to be changed if Ruby 3.1 changes to OpenSSL 3.0.x...

OpenSSL - MSYS2/MinGW added (broken) 1.1.1 package

@larskanis

1. MSYS2 moved to OpenSSL 1.1.1 and it's currently broken. Main issue may be repo's that are using whatever Appveyor has, or worse, updating OpenSSL with a pacman upgrade. As you know, only affects 2.4.

2. Unknown what Appveyor will do. Haven't asked.

3. I decided that ruby-loco will only be for trunk, rebuilt it so it runs all with two PowerShell scripts (one is build/install, one is test). Runs locally.

4. None of the tests utilize make, all are run from the install folder's Ruby. Took a few patches for that.

I'll probably save a few of the MSYS2 OpenSSL packages to BinTray and use those for CI.

Hope things are well, Greg

ci

The ci.r2 database download is giving me a 403 error when running pacman -Syu. I had to comment out the last 2 lines that were added by rubyinstaller2

bin files - 2.6.0 & trunk

Lars,

Good day. You may noticed the change in the bin files, as there are no longer pairs of files for CLI apps.

In 2.5 and earlier, one could run things from a Git Bash shell. With the removal of the extension-less files, that is no longer true. I've also seen some CI setups that used bash scripts to run setup/tests in both *nix and Windows CI. Just thought I'd point it out, opened a Ruby issue already...

Thanks again, Greg

0002-use-gnu-printf.patch moves again...

Lars,

Good day. Re trunk, thought I'd give you a head's up that:

Configure.in -> Configure.ac -> tool/m4/ruby_check_printf_prefix.m4

My patch is at tool-m4-ruby_check_printf_prefix.m4.patch

Thanks, Greg