onehq/cassy

A CAS server that runs as a Rails Engine

cassy's Issues

delasia 23

mmm you really has an fake profile but help me get one too and im a dater but hey if that boy call me a b**** again i will punch the sh** out of hem ooooooooooooooooh

valid_credentials? is broken

cas.rb, line 206 - if authenticator.find_user returns nil, and @ticketed_user hasn't been set, valid_credentials is always true.

Rubygems has outdated cassy gem

Looking at https://rubygems.org/gems/cassy, the latest version on there is 1.1.4.

Please push the latest revision of cassy to rubygems.

Thanks,

• Rob

Commit 64c46 breaks application causing error on login do to valid_services always returning nil

Commit 64c461c causes application error upon login.

Occuring on line 244 of sessions_controller.rb
@valid_services ||= settings[:service_list].split(" ")

settings[:service_list] doesn't appear to ever be set anywhere so this always returns nil resulting in the following error upon login:

/Users/mm/Documents/Development/cassy/app/controllers/cassy/sessions_controller.rb:244:in valid_services' /Users/mm/Documents/Development/cassy/app/controllers/cassy/sessions_controller.rb:249:infind_or_generate_service_tickets'
/Users/mm/Documents/Development/cassy/app/controllers/cassy/sessions_controller.rb:264:in cas_login' /Users/mm/Documents/Development/cassy/app/controllers/cassy/sessions_controller.rb:63:increate'
actionpack (3.1.1.rc2) lib/action_controller/metal/implicit_render.rb:4:in send_action' actionpack (3.1.1.rc2) lib/abstract_controller/base.rb:167:inprocess_action'
actionpack (3.1.1.rc2) lib/action_controller/metal/rendering.rb:10:in process_action' actionpack (3.1.1.rc2) lib/abstract_controller/callbacks.rb:18:inblock in process_action'
activesupport (3.1.1.rc2) lib/active_support/callbacks.rb:434:in _run__3547593106756210172__process_action__1965264710238733535__callbacks' activesupport (3.1.1.rc2) lib/active_support/callbacks.rb:386:in_run_process_action_callbacks'
activesupport (3.1.1.rc2) lib/active_support/callbacks.rb:81:in run_callbacks' actionpack (3.1.1.rc2) lib/abstract_controller/callbacks.rb:17:inprocess_action'
actionpack (3.1.1.rc2) lib/action_controller/metal/rescue.rb:17:in process_action' actionpack (3.1.1.rc2) lib/action_controller/metal/instrumentation.rb:30:inblock in process_action'
activesupport (3.1.1.rc2) lib/active_support/notifications.rb:53:in block in instrument' activesupport (3.1.1.rc2) lib/active_support/notifications/instrumenter.rb:21:ininstrument'
activesupport (3.1.1.rc2) lib/active_support/notifications.rb:53:in instrument' actionpack (3.1.1.rc2) lib/action_controller/metal/instrumentation.rb:29:inprocess_action'
actionpack (3.1.1.rc2) lib/action_controller/metal/params_wrapper.rb:201:in process_action' activerecord (3.1.1.rc2) lib/active_record/railties/controller_runtime.rb:18:inprocess_action'
actionpack (3.1.1.rc2) lib/abstract_controller/base.rb:121:in process' actionpack (3.1.1.rc2) lib/abstract_controller/rendering.rb:45:inprocess'
actionpack (3.1.1.rc2) lib/action_controller/metal.rb:193:in dispatch' actionpack (3.1.1.rc2) lib/action_controller/metal/rack_delegation.rb:14:indispatch'
actionpack (3.1.1.rc2) lib/action_controller/metal.rb:236:in block in action' actionpack (3.1.1.rc2) lib/action_dispatch/routing/route_set.rb:65:incall'
actionpack (3.1.1.rc2) lib/action_dispatch/routing/route_set.rb:65:in dispatch' actionpack (3.1.1.rc2) lib/action_dispatch/routing/route_set.rb:29:incall'
rack-mount (0.8.3) lib/rack/mount/route_set.rb:152:in block in call' rack-mount (0.8.3) lib/rack/mount/code_generation.rb:96:inblock in recognize'
rack-mount (0.8.3) lib/rack/mount/code_generation.rb:82:in optimized_each' rack-mount (0.8.3) lib/rack/mount/code_generation.rb:95:inrecognize'
rack-mount (0.8.3) lib/rack/mount/route_set.rb:141:in call' actionpack (3.1.1.rc2) lib/action_dispatch/routing/route_set.rb:532:incall'
warden (1.0.5) lib/warden/manager.rb:35:in block in call' warden (1.0.5) lib/warden/manager.rb:34:incatch'
warden (1.0.5) lib/warden/manager.rb:34:in call' actionpack (3.1.1.rc2) lib/action_dispatch/middleware/best_standards_support.rb:17:incall'
rack (1.3.3) lib/rack/etag.rb:23:in call' rack (1.3.3) lib/rack/conditionalget.rb:35:incall'
actionpack (3.1.1.rc2) lib/action_dispatch/middleware/head.rb:14:in call' actionpack (3.1.1.rc2) lib/action_dispatch/middleware/params_parser.rb:21:incall'
actionpack (3.1.1.rc2) lib/action_dispatch/middleware/flash.rb:243:in call' rack (1.3.3) lib/rack/session/abstract/id.rb:195:incontext'
rack (1.3.3) lib/rack/session/abstract/id.rb:190:in call' actionpack (3.1.1.rc2) lib/action_dispatch/middleware/cookies.rb:331:incall'
activerecord (3.1.1.rc2) lib/active_record/query_cache.rb:62:in call' activerecord (3.1.1.rc2) lib/active_record/connection_adapters/abstract/connection_pool.rb:477:incall'
actionpack (3.1.1.rc2) lib/action_dispatch/middleware/callbacks.rb:29:in block in call' activesupport (3.1.1.rc2) lib/active_support/callbacks.rb:392:in_run_call_callbacks'
activesupport (3.1.1.rc2) lib/active_support/callbacks.rb:81:in run_callbacks' actionpack (3.1.1.rc2) lib/action_dispatch/middleware/callbacks.rb:28:incall'
actionpack (3.1.1.rc2) lib/action_dispatch/middleware/reloader.rb:68:in call' rack (1.3.3) lib/rack/sendfile.rb:101:incall'
actionpack (3.1.1.rc2) lib/action_dispatch/middleware/remote_ip.rb:48:in call' actionpack (3.1.1.rc2) lib/action_dispatch/middleware/show_exceptions.rb:47:incall'
railties (3.1.1.rc2) lib/rails/rack/logger.rb:13:in call' rack (1.3.3) lib/rack/methodoverride.rb:24:incall'
rack (1.3.3) lib/rack/runtime.rb:17:in call' activesupport (3.1.1.rc2) lib/active_support/cache/strategy/local_cache.rb:72:incall'
rack (1.3.3) lib/rack/lock.rb:15:in call' actionpack (3.1.1.rc2) lib/action_dispatch/middleware/static.rb:53:incall'
railties (3.1.1.rc2) lib/rails/engine.rb:456:in call' railties (3.1.1.rc2) lib/rails/rack/content_length.rb:16:incall'
railties (3.1.1.rc2) lib/rails/rack/log_tailer.rb:14:in call' rack (1.3.3) lib/rack/handler/webrick.rb:59:inservice'
/Users/mm/.rvm/rubies/ruby-1.9.2-p0/lib/ruby/1.9.1/webrick/httpserver.rb:111:in service' /Users/mm/.rvm/rubies/ruby-1.9.2-p0/lib/ruby/1.9.1/webrick/httpserver.rb:70:inrun'
/Users/mm/.rvm/rubies/ruby-1.9.2-p0/lib/ruby/1.9.1/webrick/server.rb:183:in `block in start_thread'

cassy config

It would be nice for the config to be treated like erb where you can customize your server_list: by environment.

<% if ENV['RAILS_ENV'] == "production" %>
 - https://test.com/users/service
 - http://test.test.com/users/service
<% else %>
 - http://localhost:3000/users/service
 - http://localhost:3001/users/service
 - http://localhost:3002/users/service
<% end %>

unable to bundle install gem with version

Within bundler, if you point to a gem version the gem does not work properly, however, pointing directly to git works fine.

hardcoded devise routes

These should be pulled from devise_for not hardcoded to "user".

Allowing login from wildcard subdomains

Now that Cassy has the explicit service list in cassy.yml, what's the suggested approach for allowing login from wildcard subdomains?

For example in a "Basecamp-style" subdomain system where users login from their own subdomain, where the subdomain is generated at the time of the account creation.

Would it be safe to modify Cassy so that it checks against a main domain in the service list instead of the full url?

unused routes

As you are not able to authenticate to CAS server, remove /users/sign_in and /users/sign_out routes.

dependent on rails 3.0.9

s.add_dependency 'rails', '>= 3.0.9'

customize session controller issue

when i write

cassy :controller => :sessions

it gives me following error

/home/prashant/.rvm/gems/ruby-1.9.3-p374@rails4/bundler/gems/cassy-cfd7dfad7902/lib/cassy/routes.rb:8:in `[]': can't convert Symbol into Integer (TypeError)

after debugging the code, i found that it should be written as

cassy :controller => { :sessions => :sessions }

logout to use :service not :destination

currently logout sets the param destination, it would be nice to make it service just like login. if this isn't a cassy issue let me know and i will log it to cas_authenticatable.