ongr-io / translationsbundle Goto Github PK
View Code? Open in Web Editor NEWTranslations GUI for translating Symfony static strings
License: MIT License
Translations GUI for translating Symfony static strings
License: MIT License
Filter Manager now has an additional argument in its constructor - event dispatcher. The bundle fails when it tries to create a definition of filter manager without it:
Translation should have dirty flag showing if translation has been exported after editing.
How about doing AJAX and trying to load that specific key in specific locale seeing if it would crash?
Currently import command requires "full bundle namespace". It should support short form (e.g., ONGRTranslationsBundle).
Also whole import service should be reviewed. Probably it's overcomplicated. (Tip: see Kernel::locateResource()
.)
EDIT: it looks like configuration also ask full namespaces.
Uncaught PHP Exception Symfony\Component\Debug\Exception\UndefinedMethodException: "Attempted to call an undefined method named "isRelevant" of class "ONGR\ElasticsearchBundle\DSL\Filter\TermFilter"." at /{edited}/vendor/ongr/filter-manager-bundle/Filters/Widget/Choice/SingleTermChoice.php line 80
When trying to select any domain in UI.
With filter-manager 0.4.2.
Updating filter-manager to 0.5.4 seems to solve this.
From conversation in #52.
Scenario: Added "en", "de" and "lt" to config, imported translations from bundle and I see only "en" and "lt". Why? Because there were no translations in "de". Current implementation lists translations based on data in ES. What if I want to translate to new language? It should be enough to add new locale in config.
vendor/ongr/translations-bundle/Storage/ElasticsearchStorage.php:53
vendor/ongr/translations-bundle/Storage/ElasticsearchStorage.php:57
new TermsFilter('locale'... key is invalid. Should be 'messages.locale', same with domains.
https://www.dropbox.com/s/sbrdrx1230nwysz/Screenshot_2015-04-10-08-24-24.png?dl=0
Nexus 5, Lollipop 5.1, latest Chrome.
Request desktop version - turned off.
3 steps action:
ongr:translations:export
and other required commands)In Import
service importComponentTranslationFiles()
method, we are importing some symfony components translation files:
TranslationsBundle/Service/Import.php
Line 172 in 5190dc9
Few places stopped working after ESB 1.0 integration. Because of lack of tests these were not spotted until now.
Best way to catch all of them would be to setup demo project and test all actions available in UI. Commands looks to be working well.
Few spotted places:
History
document has public properties, but various services calls getters and setters. Public properties should be replaced by getters and setters.Relates #60
group (string)
-> tags (object)
Having multiple translations it's very easy to miss untranslated items by simply browsing through pages.
Would be nice to be able to filter by missing translations by locale.
Particularly for mobile dev, we'd need a way to limit the translations to a certain width, where a maximum width was defined. Ideally this width is defined in terms of #pixels
Open for better ideas.
Preview could happen on STAGE, while pulling translations from LIVE's DB (read-only access, so should be safe).
Currently TranslationManager is responsible for adding new objects like messages and tags to translation documents. The process is being handled by addObject()
method, which at the moment does not add any objects to the given document:
The result of this is that the bundle is not capable of adding tags or new messages to translations
TranslationsBundle/Document/Message.php
Line 22 in 0a80a47
Check other classes too.
If there are changed translation files in push - reimport.
Current situation:
Running app/console ongr:translations:import Foo\\BarBundle\\FooBarBundle
imports only keys (no locale translations) due to nulled locales not matching anything. See: https://www.dropbox.com/s/wussq60g5v2qgix/Screenshot%202015-03-02%2014.06.35.png?dl=0
Running app/console ongr:translations:import
imports everything.
Proposal:
When specifying one filter option (bundle/domain/locale), others should remain match all
, thus running app/console ongr:translations:import Foo\\BarBundle\\FooBarBundle
actually imports something useful.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.