onurhuseyincantay/hover

Async network layer with Combine

hover's Issues

Authentication Support

Network Authentication support for Bearer Basic etc

Hover doesn't work on M1 iOS Simulator

Hi @onurhuseyincantay

I'm receiving the following error on Xcode both on canvas and on simulator.

Supporting lower versions

Adding Support for lower than iOS 13 watchOS, TvOS etc

Adding Garbage Collector Support (Set<AnyCancellable>)

Request is cancelled on Mac Catalyst

Here's the response:

 Task <31B06E42-1D6F-42C2-84A8-65CB0BEE175F>.<1> finished with error [-999] Error Domain=NSURLErrorDomain Code=-999 "cancelled" UserInfo={NSErrorFailingURLStringKey=https://api.notemate.com/notemate/register, NSLocalizedDescription=cancelled, NSErrorFailingURLKey=https://api.notemate.com/notemate/register}

WorkType L15 Encodable issue

https://github.com/onurhuseyincantay/Hover/blob/master/Sources/Hover/Types/WorkType.swift#L15

I think it bugs. this is how I fixed

public struct AnyEncodable: Encodable {
    public let encodable: Encodable

    public init(_ encodable: Encodable) {
        self.encodable = encodable
    }

    public func encode(to encoder: Encoder) throws {
        try self.encodable.encode(to: encoder)
    }
}

public enum DataType {
    case requestPlain
    case requestData(data: Data)
    case requestParameters(parameters: [String: Any], encoding: JSONEncoder = JSONEncoder())
    case requestWithEncodable(encodable: AnyEncodable)
}

Url Form Encoded Request

Currently the URLFormEncoded Request is not properly constructed therefor it has a bug needs to be fixed.

Handling the NSURLSession Caching

Debug Logging Support

Adding Shared Preference where you can enable disable debugging option and will show endpoint path header attributes and body response or error if neede.

Update Unit Testing Approach

Current Unit Test Approach hits the network layer we want to avoid that and make a better, not flaky and stable version of the unit tests.

Package causes SwiftUI preview to fail

Due to canImport(Combine) statement inside Hover, previews are failing.

it was my mistake after debug 4 hours found

Support SPM

It would be perfect if Hover supported SPM

Make CI & CD Pass

Currently the swift batch is not passing the update the failing tests and make it pass again it might be because of the JsonPlaceholderAPI that we are using as test resource.

Add Async Await support