op-ted/efx-toolkit-java

This is an EFX translator written in Java. It supports multiple target languages. It includes an EFX expression translator to XPath. It is used to in the generation of the Schematron rules in the eForms SDK.

efx-toolkit-java's Issues

[1.3.0] XPathContextualizer leaves context when child with predicate has same EFX-Context as Parent

The Patches for eForms SDK 1.7.2 introduced a new EFX Semantic, which uses the same context in child elements as their parent do.
This in turn triggers a Bug inside the XPathContextualizer, which will then leave the childs context and instead select all children.

Given the following section of the template view-template/16.efx:

0 {ND-Organization} #{auxiliary|text|roles}: // Roles of this organisation
			0 {ND-Organization[count(for text:$orgid in OPT-200-Organization-Company return OPT-300-Procedure-Buyer[OPT-300-Procedure-Buyer == $orgid])>0]} #{auxiliary|text|buyer} // This org is a Buyer
				{OPP-050-Organization[OPP-050-Organization == TRUE]} #{field|name|OPP-050-Organization} // Leader of the group
				{OPP-052-Organization[OPP-052-Organization == TRUE]} #{field|name|OPP-052-Organization} // CPB Acquiring
				{OPP-051-Organization[OPP-051-Organization == TRUE]} #{field|name|OPP-051-Organization} // CPB Awarding
			{ND-Organization[(some text:$esender in (for text:$orgid in OPT-200-Organization-Company, text:$servprovtype in OPT-030-Procedure-SProvider[OPT-300-Procedure-SProvider == $orgid] return $servprovtype) satisfies $esender == 'serv-prov') or (some text:$esender1 in (for text:$tpoid in OPT-201-Organization-TouchPoint, text:$servprovtype1 in OPT-030-Procedure-SProvider[OPT-300-Procedure-SProvider == $tpoid] return $servprovtype1) satisfies $esender1 == 'serv-prov')]} #{auxiliary|text|organisation-providing-procurement-service} // This org is a Service Provider
			{ND-Organization[(some text:$esender in (for text:$orgid in OPT-200-Organization-Company, text:$servprovtype in OPT-030-Procedure-SProvider[OPT-300-Procedure-SProvider == $orgid] return $servprovtype) satisfies $esender == 'ted-esen') or (some text:$esender1 in (for text:$tpoid in OPT-201-Organization-TouchPoint, text:$servprovtype1 in OPT-030-Procedure-SProvider[OPT-300-Procedure-SProvider == $tpoid] return $servprovtype1) satisfies $esender1 == 'ted-esen')]} #{auxiliary|text|organisation-esender} // This org is an eSender
			{ND-Organization[(OPT-200-Organization-Company == OPT-301-Lot-AddInfo) or (OPT-201-Organization-TouchPoint == OPT-301-Lot-AddInfo)]} #{auxiliary|text|organisation-providing-info-procedure} // Additional Information Providing Organisation (LOT)

Will result in a .xsl of: (which can be reproduced when using f.e. the eforms-notice-viewer in Version 1.8.0, which is the last version supporting EFX 1.0)

 <xsl:template name="block050118"> 
        <section title="block050118"> 
            <span class="label">
                <xsl:value-of select="($labels//entry[@key=concat('auxiliary', '|', 'text', '|', 'roles')]/text(), concat('{', concat('auxiliary', '|', 'text', '|', 'roles'), '}'))[1]"/>
            </span>
            <span class="text">
                <xsl:text>:</xsl:text>
            </span>  
            <xsl:for-each select="../efac:Organization[count(for $orgid in efac:Company/cac:PartyIdentification/cbc:ID/normalize-space(text()) return ../../../../../../cac:ContractingParty/cac:Party/cac:PartyIdentification/cbc:ID[./normalize-space(text()) = $orgid]/normalize-space(text())) &gt; 0]"> 
                <xsl:call-template name="block05011801"/> 
            </xsl:for-each>  
            <xsl:for-each select="../efac:Organization[(some $esender in (for $orgid in efac:Company/cac:PartyIdentification/cbc:ID/normalize-space(text()), $servprovtype in ../../../../../../cac:ContractingParty/cac:Party/cac:ServiceProviderParty/cbc:ServiceTypeCode[../cac:Party/cac:PartyIdentification/cbc:ID/normalize-space(text()) = $orgid]/normalize-space(text()) return $servprovtype) satisfies $esender = 'serv-prov') or (some $esender1 in (for $tpoid in efac:TouchPoint/cac:PartyIdentification/cbc:ID/normalize-space(text()), $servprovtype1 in ../../../../../../cac:ContractingParty/cac:Party/cac:ServiceProviderParty/cbc:ServiceTypeCode[../cac:Party/cac:PartyIdentification/cbc:ID/normalize-space(text()) = $tpoid]/normalize-space(text()) return $servprovtype1) satisfies $esender1 = 'serv-prov')]"> 
                <xsl:call-template name="block05011802"/> 
            </xsl:for-each>  
            <xsl:for-each select="../efac:Organization[(some $esender in (for $orgid in efac:Company/cac:PartyIdentification/cbc:ID/normalize-space(text()), $servprovtype in ../../../../../../cac:ContractingParty/cac:Party/cac:ServiceProviderParty/cbc:ServiceTypeCode[../cac:Party/cac:PartyIdentification/cbc:ID/normalize-space(text()) = $orgid]/normalize-space(text()) return $servprovtype) satisfies $esender = 'ted-esen') or (some $esender1 in (for $tpoid in efac:TouchPoint/cac:PartyIdentification/cbc:ID/normalize-space(text()), $servprovtype1 in ../../../../../../cac:ContractingParty/cac:Party/cac:ServiceProviderParty/cbc:ServiceTypeCode[../cac:Party/cac:PartyIdentification/cbc:ID/normalize-space(text()) = $tpoid]/normalize-space(text()) return $servprovtype1) satisfies $esender1 = 'ted-esen')]"> 
                <xsl:call-template name="block05011803"/> 
            </xsl:for-each>  
            <xsl:for-each select="../efac:Organization[(efac:Company/cac:PartyIdentification/cbc:ID/normalize-space(text()) = ../../../../../../cac:ProcurementProjectLot[cbc:ID/@schemeName='Lot']/cac:TenderingTerms/cac:AdditionalInformationParty/cac:PartyIdentification/cbc:ID/normalize-space(text())) or (efac:TouchPoint/cac:PartyIdentification/cbc:ID/normalize-space(text()) = ../../../../../../cac:ProcurementProjectLot[cbc:ID/@schemeName='Lot']/cac:TenderingTerms/cac:AdditionalInformationParty/cac:PartyIdentification/cbc:ID/normalize-space(text()))]"> 
                <xsl:call-template name="block05011804"/> 
....
        </section> 
    </xsl:template> 

Because of a Bug inside the XPathContextualizer, the generated XPath will leave the block's context:
<xsl:for-each select="../efac:Organization[count(for $orgid in...]...
In this case, it should be : <xsl:for-each select=".[count(for $orgid in...]...

Which in turn will break the selector, because all children of the parent element will be selected, instead of the current one.

This has been corrected with commit 2d43d81, however this fix is only available inside the 2.0.0 alpha releases, which we can't use yet. Right now, all view-templates are broken because of this Bug.

Are there any plans, to release a 1.3.1 Version of the efx-toolkit, to fix this behaviour?