Giter Site home page Giter Site logo

Comments (4)

MrAlias avatar MrAlias commented on June 28, 2024 2

Please coordinate with @XSAM who is working on #5250

from opentelemetry-go.

pellared avatar pellared commented on June 28, 2024 1

Most probably we will have to revert these two PRs:

@gregoryfranklin, thanks for reporting the issue ❤️

from opentelemetry-go.

pellared avatar pellared commented on June 28, 2024

This has be double-check before making a new release as it can be a blocker.

from opentelemetry-go.

XSAM avatar XSAM commented on June 28, 2024

I have checked the protobuf codes regarding this behavior. The implementation prevents importing go.opentelemetry.io/proto/otlp and go.opentelemetry.io/proto/slim at the same time.

https://github.com/protocolbuffers/protobuf-go/blob/e4ad8f9dfc8bc3184ebb70c296bd63955343e903/reflect/protoregistry/registry.go#L126-L133

Though we could use go build -ldflags "-X google.golang.org/protobuf/reflect/protoregistry.conflictPolicy=warn" to change the conflict policy and probably pass this check, it requires our end-users to do this, which is not acceptable.

Plan for the release

Rollback these two PRs:

After the release

We might need to deprecate package go.opentelemetry.io/proto/slim, as it is not compatible with go.opentelemetry.io/proto/otlp, which provides grpc support. And it makes the package somewhat unusable.

from opentelemetry-go.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.