openaadl/polyorb-hi-c

PolyORB-HI/C runtime for Ocarina, supports POSIX, RTEMS, Xenomai, XtratuM RTOS

polyorb-hi-c's Issues

Support for Compcert broken

The support for compcert is currently broken

• detection of compiler is not working
• a few elements in the linking phase to be solved

Support for large messages

In its current implementation, PolyORB-HI/C is limited to packed of size < 64KiB. This should be changed to a uint32_t type.

Code clean-up after Valgrind, CPPCheck and Sonarqube

Various issues have been reported by Valgrind, CPPCheck and Sonarqube
This ticket is to track these issues

Update licence to GPLv3 with runtime exception

This ticket is to track progress to update licence to GPLv3 + runtime exception

No error message emitted when RTEMS not installed and using RTEMS_POSIX target

The makefile stopped immediately with an inaccurate error message:

/Users/hugues/local/ocarina/include/ocarina/runtime/polyorb-hi-c/make/Makefile.leon.rtems_posix:10: /Makefile.inc: No such file or directory
/Users/hugues/local/ocarina/include/ocarina/runtime/polyorb-hi-c/make/Makefile.leon.rtems_posix:12: /make/leaf.cfg: No such file or directory
make: *** No rule to make target `/make/leaf.cfg'. Stop.

Reported by Nivedita Velagaleti

xlocale.h

Several files of the runtime include xlocale.h

However this file is not present in recent versions of glibc, as explained here: https://sourceware.org/glibc/wiki/Release/2.26#Removal_of_.27xlocale.h.27

This prevents compiling applications using pohic on any recent linux distro (e.g. debian 10)

Scheduling issue

The computation of delay for both periodic and sporadic tasks is buggy, reported by ESA

Clean up RTEMS Makefile

RTEMS targets has multiple makefiles, one is enough since everything is steered by RTEMS_MAKEFILE_PATH

build error

when I build ocarina with runtime polyorb-hi-c ,It raises the following error.

rm -f polyorb-hi_ug_ref.bbl
TEXINPUTS=".:.:" \
     BIBINPUTS=".:.:" \
     BSTINPUTS=".:.:" \
        '\nonstopmode \input polyorb-hi_ug_ref.tex'
/bin/bash: \nonstopmode \input polyorb-hi_ug_ref.tex: command not found
make[5]: [polyorb-hi_ug_ref.aux] Error 127 (ignored)
TEXINPUTS=".:.:" \
     BIBINPUTS=".:.:" \
     BSTINPUTS=".:.:" \
        polyorb-hi_ug_ref
/bin/bash: polyorb-hi_ug_ref: command not found
make[5]: [polyorb-hi_ug_ref.bbl] Error 127 (ignored)
sed: can't read polyorb-hi_ug_ref.bbl: No such file or directory
make[5]: *** [polyorb-hi_ug_ref.texi] Error 2

Reorganize management of clock_gettime()

clock_gettime() is now supported by mac OS. One needs to reorganise the code base to reflect this change.

Improve FreeRTOS support

This ticket monitors improvement in support FreeRTOS
As an initial target, we aim at support Discovery kits

Reorganize AADLv2 examples

Current AADLv2 examples have a lot of code duplication across targets. This should be reduced

Issue when install path has a space

RUNTIME_PATH and USER_SOURCES_DIRS should accommodate space in the path.

Integrate cppcheck, valgrind, code coverage and sonarqube

Integrate cppcheck, valgrind and sonarqube as part of the build process to gather metrics on the code quality

Fix warnings

The following warnings should be fixed in the runtime:

po_hi_transport.c:457:66: warning: unused parameter 'task_id' [-Wunused-parameter]
po_hi_transport.c:457:90: warning: unused parameter 'port' [-Wunused-parameter]
po_hi_transport.c:526:73: warning: unused parameter 'src' [-Wunused-parameter]
po_hi_transport.c:526:99: warning: unused parameter 'dst' [-Wunused-parameter]
po_hi_transport.c:539: 100: warning: unused parameter 'p' [-Wunused-parameter]

po_hi_semaphore.c:39:107: warning: unused parameter 'id' [-Wunused-parameter]

po_hi_task.c:483:40: warning: cast between incompatible function types from 'void * ()(void)' to 'void * ()(void )' [-Wcast-function-type]
err = pthread_create (&tid, &attr, (void ()(void))start_routine, arg);
^
And these in the generated code:

activity.c : variable "error" is set but not used

Report error if selected core not supported

We should report an error if a thread is allocated to a non existing core, at least for Linux

BOOST library should be optional

The dependency of BOOST should be optional, as it is needed only for issue #5

Integration of monitoring API

This issue is to track integration of monitoring API in PolyORB-HI/C runtime

Bug in detection of Xenomai

As reported by a TASTE user, the detection of Xenomai is not working

Error should be reported as CRITICAL

In case of errors in the concurrency API, e.g. creating mutex, we should print using a CRITICAL statement, not debug.

[This duplicates ESA/TASTE ticket 521]

Setting stack size on POSIX/RTEMS

The stack size is not properly set up for the POSIX/RTEMS target

compile error when build ping-local

when I build some examples in aadlv2,It cause compiler errors.

yj:ping $ pwd
/home/yj/git/ocarina/resources/runtime/polyorb-hi-c/examples/aadlv2/ping
yj:ping $ ocarina -b -x scenario-local.aadl 
make generate-asn1-deployment target-objects compile-c-files compile-cpp-files compile-ada-files compile-po-hi ping.o activity.o subprograms.o types.o request.o marshallers.o deployment.o naming.o main.o 
make[1]: Entering directory `/home/yj/git/ocarina/resources/runtime/polyorb-hi-c/examples/aadlv2/ping/ping_local/node_a'
make[1]: Nothing to be done for `generate-asn1-deployment'.
make[1]: Nothing to be done for `target-objects'.
gcc -c -I. -I"/usr/local/include/ocarina/runtime/polyorb-hi-c/include" "-I/home/yj/git/ocarina/resources/runtime/polyorb-hi-c/examples/aadlv2/ping"  -DTARGET=native  -DPOSIX -D_POSIX_SOURCE -D_GNU_SOURCE -D__PO_HI_USE_TRANSPORT -I'/home/yj/git/ocarina/resources/runtime/polyorb-hi-c/examples/aadlv2/ping/' '/home/yj/git/ocarina/resources/runtime/polyorb-hi-c/examples/aadlv2/ping/ping.c' -o ping.o
make[1]: Nothing to be done for `compile-cpp-files'.
make[1]: Nothing to be done for `compile-ada-files'.
for f in po_hi_task.o po_hi_time.o po_hi_protected.o po_hi_main.o po_hi_messages.o po_hi_marshallers.o po_hi_giop.o po_hi_utils.o po_hi_types.o po_hi_monitor.o po_hi_storage.o po_hi_gqueue.o drivers/po_hi_driver_exarm.o drivers/po_hi_driver_keyboard.o drivers/po_hi_driver_exarm_ni_6071e_analog.o drivers/po_hi_driver_exarm_ni_6071e_digital.o drivers/po_hi_driver_usbbrick_spacewire.o drivers/po_hi_driver_linux_serial.o drivers/po_hi_driver_leon_serial.o drivers/po_hi_driver_leon_eth.o drivers/po_hi_driver_serial_common.o drivers/po_hi_driver_sockets.o drivers/po_hi_driver_rtems_ne2000.o drivers/po_hi_driver_rasta_serial.o drivers/po_hi_driver_rasta_common.o drivers/po_hi_driver_rasta_1553.o drivers/po_hi_driver_xc4v_fpga.o drivers/po_hi_driver_rasta_1553_brmlib.o drivers/po_hi_driver_rasta_spacewire.o  po_hi_transport.o ; do \
       c_file="`basename $f .o`.c"; \
       c_file_dirname="`dirname $f`"; \
      if [ -n "$c_file_dirname" ]; then \
         if [ ! -d $c_file_dirname ]; then mkdir -p $c_file_dirname ; fi ; \
          gcc -I. -I"/usr/local/include/ocarina/runtime/polyorb-hi-c/include" "-I/home/yj/git/ocarina/resources/runtime/polyorb-hi-c/examples/aadlv2/ping"  -DTARGET=native  -DPOSIX -D_POSIX_SOURCE -D_GNU_SOURCE -D__PO_HI_USE_TRANSPORT -c -o $f '/usr/local/include/ocarina/runtime/polyorb-hi-c/src/'$c_file_dirname'/'$c_file  || exit 1 ; \
      else \
          gcc -I. -I"/usr/local/include/ocarina/runtime/polyorb-hi-c/include" "-I/home/yj/git/ocarina/resources/runtime/polyorb-hi-c/examples/aadlv2/ping"  -DTARGET=native  -DPOSIX -D_POSIX_SOURCE -D_GNU_SOURCE -D__PO_HI_USE_TRANSPORT -c -o $f '/usr/local/include/ocarina/runtime/polyorb-hi-c/src/'$c_file || exit 1 ; \
      fi ; \
    done
/usr/local/include/ocarina/runtime/polyorb-hi-c/src/./po_hi_transport.c: In function ‘__po_hi_transport_get_model_name’:
/usr/local/include/ocarina/runtime/polyorb-hi-c/src/./po_hi_transport.c:390:14: error: ‘NULL’ undeclared (first use in this function)
       return NULL;
              ^
/usr/local/include/ocarina/runtime/polyorb-hi-c/src/./po_hi_transport.c:390:14: note: each undeclared identifier is reported only once for each function it appears in
/usr/local/include/ocarina/runtime/polyorb-hi-c/src/./po_hi_transport.c: In function ‘__po_hi_transport_get_protocol_configuration’:
/usr/local/include/ocarina/runtime/polyorb-hi-c/src/./po_hi_transport.c:463:11: error: ‘NULL’ undeclared (first use in this function)
    return NULL;
           ^
make[1]: *** [compile-po-hi] Error 1
make[1]: Leaving directory `/home/yj/git/ocarina/resources/runtime/polyorb-hi-c/examples/aadlv2/ping/ping_local/node_a'
make: *** [node_a] Error 2

RTEMS target: configure EXTRA_STACK_SIZE

RTEMS has a macro CONFIGURE_EXTRA_TASK_STACKS that is the extra memory to store stack for ALL threads. We must take advantage of patch implemented in issue OpenAADL/ocarina#59 to properly configure this macro