Giter Site home page Giter Site logo

pathofbuilding's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

pathofbuilding's Issues

[Feature Request] Add buttons for 'patch notes' and 'source project' to the main UI

This is something that might be very usefull in this 'fast fixing/improving' days :D
Just a two small buttons, maybe above/below [Check for Update] button.

Clicking on [Patch Notes] brings up some popup/overlay windows with few (5 or so) latest versions and their notes. Also with a button to the full patchnotes of all versions (when you'll make some, instead on monkey-edditing readme :))
Clicking on [Source Project] will open up your projet's main page in browser.

Rounding issues differing from ingame

There seems to be something different from how the app calculate numbers and the game shows us. Example:

image

image

Same itens, tree, etc, perfectly replicated etc. On this character the DPS calculation is off by just .3, but on a higher level character this difference was about 3K DPS (from 32K to 35K)

You could check how exactly the game calculates the numbers so you can guarantee parity on this

But really, amazing tool. I'm loving it, and the copy-paste support when adding item is something awesome

[Feature Request] Add an ability to copy skill chains

For testing puproses it's sometimes needed to have almost the same skill chains but with 1 or 2 changed gems in setup.
It would be so much QoL if we can just copy (button?) the existing skill chain so we don't need everytime to replace gem, switch 'Calcs' tab, then back to 'Skills' and so on.

Need some clarification (further useful for faq/wiki?)

Can you, please, explain how does exactly 'Mode' switcher works on 'Calcs' tab?
I can see some difference in values under 'attack area' while switching unbuffed/with buffs/effective dps. But what exactly happens, which buffs are counted and so on?

And what happens (should happen) if I manually turn on/off buffs/conditions/other stuff in that column? How does it interact with 'Mode' switcher?

[Feature Request] "Save as..." Feature

When playing around with a build I sometimes change so much in an original build that I want to save the changes as a new build. It would be cool to have a "save as ..." button right next to the "save" button to create a completly new build.

I am currently working around this with the import/export feature, so I guess this is mainly a QOL improvement.

[Feature Request] Item Cabinet

Would it be plausible to have an item stash/cabinet that you can share between builds? That way we don't have to recreate the same items each time we want to plan a build.

[Bug] Serpent Stance not working with Lioneye's Fall and having a bow equipped

Hey there! Thanks for the super fast Lioneye's Fall-fix!

I've got some more coming! ;)
Is this the best format for you for feature requests / bug reports here at github?

As mentioned in the title, Serpent Stance is not counted towards global values while having Lioneye's Fall in the jewel socket and having a bow equipped. Blunt Trauma and the other connector-nodes do work though.

[Feature Requests / Bugs?] Assassin's Mark

Hey!

Thanks again for your awesome work and the "Save as..." Button! ;)

I am playing around with Crit-Builds atm and I am noticing some weird behaviour / missing features with Assassin's Mark.

It seems as if the Increased Critical Strike chance is calculated correctly and is added to the "overview" on the left side of the app as well as under "Calcs". It's missing in the overview though. (see screen)

The "20% increased damage from critical strikes" (I think it's an effective 20% "more" multiplier for the crit multiplier) seems to be completely missing in the calculation of the damage / multiplier. Would be cool if we had these! ;)

assassins_mark

[BUG] Missing some dps and can't figure why (v 1.0.19)

So, I've copied my currently existing character and wanted to do some experiments with its gear/passives.
But it looks that I'm missing 71,38 dps unbuffed (I mean, totally unbuffed in town) for some reason. As I can see - it's not just some element/phys/chaos damage missing, but total mofidier lose somewhere.
PoB DPS
Ingame
Here's my saved profile for it 2.3 Champion Poison LA+Frostwall.zip

Also, worth to mention, that "Inspirational" from champion doesn't count at all. So in h/o I'm missing almost 2k dps.

[BUG] Cannot delete equipped item v 1.0.2

First of all I want to thank you for your job and this amazing tool :) Was missing lots of your features in skill tree planner and forced to use online tools/own math spreadsheets. So, again - thanks a lot!

And now to the bug by steps:

  • in 'Items' tab I've added Kintsugi to my build from bottom import list
    Import list All items
  • equipped it

Equipped items

  • after I realised that my current gear can be copy-pasted from ingame
  • added another kintsugi

All items again

  • now without re-equipping I've tried to delete the first kintsugi in the list
    Delete this
  • pressed 'Delete' button, but nothing happened, it's still in 'All items' list
    No magic

That's all I have for now, will continue with exploring. And, btw, if there's any way to record logs - let me know, so next time I can provide them also.

Crash on first launch if blocked by firewall

Debug:

  • Have your firewall set to block all unknown/new applications from outbound TCP connections.
  • Install the .exe installer of PathOfBuilding and launch it. It will give some error log on green window, not mentioning the connections issues though.
  • Close it and add rule to firewall to allow the application connecting to the internet.
  • Launch the application again.
  • Nothing happens, no action, keep clicking the app shortcut on desktop it just won't do anything, no log, nothing in Task Manager.
  • Rerun installer.
  • Fixed.

Just thought people should know.

Buttons below skill tree do nothing at all

The panel of buttons below the skill tree (Reset, Import etc..) do nothing when pressed. The search field and "Show node power" checkbox are also not interactable.

I am on version 1.0.15, using Windows 7. My screen resolution is 1920x1080, and this issue is present both in a maximized window and in a smaller window.

[Feature Request] Let CoC-Support values just work like a normal support gem

Hey,

I don't think this would be a lot of work, so I am reporting this idea here.
Just to get the damage calculations right, would it be possible to calculate DPS values with the more / increased multipliers from Cast On Critical Strikes? I don't think the calculator needs any fancy stuff for this gem and it could just be treated like Controlled Destruction for example.

Or is it the wording that's causing trouble?

Cheers!

Crash on first run

After the program installed, I tried to run it from the installer. A window popped up with the following:
Windows 7, used the installer exe

SimpleGraphic v1.0 x86 Release, built Aug 30 2016

Executing SimpleGraphic/SimpleGraphic.cfg
Warning: config file not found
Executing SimpleGraphic/SimpleGraphicAuto.cfg
Warning: config file not found
Executing C:\ProgramData\Path of Building\Launch.cfg

--- Render Init ---
Pixel format: need 32,24,0, using 32,24,8
Creating context...
Loading WGL extensions...
using WGL_EXT_swap_control
GL_MAX_TEXTURE_SIZE: 16384
Loading OpenGL extensions...
using GL_EXT_texture_compression_s3tc
using GL_ARB_texture_non_power_of_two
Loading resources...
Renderer initialised in 523 msec.

--- UI Init ---
Script: C:\ProgramData\Path of Building\Launch.lua
Script working directory: C:\ProgramData\Path of Building
Initialising Lua...
Running script...
Saving C:\ProgramData\Path of Building\Launch.cfg

--- Render Shutdown ---
Unloading resources...
Deleting context...
Renderer shutdown complete.
Engine shutdown complete.

--- SCRIPT ERROR ---
Runtime error in 'C:\ProgramData\Path of Building\Launch.lua':
[COULDNT_RESOLVE_HOST] Couldn't resolve host name (6)
stack traceback:
[C]: in function 'perform'
C:\ProgramData\Path of Building\Launch.lua:38: in main chunk

[BUG] Error on copy-paste skill chain

Step by step:

  1. Copy existing chain
    copy
  2. Paste it (guess it's because of 'Enabled' checkbox for the blank line)
    paste
  3. Hit 'Escape' and try to unset 'Enabled' checkbox for the blank line - one more blank line added with 'Enabled' checkbox, error appear again
    error_again

[Feature Request] Add support of Snakebite's poison

I know that you are busy right now with the next major update (btw, how is it going?), but still.
Don't think it's gona be hard, just smth similar to the Consuming Dark effect or that one from Cospri's Will in combine with max frenzy charges turned on on 'Calc's tab.

Builds for other platforms?

Is there any chance to see builds for Linux / OSX?

Or add more information about the project so we can try to build/compile for another targets, not sure. Mostly curious about it.

[BUG] Skills imported multiple times despite the match

Steps:
1 Imported whole profile (tree+jewels and items+skills)
1.1 Saved changes
2 On skills tab I have following skill chain
skill chain
3 Import same profile once again (only items+skills), skill chain duplicated (same gems, same level and quality, same order, same item)
second skill chain

Additional info: character mommysPIZZAMAKER

Guardian node "Radiant Faith" is not correctly adding ES or Armor

Understandably, it seems that the Radiant Faith node has been ignored or overlooked. Currently, allocating it does absolutely nothing.

Here's an import code for a build that easily showcases said issue: https://gist.github.com/efd512b1ea0215f52d425fd1830a0064
Simply import and allocate the Radiant Faith node. Nothing changes.

This is pretty low priority (in my opinion) but if it's a quick fix I would appreciate seeing it dealt with. Thanks for making such a great utility.

[BUG] Shaper's Glove bonuses not working.

The special bonuses like Evasion per Int, Melee Phys per Dex, etc, don't seem to be working.

I'm on a CI tree, so maybe it breaks the bonuses application dues to not being able to receive one of the bonuses ( +1 life per dex)?

[BUG] Application window doesn't show

This happens on my 4-year old Asus laptop with Windows 7. After installation the program works normally for some time, but then, without a pattern I could detect, the application window simply doesn't show up after the initial console window is done loading stuff. The only solution to this problem I have been able to find is to reinstall.

I thought it had something to do with me having an external monitor hooked up to my laptop as that sometimes produces minor issues with games, but this week I've had the monitor hooked up to a different computer and the issue appeared despite it, with only the laptop screen as the sole display.

[Feature Request] Login and Save / Share Builds

I am currently messing with Firebase for a web app and thought maybe you could use their services to implement the mentioned features without too much effort.

Firebase provides the "backend" for (web) applications and has services that all can be called via a REST API:

  • Database
  • CDN for user-assetts
  • Authentication

There are other similar services around but firebase is a free service if your app is pretty small and has fair pricings if your app grows.

This is a big one and I am pretty sure this has already crossed your mind!
But I also think there are some very cool things you could implement with services such as firebase, so I thought I'd just share the idea. ;)

Also I am just curious about your opinion about features like the mentioned ones. Do you maybe also already have similar plans / ideas?

[Feature Request] Add support of Toxic Delivery

There is no change from allocating/unallocating Toxic Delivery right now.
I think this one will be popular very soon because people want to try Assassin + Blade Flurry.
Thanks for the work!

[Feature Request] Jewels passives transformation.

http://i.imgur.com/SMLO8zW.jpg

It's better to add section with new modifiers descriptions under original. Something like this:

30% increased Physical Damage with Maces
40% increased Stun Duration on Enemies
5% increased Radius of Area Skills
----------------------------------------------
30% increased Physical Damage with Bows
40% increased Stun Duration on Enemies
5% increased Radius of Area Skills

Also thanks for awesome tool!

[Feature Request] More Sort-Options for the build list

Hey there!

Here's one for the long term to-do list if it's not on there already:
Make the initial build-list sortable by

  • Name
  • Class / Ascendancy
  • Last edited

Especially "Last edited" would be super handy! ;)
Thank you again for your hard work!

[Feature Request] Allow keyboard navigation

As subj says - allow users to use keyboard navigation and action in lists (like 'All items' on 'Items' page), dropdowns (like 'Main Skill' dropdown on the left bar), popups (delete confirmation window).

[BUG] Attempt to compare number with nil

Stacktrace:

stacktrace

This happens when I hover the mouse through the "Import from" list containing unique items for Weapon 2 slot

Edit: More specifically the Kongming's Stratagem Ivory Spirit Shield

[Feature Request] Flask Slots

Flasks have a large impact on builds, having a way to preview their effects, both defensive (eg. basalt, Taste of Hate, Ruby,) and offensive (eg. Vinktar's, Aztiri's,) would be extremely helpful. Being able to see the impact of flask effectiveness modifiers could also be very useful. Potentially this could work similarly to auras, in that they can be checked as active or inactive.

This is merely showing interest for such a feature, and in no way should be seen as a demand. No hard feelings if the feature never makes it in. Again, thanks for the amazing planner tool.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.