openatbp/openatbp

Open source lobby and game server for Adventure Time Battle Party

openatbp's Issues

Abilities can sometimes break and become unusable for the rest of the match

This issue typically occurs when using an ability just before getting crowd-controlled (usually charmed) or before dying. Sometimes the ability animation plays but that's not always the case. When this happens the ability doesn't go on cooldown visually on the player's HUD.

Dying with a slow permanently reduces your speed

This is likely due to the scheduled effect task ending during the player's death and having a weird interaction.

Lobby server keeps "ghost" players

Sometimes, likely when someone loses connection, the lobby server will not remove their user from the user pool (users array). This should be handled by the "error" and "close" event, but for some reason this is not happening.

Hunson Q, when used fast enough, will cause the projectile to never disappear and cause numerous extension issues

The issue seems to replicate the most when Hunson is also moving while spamming the Q button. One possible fix would be to make all projectiles have unique IDs versus the current playerId + projectile type id.

Leveling "locks" are incorrect. Auto build paths will need to be rewritten

As it has been discovered, the auto leveling path should not let you reach tier 3 until level 5 and tier 4 until level 7. The auto builds on the wiki were incorrect so they will need rewritten as to not break this rule.

RoomHandler seemingly will duplicate in some cases

The RoomHandler, which runs all the background tasks for each game, when duplicated will send conflicting packets to each player causing the game to break in spectacular ways. There are a few fail safes to prevent this but it seems like on rare occasion it is still being bypassed.

One quick fix could be to do an occasional check to make sure that there are no duplicates and completely terminate the game and both RoomHandlers if one exists.

Potentially move away from Dongbat Pathfinding.

The dongbat pathfinding package constantly gives internal index out of bounds errors, comprising of numerous errors likely compromising the game server.

We should look at removing the path finding or trying to supplement the package with something else.

Lobby server not deleting queues after players leave the match after the game ends

If you create a team, leave, and then join queue it will not display any characters in champ select.

After creating a team, if you then leave and rejoin queue and get into a game, it will not display you nor your teammates. However, the lobby server still tracks your choices so it appears to be a client-side issue. Everything is still being sent to the client. I cannot find what is causing the client to not draw the other players.

This effect resets after leaving a game.

Cannot create new users with non-discord authentication