openbudget/budgetkey-app-search

This is the search interface budgetkey app.

budgetkey-app-search's Issues

item page url should include theme identifier

reproduction

• open a themed search app
• click on item

expected

• go to item page in the same theme

actual

• goes to item page in budgetkey theme

[Search] [Exemption] Design and implement exemption item

now returning as exemptions

people - once pressed breaks the search

can't switch tabs and so
@aviklai lets go over it together next week

highlight match in title

build highlight component

search missions for the hackaton

hi all,
starting a list of the missions needed to be done for the search to launch:

1. retrieve all categories from the data packages
   a. now we only have entities, budget & contract-spending - @akariv
   b. what is contract-spending?
   c. make sure that all available fields return in each category
2. review the div design for each category - @mushon
   a. make sure that the design meets the actual fields that return - @mushon & me
3. fill in all the returned fields per category into the divs - me
4. fix infinte scroll - me
   a. when a new batch of results return it is arranged by category - this makes an annoying jump
   b. to do - change the paradigm from if for to for if
5. scroll the results div only and not the entire window - me
6. hierarchy for returned results - @joroizin
   a. think of the order of the returned results and implement it in elastic
   b. for example, first display exact matches then similar...

that's just of the top of my head
i suggest sitting together in the beginning of the hackaton to review and add more tasks
add your own comments and tasks bellow

should support configurable site-wide customizations

An organization wants to visualize part of the budgetkey data in a slightly different way - they should have a way to use the same code-base but with some design / small functional changes

Examples of needed customizations:

• show only part of the data (e.g. only a subset of the tabs / item types)
• re-branding - change colors / design

Implementation should be using environment variables which will be passed to the docker image. So you will be able to use the same docker image to deploy different sites with different customizations.

Redesign Faceted Search

From @mushon on October 12, 2015 17:34

Copied from original issue: OpenBudget/open-budget-frontend#279

Prevent manual importing karma-test-shim library in spec.ts files

After generating components by ng command, manual editing of *.spec.ts file is required for add 'karma-test-shim' library and see the tests passed.

When we start a new project by ng new PROJECT-NAME command everything looks right.

Contact me for more details.

[Search] [Budget] design & implement sparkline

design the new sparkline for budget items - mushon
implement - yonti and sot...

modify theme architecture to match latest budgetkey-app-generic-item changes

see OpenBudget/budgetkey-app-generic-item#31

Search spinner doesn't rotate on Safari

How to reproduce:

1. Search anything using Safari on Mac

If the current spinner is problematic, the spinners at http://fontawesome.io/examples/#animated work well.

budget item children

retrieve all the children per budget item - adam - from elastic
needs the code + type per each child

add to design the child in the bottom footer
תחומים מתקנה זו, פטורים, רכש וכו
ומספר תקנות שכר

Test the Website on Different Browsers

[Search] [Budget Changes] Implement budget change item

returning as 'national-budget-changes'

add hierarchy to items in db

for example:
20 : 'חינוך'
20.43: 'חטיבות ביניים'

[Search] [Supports] Design and implement the governmental support card

Now returning under supports.

time line/ filter

reflect num of results per year
check new design at
https://projects.invisionapp.com/d/main/default/#/console/7587193/253951995/preview

1. should open up on 2017
2. hover- set borders(which are draggable)
3. when the option chosen is last 7/30 days - time line expends - @mushon will create an example for you
4. when range is chosen - a calendar opens up

[Search] [People] Design & implement people card

implement budget-changes

review design

compare the mock-ups to the new search implementations
for now only budget, entities and contract-spending

infinte scroll - fix scroll location when changing groups

assigned to eyal lapid

contract spending multiple similar results for the same provider and the same office

in the contract spending we are multiple similar results for the same provider and the same office.
the items differ by year
we should do something similar to what was done in the budget

@akariv lets review this together monday

[Search] [Procurement] Design cards for the three types of procurement

design three different mock ups

[Search] [Contract Spending] show the entity kind (company, NGO etc.)

The data is in 'entity_kind'.

new design - HP-State-1

working on implementing this new landing page design - https://projects.invisionapp.com/d/main/default/#/console/7587193/247861989/preview

Hacktoberfest

Can we support open source and earn a limited edition T-shirt using this repository? - the link

second query problems

1. counters doesnt always modify
2. fetch on tab change acts weirdly

border bottom

only on after scroll

infinite scroll exemption error + add loading....

exemption is failing - figure out why
add loading in the bottom of the page

[Search] [Performance] Get rid of the 'Loading...' message

What needs to be done to get rid of that annoying delay when loading the site?

I can see that 4 separate css files are being requested via xhr's - perhaps we could load them directly via the html (& also minify them)?

Implement search bar states design

https://projects.invisionapp.com/d/main#/console/7587193/259858886/preview

mobile friendly: Homepage

simplify highlighting

1. update elastic query results - Done
2. update styling
3. remove parse_highlight from elastic.py

[Search] [Design] design broken after highlight was added

fix it without reverting the commit

[Search] [General] Modify URL to reflect current search query

So that copying the link will bring up the same search query

• Don't refresh the page, just update the URL
• Use angular 2 best practices for this (don't reinvent the wheel)
• Make sure query is populated from URL when loading the page
• Make sure that we handle the default case (no search query)
• Remove the default 'education' search

encoded chars in search box after log-out

reproduction

• log-in
• enter a search term in hebrew
• log-out

expected

• go back to homepage, or show the last search

actual

• shows encoded hebrew chars
  

[Search] [Entities] Review new types for entities

review new types for entities

Search doesn't always show results of the latest query

1. type in חינוך quickly
2. you might get results of ״חינו״ instead
3. make a small change (e.g. add a space at the end of the query, or retype the last character)
4. Actual results are received

remove footer

no search box needed

Adding new component containing *.spec.ts crashes the project tests

Adding an empty *.spec.ts file to the .\app folder fail the application tests.
Please help

Thanks,

budget - when there's no history, 'undefined' appears in year range

e.g. search for "שעות תקן תשס"ט 907,927 ש"ש תש"ע 840,087 ש"ש"

Implement new design for search result cards

we got a new design waiting for implementation
here's the link to the mockup:
https://projects.invisionapp.com/d/main/default/#/console/7587193/253951995/preview

there are three object types which need new template design:
1.budget
2.entities
3.other

reach me next meeting and i'll go over it with you
(and grant you invision permissions if it doe'snt work for you)

entities - years/amount messed up

results count in search broke

The results count on the top bar shows a wrong num of results

Contract Spending Transaction (התקשרות) item shows as a Tender Exemption Notice (הודעת פטור)

contract-spending = התקשרות רכש
One government body paying for a service with a specific purchase order

exemption = פטור ממכרז
Notice to the public that someone wants to purchase a service and bypass the tender process.

Different things (but in the same domain)

Budget code appears backwards

(In the search result budget item)

Budget Code 20.43.01 appears as '01.43.20'

Implement autocomplete

Suggest a word when the user is typing.
Use the new autocomplete API.

Should show some loading indication while fetching results

contract spending - use 'entity_name' and 'entity_id'

Prefer to use 'entity_name' and 'entity_id' Instead of 'supplier' and 'supplier_name'.
Only if the first two are empty, fall back to the 'supplier' ones.

stay in place

dont change kinds to all when changing term