open procure: fix tenders and exemptions short status label (4 categories)

[noamoss]

open procure: fix tenders and exemptions short status label (4 categories)

[akariv]

Click on the related tender - it closed 6 months ago. It is definitely not open.
The 'decision' field is 'פורסם וממתין לתוצאות', which for some reason is translated to 'פתוח'...
The 'open' filter works by comparing the claim date (last date to apply) and the current date.

[noamoss]

@akariv Thanks, I admit missing it.

The 'decision' field is 'פורסם וממתין לתוצאות', which for some reason is translated to 'פתוח'...

this is how I understood this label. would you prefer using "עבר תאריך ההגשה"?

[noamoss]

The problem is that it is not marked in the data source as closed... correct me if I am wrong.

[akariv]

No, the data source is correct. The tender is indeed closed, and is waiting for results to be published. The translation table marks this state as being 'open' while it's not.

…

On Wed, Aug 1, 2018 at 9:17 PM noamoss ***@***.***> wrote: The problem is that it is not marked in the data source as closed... correct me if I am wrong. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#124 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAQMdb8oavx4Kd1U5ID4pjuWx4eFofkhks5uMfDQgaJpZM4VqYWl> .

[akariv]

Perhaps we need a distinction between מכרז פתוח - אפשר להגיש מכרז סגור - אי אפשר להגיש מכרז הסתיים - נגמר התהליך מכרז פעיל - קיימות התקשרויות פעילות מהמכרז בכל מקרה ההגדרה של הפילטר ״מכרזים פתוחים״היא מדויקת ומחוברת להגדרה של ״נסגרים בקרוב״. נסגרים בקרוב הם כל אלו שמועד ההגשהשלהם בשבוע הקרוב. ההגיון מחייב שאחרי מועד הסגירה המכרז הופך לסגור...

…

On Wed, Aug 1, 2018 at 9:25 PM Adam Kariv ***@***.***> wrote: No, the data source is correct. The tender is indeed closed, and is waiting for results to be published. The translation table marks this state as being 'open' while it's not. On Wed, Aug 1, 2018 at 9:17 PM noamoss ***@***.***> wrote: > The problem is that it is not marked in the data source as closed... > correct me if I am wrong. > > — > You are receiving this because you were assigned. > > > Reply to this email directly, view it on GitHub > <#124 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAQMdb8oavx4Kd1U5ID4pjuWx4eFofkhks5uMfDQgaJpZM4VqYWl> > . >

[noamoss]

@akariv great, we will stick to that:

מכרז פתוח - אפשר להגיש מכרז סגור - אי אפשר להגיש מכרז הסתיים - נגמר התהליך מכרז פעיל - קיימות התקשרויות פעילות מהמכרז

I will update the table on Monday.

[noamoss]

@akariv

fixed the relevant line the definition line.

adding the פעיל status is problematic due to weird combinations of (like open and active tender, or canceled and active tenders). I don't see a way showing it without confusing the users.

Please review the table before we deploy it, I am not certain about all the changes I made.

[akariv]

Did you also review OpenBudget/BudgetKey#200 and added the missing items?

…

On Mon, Aug 6, 2018 at 1:18 PM noamoss ***@***.***> wrote: Assigned #124 <#124> to @akariv <https://github.com/akariv>. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#124 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAQMdR0-3X-2xyUayP55rE6s8FNSyzGbks5uOBf8gaJpZM4VqYWl> .

[akariv]

Active contracts (which I assume you meant) could be the result of bad Manof refs in the contracts data (which we know is not uncommon).
I would suggest ignoring active contract flags in cases where it doesn't make sense with the tender state.

[noamoss]

@akariv

when writing:

I would suggest ignoring active contract flags in cases where it doesn't make sense with the tender state.

do you mean making any visual change, or just not counting it as active in the search ranking?

[akariv]

Writing here what we discussed in person:
Ignore it in the google spreadsheet.
e.g. if a contract is open and also has active contract (although it shouldn't have those, as it's still open), just assume that these contracts are garbage-matches and not something that needs to be considered.