openbudget/budgetkey-ng2-components

budgetkey-ng2-components's Issues

failure to integrate with budgetkey-app-search

it seems that after the changes in #2 it is not possible to integrate with budgetkey-app-search

the directory structure seems to have changed, which requires changes in the app as well

Asymmetric header

I've decided to make those two issues as one, because those two will cause an asymmetry in the header

1. The "התחברות" button is cropped.
2. The same button is asymmetry to the login button. This happens regardless of the crop issue because the margin-right for the login is 2% and the margin-left for the left button is 5px.
   

I will make a push request to provide an optional solution.

Those issues occur in the latest Chrome/Brave and Firefox on desktop.

Stay safe!

Improve workflow with library

Right now, every change in this library requires deploying to npm to test it.
Modifying the component is cumbersome to test.

We want to find a better workflow for developing this component - possibly with npm link (but not necessarily)

add login / auth to header

TODO

• develop a seaparate component (in a new repository) which will contain the auth / login logic
• integrate this component into the header
• the main use-case for auth at the moment is saved searches

Implementation hints

• https://github.com/datahq/auth
• https://github.com/openspending/os-auth-client/tree/master/src/auth-client/services

hide footer flag not working