opencoconut/coconutphp

PHP client Library for encoding Videos with Coconut

coconutphp's Issues

modernisation of the code

I think you should make a Config class for parameter management that you could extend with an ArrayAccess to have a pseudo toArray().

Then you should put the equivalent of your http client in PSR-7 and PSR-18 so that the implementations / tests etc... are much simpler.

Do you know what I mean?

https://github.com/opencoconut/coconutphp/blob/master/src/Client.php#L14

throw better exceptions

Currently API error codes are included as string at the end of the \Coconut\Error::message property. It would be more convenient to add an api_error_code property on the exception class, so it can easily be inspected to the php code using this library and each error can be handled differently if needed.

Deprecation warning on PHP 8.2

Creation of dynamic property Coconut\Client::$metadata is deprecated in /www/html/vendor/opencoconut/coconut/src/Client.php on line 31

code:

coconutphp/src/Client.php

Lines 29 to 31 in 1491bab

	$this->api = new API($this);
	$this->job = new Job($this);
	$this->metadata = new Metadata($this);

Throw better exceptions for `api_usage_exceeded` error

The coconut API returns a 403 HTTP status code when the usage limit is exceeded. This throws a genericCoconut\Error, which does not provide much information to the php code using this library.

Ideally, the error message and error code would be part of the exception thrown so it can be displayed to the end user, or the exception can be handled differently (for example: retrying the API call after a delay?).

This does not autoload under composer

Unfortunately this does not autoload under composer

$job = Coconut_Job::create($config);

Just comes back with cant find class Coconut_Job

Suggest putting the two classes in separate files and perhaps name space them