openddrmobi/openddr-java

OpenDDR Java Clients

openddr-java's Issues

DeviceAdjuster StringIndexOutOfBoundsException

Hi,

this piece of code throws a StringIndexOutOfBoundsException

Classifier client = new ClassifierBuilder().with(LoaderOption.JAR).build();
Device device = client.classifyDevice("Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_1) AppleWebKit/537.36 (KHTML, like Gecko) Iridium/2018.4 Safari/537.36 Chrome/66.0.3359.130");

The cause lies in the DeviceAdjuster Class - Line 129:

		if (pattern != null) {
			if (pattern.contains(CHROME)) {
				String parts = pattern.substring(pattern.indexOf(CHROME));
				String version = parts.substring(CHROME.length() + 1, parts.indexOf(" "));

the last indexOf(" ") returns -1, as there are no more products in the submitted User-Agent. In my oppinion it should be

parts.indexOf(" ") == -1 ? parts.length() : parts.indexOf(" ")

Create builder via singleton facade (like Enterprise Security)

Currently the ClassifierBuilder has to be instantiated with new. Instead, Classifier could get a static method builder() to create a new ClassifierBuilder.

NPE if URL is not given

OpenDDR Classifier Console null
Exception in thread "main" java.lang.NullPointerException: URL Path cannot be null
at mobi.openddr.classifier.loader.impl.URLResource.(URLResource.java:34)
at mobi.openddr.classifier.loader.LoaderFactory.getLoader(LoaderFactory.java:41)
at mobi.openddr.classifier.Classifier.initDeviceData(Classifier.java:65)
at mobi.openddr.classifier.console.ClassifierConsole.main(ClassifierConsole.java:162)

Update year in header

Make complex types available in client(s)

Currently complex nested types like types in device data are only mentioned but members are not listed. Their detail attributes like tablet etc. should be made visible.

Release 1.3.2

Rename ASPECT_OPERATIVE_SYSTEM

The constant ASPECT_OPERATIVE_SYSTEM and underlying value should be renamed to reflect the change to "operationSystem"

Streamline Classifier Device with data/W3C terms

The Device object of Classifier uses the term "attribute" instead of "property" while the actual device data and W3C Simple API equivalent calls everything a "property".
This should be streamlined to match more naturally with the W3C and OpenDDR data model. "attribute" shall be available deprecated until removed in the next major version (2.0) of the Client APIs.

Replace Bintray/JCenter in Java Clients

• Maven POM and settings.xml, see https://central.sonatype.org/pages/apache-maven.html
• Project Settings: Update CI_DEPLOY_PASSWORD for Sonatype/OSSH

OpenDDRmobi/openddr-parent#2

Fixed BlackBerry OS spelling

See OpenDDRdotORG/OpenDDR-Java#31

Initial codebase

CI instance

Get the clients running on a CI instance
Travis-CI or Circle CI.

Upgrade to Java 8

Upgrade to Java 8, e.g. use Lambdas or maybe Async Loading where appropriate.

Update W3C client for Windows 10

See.:
http://stackoverflow.com/questions/26652394/what-os-name-does-windows-10-set-to-browsers-user-agent
Related to: https://issues.apache.org/jira/browse/DMAP-155

Release 1.3

Update DeviceHints for Windows 10

See.:
http://stackoverflow.com/questions/26652394/what-os-name-does-windows-10-set-to-browsers-user-agent
Related to: https://issues.apache.org/jira/browse/DMAP-155