opendingux/sdl

SDL 1.2 repository with patches for OpenDingux

sdl's Issues

rg99 fails to switch video modes

I've managed to reproduce the error with a very simple program:

#include <stdio.h>

#include <SDL.h>

int main(int argc, char **argv) {
  if (SDL_Init(SDL_INIT_VIDEO) <= -1) {
    printf("%s\n", SDL_GetError());
    return 1;
  }

  for (unsigned i = 1; i <= 100; ++i) {
    printf("Iteration: %u\n", i);

    printf("SDL_SetVideoMode(320, 480, 8, SDL_FULLSCREEN|SDL_HWSURFACE)\n");
    if (SDL_SetVideoMode(320, 480, 8, SDL_FULLSCREEN | SDL_HWSURFACE) == NULL) {
      printf("Failed to switch video modes: %s\n", SDL_GetError());
      return 1;
    }
    SDL_FillRect(SDL_GetVideoSurface(), NULL, 0);
    SDL_Flip(SDL_GetVideoSurface());

    printf("SDL_SetVideoMode(640, 480, 8, SDL_FULLSCREEN|SDL_HWSURFACE)\n");
    if (SDL_SetVideoMode(640, 480, 8, SDL_FULLSCREEN | SDL_HWSURFACE) == NULL) {
      printf("Failed to switch video modes: %s\n", SDL_GetError());
      return 1;
    }
    SDL_FillRect(SDL_GetVideoSurface(), NULL, 0);
    SDL_Flip(SDL_GetVideoSurface());

    SDL_Event event;
    while (SDL_PollEvent(&event)) {
      if (event.type == SDL_QUIT) {
        printf("Force quitting\n");
        return 1;
      }
    }
  }

  printf("Quitting\n");
  SDL_Quit();
  return 0;
}

This takes a few iterations to fail. In a real program that does a lot more (DevilutionX), the failure happens on the 3rd call to SDL_SetVideoMode.

The underlying reason appears to be a DRM memory leak, because when it fails, it is because DRM_IOCTL_MODE_CREATE_DUMB returns:

Dumb framebuffer request failed, Out of memory.