openedx-unsupported/xblock-utils

xblock-utils's Issues

NestedXBlockSpec - add ability to override label

Some blocks might require different human-readable name depending on boilerplate. The simplest approch to allow that is to add an optional parameter label to NestedXBlockSpec constructor so that it would override block's STUDIO_LABEL.

Remove bok-choy usage

This repo's integration tests still use the bok-choy framework, which openedx/public-engineering#13. The bok-choy repository is no longer being maintained, and it will soon be archived.

Once the bok-choy repo is archived, the tests should continue working, as we will not be removing the package's releases from PyPI. For long-term maintainability of this repo, though, the tests should eventually be upgraded to a non-bok-choy testing framework or removed.

StudioContainerWithNestedXBlocksMixin - default css for buttons

StudioContainerWithNestedXBlocksMixin requires descendant block to provide it's own css rules for buttons, so if it gails to do that buttons look like this:

The css rules to avoid that would likely be simple: https://github.com/open-craft/xblock-group-project-v2/blob/master/group_project_v2/public/css/group_project_edit.css#L2-L14

Selenium tests are failing

From the logs here: https://travis-ci.org/edx/xblock-utils/jobs/312058687
There are a bunch of exceptions like these:

Traceback (most recent call last):
  File "/home/travis/build/edx/xblock-utils/xblockutils/base_test.py", line 44, in setUp
    super(SeleniumXBlockTest, self).setUp()
  File "/home/travis/build/edx/xblock-utils/.tox/django18/src/xblock-sdk/workbench/test/selenium_test.py", line 18, in setUp
    super(SeleniumTest, self).setUp()
  File "/home/travis/build/edx/xblock-utils/.tox/django18/lib/python2.7/site-packages/bok_choy/web_app_test.py", line 125, in setUp
    self.driver.set_window_position(0, 0)
  File "/home/travis/build/edx/xblock-utils/.tox/django18/lib/python2.7/site-packages/selenium/webdriver/remote/webdriver.py", line 1010, in set_window_position
    return self.set_window_rect(x=int(x), y=int(y))
  File "/home/travis/build/edx/xblock-utils/.tox/django18/lib/python2.7/site-packages/selenium/webdriver/remote/webdriver.py", line 1061, in set_window_rect
    "height": height})['value']
  File "/home/travis/build/edx/xblock-utils/.tox/django18/lib/python2.7/site-packages/selenium/webdriver/remote/webdriver.py", line 311, in execute
    self.error_handler.check_response(response)
  File "/home/travis/build/edx/xblock-utils/.tox/django18/lib/python2.7/site-packages/selenium/webdriver/remote/errorhandler.py", line 237, in check_response
    raise exception_class(message, screen, stacktrace)
WebDriverException: Message: POST /session/0474914b-e6a3-44f3-b2f2-e9f9e59a30a0/window/rect did not match a known command

I fixed it locally by pinning selenium==3.6, but I haven't submitted a PR since I'm not sure how it should be fixed upstream.

Add AUTHORS file

@antoviaque can you add an AUTHORS file to this repo?

xblock-utils Initial Maintenance

• Github Issues is Enabled
• A catalog-info.yaml file exists
• Dependency Update Automation is Enabled
• A well-formed README exists.

Details and links to how-tos.

Licensing issue

I am wondering why this repository is licensed under AGPLv3 while XBlock is licensed under Apache 2.

Is there any specific reason?

It’s caused an issue on the xblock-officemix repo here.

cc @antoviaque @sarina @mollydb

Fix Failing CI

Currently the test suite does not run successfully out of the box. It looks like there are a few problems.

• You have to manually create a var/workbench.log file in order for the test suite to not fail.
  • This is an artifact of the fact that we're using the workbench.settings file from the xblock-sdk repo which has what looks to be a complex and unnecessary logging config.
• Integration selenium tests are failing and need further investigation.