Comments (5)
@sambapete Ah, gotcha. Thanks for clarifying!
from frontend-app-learning.
@sambapete can you be more specific about which translation was incorrect?
Note: There is no learning.outline.alert.start.long
, but there is a learning.outline.alert.start.short
.
from frontend-app-learning.
That's the problem. In the code, in src/alerts/course-start-alert/CourseStartAlert.jsx, learning.outline.alert.end.long should really be learning.outline.alert.start.long
Line 71 should be learning.outline.alert.start.long instead of learning.outline.alert.end.long. Look at the code, it does not make sense that it would be end.long.
from frontend-app-learning.
Hi @sambapete I was trying to point out that none of the translation json files reference that variable name. For example, see https://github.com/openedx/frontend-app-learning/blob/master/src/i18n/messages/de.json#L9-L10
Check some of the other translation files too. There is a learning.outline.alert.start.short
but there is no learning.outline.alert.start.long
, so you might consider updating your PR to reflect that. #1167
from frontend-app-learning.
Exactly. That's because the id used on line 71 is "wrong". As I said it should be learning.outline.alert.start.long and it does not exist. And if you modify the code, the harvest of strings for Transifex will pick up the new id and add it to the translation files. We're basically saying the same thing.
from frontend-app-learning.
Related Issues (20)
- Untranslatable strings HOT 2
- `PUBLIC_PATH` support is not working anymore after react router v6 upgrade HOT 4
- Use Paragon Tab Component HOT 1
- Loading course home when courses' date is in the future fails HOT 2
- README file broken
- Unenrolling from Course is not working
- Analytic event broken
- Issues with '@edx/frontend-platform/auth'
- Expand All button is not working correctly HOT 1
- Node 20 upgrade
- Bug: Left-sidebar navigation - Sections and subsections being marked as complete when not all units completed HOT 5
- Remove frontend-build patch
- The Unit name in the sidebar doesn't update after publishing a new name HOT 3
- Left-sidebar navigation automatically takes over whole screen when the window is minimized HOT 3
- Sidebar navigation takes over half the width of the page when Indigo theme is used HOT 11
- Sidebar weird behavior when course is not completly live/scheduled HOT 5
- After resetting I can submit again without selecting a new option and it uses the previous submit value HOT 4
- [Bug] Students have access to course content even if the Entrance Exam wasn't finished HOT 4
- Left sidebar navigation breaks rendering of course HOT 1
- As course staff I can see retricted content from group A from the sidebar when masquerading as group B
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from frontend-app-learning.