Comments (11)
@brian-smith-tcril - Thanks for this insight, Brian. Not excited about the result, but this input will help me make some calls. Thank you!
from frontend-app-learning.
FYI @arbrandes @brian-smith-tcril @openedx/2u-infinity, please tag anyone you think can help. Thanks!
from frontend-app-learning.
@GlugovGrGlib - curious about the effort level for this fix? The experience navigating course content in indigo is more clunky with the course content view so narrow (see screenshot above). It's not a release blocker, and because this isn't the default experience, I didn't mark it as high priority, but resolving this ahead of release (if possible) would be a huge win for this feature (I'd prioritize it second in the sidebar bugs - below #1013).
from frontend-app-learning.
@brian-smith-tcril - Curious if it's possible to easily tell if this is a quick and simple fix or maybe something deeper?
from frontend-app-learning.
Considering this is an issue on the indigo theme and not on the Open edX theme, it would need to be addressed there.
Since this is in an MFE, it would need to be addressed in the indigo fork of @openedx/brand
.
The tutor-indigo
plugin installs @edly-io/indigo-brand-openedx
pinned to version ^1.0.0
(see https://github.com/overhangio/tutor-indigo/blob/57ffd11cfc55e4640b224a1f3826a7e9717b8f5f/tutorindigo/plugin.py#L108), meaning the latest 1.x.x
release.
As of writing, that is version 1.4.1
(https://www.npmjs.com/package/@edly-io/indigo-brand-openedx/v/1.4.1?activeTab=versions)
This appears to have been published from the quince/indigo
branch, as https://github.com/edly-io/brand-openedx/releases/tag/indigo-1.4.1 is on commit 0622d6a
, and as of writing that matches the latest commit here https://github.com/edly-io/brand-openedx/tree/quince/indigo
The issue appears to be this line https://github.com/edly-io/brand-openedx/blob/0622d6a6bdf1f5ba84bfaf6cd4d18133a4b3b57d/paragon/_overrides.scss#L14
.container-xl {
max-width: 1090px !important;
With that removed I see
However, simply removing that line will change a lot of things globally. I don't expect that change to be something indigo maintainers would be happy with, and I'm not sure what it would take to address this in a less far-reaching way.
from frontend-app-learning.
Hi @crathbun428 @mariajgrimaldi, we should move this issue to https://github.com/overhangio/tutor-indigo/ repository, so the indigo theme maintainer will address and take decision about theme redesign
from frontend-app-learning.
The new issue was created in the tutor-indigo repository: overhangio/tutor-indigo#83
from frontend-app-learning.
@GlugovGrGlib - Thank you! This makes sense to me. My plan is to figure out if there is an appropriate product contact I can chat with about this issue, too. Thank you for creating this issue in the indigo theme repository.
from frontend-app-learning.
@crathbun428 Good news! Edly just resolved this issue today - overhangio/tutor-indigo#83
You can already see the results on the redwood sandbox environment - https://redwood.demo.edly.io/
![Screenshot 2024-06-10 at 19 30 53](https://private-user-images.githubusercontent.com/22370912/338268800-ec137c53-28d7-46fb-91a8-e4d800c1931a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTgwNTYzMDIsIm5iZiI6MTcxODA1NjAwMiwicGF0aCI6Ii8yMjM3MDkxMi8zMzgyNjg4MDAtZWMxMzdjNTMtMjhkNy00NmZiLTkxYTgtZTRkODAwYzE5MzFhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjEwVDIxNDY0MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTViODliY2VlN2NlOGZlODgyMWE0NzFlODA1Y2NmZjRlMGYwYjBhYTY2MDFkNDU3MDEyNTBkOGIwMTVlMTZiNTImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.DLPOzqu74pU_R8NzOdwOZM1IGYq0LHXbel9F6hGwxQc)
from frontend-app-learning.
Related Issues (20)
- Incorrect id for a message HOT 5
- Upgrade to Paragon design tokens and CSS variables
- Upgrade React JS to v17 HOT 1
- Untranslatable strings
- `PUBLIC_PATH` support is not working anymore after react router v6 upgrade HOT 4
- Use Paragon Tab Component
- Loading course home when courses' date is in the future fails HOT 2
- README file broken
- Unenrolling from Course is not working
- Analytic event broken
- Issues with '@edx/frontend-platform/auth'
- Expand All button is not working correctly HOT 1
- Node 20 upgrade
- Remove frontend-build patch
- Bug: Left-sidebar navigation - Sections and subsections being marked as complete when not all units completed HOT 5
- The Unit name in the sidebar doesn't update after publishing a new name HOT 3
- Left-sidebar navigation automatically takes over whole screen when the window is minimized HOT 2
- Sidebar weird behavior when course is not completly live/scheduled HOT 4
- After resetting I can submit again without selecting a new option and it uses the previous submit value HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from frontend-app-learning.