Giter Site home page Giter Site logo

Comments (11)

crathbun428 avatar crathbun428 commented on July 22, 2024 1

@brian-smith-tcril - Thanks for this insight, Brian. Not excited about the result, but this input will help me make some calls. Thank you!

from frontend-app-learning.

mariajgrimaldi avatar mariajgrimaldi commented on July 22, 2024

FYI @arbrandes @brian-smith-tcril @openedx/2u-infinity, please tag anyone you think can help. Thanks!

from frontend-app-learning.

crathbun428 avatar crathbun428 commented on July 22, 2024

@GlugovGrGlib - curious about the effort level for this fix? The experience navigating course content in indigo is more clunky with the course content view so narrow (see screenshot above). It's not a release blocker, and because this isn't the default experience, I didn't mark it as high priority, but resolving this ahead of release (if possible) would be a huge win for this feature (I'd prioritize it second in the sidebar bugs - below #1013).

from frontend-app-learning.

crathbun428 avatar crathbun428 commented on July 22, 2024

@brian-smith-tcril - Curious if it's possible to easily tell if this is a quick and simple fix or maybe something deeper?

from frontend-app-learning.

brian-smith-tcril avatar brian-smith-tcril commented on July 22, 2024

Considering this is an issue on the indigo theme and not on the Open edX theme, it would need to be addressed there.

Since this is in an MFE, it would need to be addressed in the indigo fork of @openedx/brand.

The tutor-indigo plugin installs @edly-io/indigo-brand-openedx pinned to version ^1.0.0 (see https://github.com/overhangio/tutor-indigo/blob/57ffd11cfc55e4640b224a1f3826a7e9717b8f5f/tutorindigo/plugin.py#L108), meaning the latest 1.x.x release.

As of writing, that is version 1.4.1 (https://www.npmjs.com/package/@edly-io/indigo-brand-openedx/v/1.4.1?activeTab=versions)

This appears to have been published from the quince/indigo branch, as https://github.com/edly-io/brand-openedx/releases/tag/indigo-1.4.1 is on commit 0622d6a, and as of writing that matches the latest commit here https://github.com/edly-io/brand-openedx/tree/quince/indigo

The issue appears to be this line https://github.com/edly-io/brand-openedx/blob/0622d6a6bdf1f5ba84bfaf6cd4d18133a4b3b57d/paragon/_overrides.scss#L14

.container-xl {
    max-width: 1090px !important;

With that removed I see

image

However, simply removing that line will change a lot of things globally. I don't expect that change to be something indigo maintainers would be happy with, and I'm not sure what it would take to address this in a less far-reaching way.

from frontend-app-learning.

GlugovGrGlib avatar GlugovGrGlib commented on July 22, 2024

Hi @crathbun428 @mariajgrimaldi, we should move this issue to https://github.com/overhangio/tutor-indigo/ repository, so the indigo theme maintainer will address and take decision about theme redesign

from frontend-app-learning.

GlugovGrGlib avatar GlugovGrGlib commented on July 22, 2024

The new issue was created in the tutor-indigo repository: overhangio/tutor-indigo#83

from frontend-app-learning.

crathbun428 avatar crathbun428 commented on July 22, 2024

@GlugovGrGlib - Thank you! This makes sense to me. My plan is to figure out if there is an appropriate product contact I can chat with about this issue, too. Thank you for creating this issue in the indigo theme repository.

from frontend-app-learning.

GlugovGrGlib avatar GlugovGrGlib commented on July 22, 2024

@crathbun428 Good news! Edly just resolved this issue today - overhangio/tutor-indigo#83
You can already see the results on the redwood sandbox environment - https://redwood.demo.edly.io/

Screenshot 2024-06-10 at 19 30 53

from frontend-app-learning.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.