openfaas-incubator/node10-express-template

Node.js 10 Express Template for OpenFaaS

node10-express-template's Issues

Serving PNG images

Hi, I was trying to use this template to serve SPA files. I was following the article https://www.openfaas.com/blog/serverless-single-page-app/ . It works well except for images and I suspect for contents such as pdf. I tried modifying the template to use express' sendFile() and setting the right Content-Type and it works with that. However, I was not able to succeed sending files with either end() or pipe(). If there is an alternative without modifying the template, please let me know. Based on the suggestion, I can also make a pull request to correct the issue. Thanks in advance.

Context.fail does not support custom status codes

Expected Behaviour

The following code snippet should return a 501 status code along with the error message.

module.exports = (event, context) => {
    context
        .status(501)
        .fail('An error occurred');
}

Current Behaviour

The snippet is returning the default 500 status code along with the error message.

Possible Solution

Modify the fail method inside index.js to use this.value

fail(value) {
        let message;
        this.cb(this.value, message);
}

Steps to Reproduce (for bugs)

Create a handler that returns the following

module.exports = (event, context) => {
    context
        .status(501)
        .fail('An error occurred');
}

Context

I am trying to create a stateless microservice that returns proper status codes.

Your Environment

faas-cli version: 0.8.3
docker version: 18.09.1
OS: MacOS

event.body is empty when using kafka-connector

I am using kafka-connector to trigger a function but the body is always empty. I set RAW_BODY to true but it is still empty.
Is there another way I can try to solve this issues ?

here is the log of the function request:

{
    "body": {},
    "headers": {
      "host": "transform.openfaas-fn.svc.cluster.local:8080",
      "user-agent": "Go-http-client/1.1",
      "transfer-encoding": "chunked",
      "accept-encoding": "gzip",
      "x-forwarded-for": "10.244.0.193:58756",
      "x-forwarded-host": "gateway.openfaas:8080"
    },
    "method": "POST",
    "query": {},
    "path": "/"
  }
}