openflighthpc/flight-action-api

flight-action-api's Issues

Revert the changes to fix client side bug

This commit only exists to work around a client side bug where python jsonapi-client library does not fully comply with the JSON:API specification.

This can not occur until the following issue has been resolved: #1

Once this has been fixed, the changes in the following commit can be reverted: 9423cbe

Reverting the changes will constitute a breaking change and therefore will need to be accompanied with a major version bump

Support manual editing of application.yaml

The configuration file application.yaml states that it doesn't support manual editing and it may lose any manual changes made. The app also requires the jwt_shared_secret to be set in order to start. The idea is for the environment to provide a jwt_shared_secret environment variable. Whilst this works, it makes using this on an openflight cluster a real pain as there is nowhere sensible to set the shared secret.

The current installations of action-server, a.k.a., flight-action-api have the shared JWT secret added to the script called by flight service start action-api. This is a non-obvious location and isn't used for all invocations of action-server looking at you rake tasks.

We should provide a configuration file where the JWT shared secret can be set. I see no reason that this shouldn't be application.yaml.

Resolve the missing attributes bug

There is a bug in the python json-api client library where it can not parse JSON:API responses without a attributes key: qvantel/jsonapi-client#25

There is a fix for the bug in the pipeline, but development has stalled from mid 2019: qvantel/jsonapi-client#32

The development has stalled due to missing tests on the pull request. Either we should implement the tests and "hopefully" get the library patched.

Or we will need to switch client libraries