Windows libs not getting linked properly for ofxAssimp

[moebiussurfing]

Windows libs not getting linked properly for ofxAssimp

[dimitre]

the function that adds the addon libs folder recursively is now called hardcoded as addonName / "libs".
So it only does its magic inside the addon folder itself.
this function adds recursively all the needed headers and add folders according to platforms and targets.
We can change the projectGenerator functionality to be able to add another recursive folder outside of addon path, something like:
ADDON_ADDITIONAL_LIBS_RECURSIVE
Yeah this name is awful but it is just to remind we should differentiate from ADDON_LIBS
which adds one path per line, non recursive.

[dimitre]

I have a functional PR here, working on windows:
openframeworks/projectGenerator#445
Let's define the name for this new variable

[dimitre]

projectGenerator and addon_config.mk updated
hopefully it will be working tomorrow on nightly

[ofTheo]

@dimitre - I think something like that would be super!

[danoli3]

ADDON_ADDITIONAL_LIBS
lets get it in!

[NickHardeman]

@dimitre having trouble with linking the libs in ofxAssimpModelLoader to ofxAssimp using the Project Generator in VS since it supports Debug and Release. Do you know if there is a way to do separate lib paths for Debug and Release via the add-on config?

[ofTheo]

@NickHardeman - one thought I had with this would be to add a feature to the projectGenerator that would allow you to add paths where it would do the normal processing as if it was in the ofxMyAddon/libs/myLib

So for example for your addon you could do this:
https://github.com/openframeworks/openFrameworks/blob/master/addons/ofxAssimp/addon_config.mk

vs:
	ADDON_LIBS=
	ADDON_LIBS=../ofxAssimpModelLoader/libs/assimp/lib/vs/

And if there was a Debug / Release subfolder it would auto add the correct lib in the project file to the target ( as if it were the libs from the ofxAssimpModelLoader addon ).

[danoli3]

Yeah projectGenerator should be able to find and update it.

I was able to update addonsExample with project generator when adding Debug/Release subfolders from a prior working no subfolders and it figured it out.

[dimitre]

@NickHardeman I'll check in the code right now. Luckly today I have a windows machine to test :)

[dimitre]

PR is ready to merge, which variable name we should use?
cc @danoli3

ADDON_ADDITIONAL_LIBS_RECURSIVE
ADDON_ADDITIONAL_LIBS_FOLDER
ADDON_ADDITIONAL_LIBS

or any other idea

[danoli3]

Just to confirm the ADDON_ADDITIONAL_LIBS found location will also be checked for DLL's

[dimitre]

ok merged!

[dimitre]

@danoli3 yes it is making everything it does for "libs" including dlls. the only function out is adding ".props", but it can be easily added also

[NickHardeman]

@moebiussurfing are you able to test if the latest nightly solves the issue for you?

[moebiussurfing]

@moebiussurfing are you able to test if the latest nightly solves the issue for you?

I tried but the PG.exe does not open now... sometimes it happens here...
i´ll try to reboot soon and retry.

EDIT
I just opened a new issue in the PG repo

[moebiussurfing]

@NickHardeman
nice!
the 3 assimp examples worked perfect creating the project with this PG:
https://github.com/openframeworks/projectGenerator/releases

[moebiussurfing]

straightforward both debug/release without touching anything else