openinf/docker-fisher

🐳 Dockerfiles built for plug-and-play Fish 🐟 shell components powered by the scorching fast Fisher 🔥 plugin manager

docker-fisher's Issues

🏷️✨ rebuilding project & starting afresh

i am going to pin this issue, but we are planning to abandon this project and start anew, so please do not contribute to it any more; it needs to be rebuilt from scratch (as we plan to do)

✨ include additional command in next point release

Feature Request

in contrast to moon, we have been having to write some additional installation SLOCs to add commands on container create; this issue should help determine what commands we'd like to be included.

we should perhaps describe why and for what common uses we'd like to have each included — perhaps one command per-comment below (hopefully should be made for each)…

Pin versions in yum install DOK-W1003

the remaining error failing ci check — Pin versions in yum install DOK-W1003 — is not one we can really consider being an error per se; i do not really think what is expected would be a practical practice, really…

🔗 https://app.deepsource.com/gh/OpenINF/docker-fisher/run/662d6ea0-ea20-4a71-933d-7dd3fd407293/docker/DOK-W1003?listindex=0

we will have to step up our automated dependency management skill first; like w/ commit queue & merge bots landing PRs, until then, we do not really want to deal w/ all those deps constantly changing…

that would force us to keep shipping updates regularly, and then that would become our focus…

Originally posted by @DerekNonGeneric in #28 (comment)

🦞🗳️ openinf/grimesai-salvage-tex:lunar feedback 🏗🐋 prepsubsequent

i can attest to the need for further testing on macOS; i think for 🦞, we seem to have notably forgotten local macOS use case & that devcontainer madness (obv. plan's on improving DX all around […] https://t.co/wzzCRmtOqq

— DerekNonGeneric (@DerekNonGeneric) March 1, 2024

our next version will have dramatically improved;
let's collect all known rough edges in this issue

Re: #56

🐋 building the devcontainer is slow

Building the devcontainer is slow because rbenv install takes forever as it is building ruby from source. We can circumvent this by using rvm. Ideally, we would have an rvm.fish just like we have nvm.fish, but the former does not yet exist. The task at hand is to write one of those in pure fish 3.0, install it using fisher, and install the pre-compiled binary for this platform using it.

🐋 investigate using psusan instead of sshd to remove authentication awkwardness

What we are currently doing regarding SSH daemon setup and its associated scripts in the devcontainer is certainly an inconvenience, quite possibly unnecessary, and warrants further investigation as none of this authentication we are currently requiring of developers is of any use on their local machines.

There appears to be an excessive amount of setup in the route we originally went. Can we do better?

Refs: https://github.com/microsoft/vscode-dev-containers/blob/main/script-library/sshd-debian.sh

This involves more setup: you have to invent an SSH host key for the container, accept it in the client, and deal with it being left behind in your client's host key cache when the container is discarded. And you have to set up some login details in the container: either configure a password, and type it in the client, or copy in the public half of some SSH key you already had. And all this inconvenience is unnecessary, because these are all precautions you need to take when the connection between two systems is going over a hostile network. In this case, it's only going over a kernel IPC channel that's guaranteed to go to the right place, so those safety precautions are redundant, and they only add awkwardness.

Refs: https://manpages.debian.org/unstable/putty-tools/psusan.1.en.html

[feature request] install Chomp in a separate layer

This dependency is sufficiently bulky to warrant doing in the container…

🔗 https://github.com/OpenINF/.github/blob/0625b7106f1b1909209fd72eabdd87e3b4455ed6/.devcontainer/post-create.fish#L50-L59

[meta-bug] follow Snyk best practices

Are we following all of these best-practices?

Refs: https://snyk.io/blog/10-best-practices-to-containerize-nodejs-web-applications-with-docker/
Refs: https://snyk.io/wp-content/uploads/NodeJS-CheatSheet.pdf

[feature request] fish shell script devenv for new fisher plugins

In the original ask, all reqs had yet to be realized, but as i become more familiar w/ the fish ecosystem, i am noticing that it doesn't seem like a separate container image specifically for this task would need to be created.

Our original issue driving this project: #1 could be very minimally extended to also include the dependencies and tooling to carry out fish shell development tasks as well; we will have broadened our horizons (no longer exclusively or primarily Jekyll-oriented, but more of a devenv that would be suitable for typical OpenINF community members day-to-day development, maintenance, and testing activities).

📖 🔥 inconsistent dir name for holding documentation files

🏗️ re-configure @renovate supporting new spiffy labels

🐛 Bug report

Location

.renovaterc.json5

Description

Concise explanation of the problem

we are in the process transitioning out of the old-testament labels situation and @renovate-bot is still currently mis-configured

https://github.com/OpenINF/openinf.github.io/blob/fb0b7346ee7788c1f1bfe4466b7fa5ac9b28bab9/.renovaterc.json5#L28-L42

* [x]  I would like to work on this issue and submit a pull request.

[feature request] install Node.js in a separate layer

Currently, we leave the installation of Node.js up to a post-creation fish shell script, which adds time to the devenv initialization. Let's move that into a new layer here in the dev container. We should have Node.js available out of the box.

[feature request] aggregate common functions into a new shared directory

i don't think we need to keep repeating common functions btwx the scripts in every script; let's pull all the common things together and source them in one go at the top of each script

🏗✨ EditorConfig

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Rate-Limited

These updates are currently rate-limited. Click on a checkbox below to force their creation now.

• chore(deps): update dependency postcss-html to v1.7.0

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update actions/checkout digest to 0ad4b8f
• chore(deps): update returntocorp/semgrep docker digest to 470852e
• chore(deps): update actions/checkout action to v4.1.5
• chore(deps): update babel monorepo to v7.24.5 (@babel/core, @babel/eslint-parser, @babel/preset-env)
• chore(deps): update dependency zx to v8.0.2
• chore(deps): update dependency eslint to v9.2.0
• chore(deps): update dependency retext-equality to v7.1.0
• chore(deps): update pnpm to v9.1.1
• chore(deps): update dependency eslint-plugin-markdown to v5
• chore(deps): update mcr.microsoft.com/vscode/devcontainers/javascript-node docker tag to v1
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

devcontainer

.devcontainer.json

• mcr.microsoft.com/vscode/devcontainers/javascript-node 0-18@sha256:ed57dd8755b4e75a0426bd10ab1d3a60a22bb21fc2e093801375990978c42fb5
• ghcr.io/devcontainers/features/docker-in-docker 2@sha256:23ae11a86089da5f0b98a6edd603f91831802b7f2d5ef1e104e1b94a3beb546c

docker-compose

.devcontainer/docker-compose.yml

dockerfile

.devcontainer/Dockerfile

• centos centos7@sha256:be65f488b7764ad3638f236b7b515b3678369a5124c47b8d32916d6487418ea4

github-actions

.github/workflows/checks.yml

• fkirc/skip-duplicate-actions master
• dorny/paths-filter v3@de90cc6fb38fc0963ad72b210f1f284cd68cea36
• actions/checkout v4@b4ffde65f46336ab88eb53be808477a3936bae11
• actions/setup-node v4@60edb5dd545a775178f52524783378180af0d1f8
• dorny/paths-filter v3@de90cc6fb38fc0963ad72b210f1f284cd68cea36
• actions/checkout v4@b4ffde65f46336ab88eb53be808477a3936bae11
• actions/setup-node v4@60edb5dd545a775178f52524783378180af0d1f8
• actions/checkout v4@b4ffde65f46336ab88eb53be808477a3936bae11
• actions/setup-node v4@60edb5dd545a775178f52524783378180af0d1f8

.github/workflows/semgrep.yml

• actions/checkout v4.1.1@b4ffde65f46336ab88eb53be808477a3936bae11
• returntocorp/semgrep sha256:bacb1190716dab2b1708dc63c5bf11f6014c16511e5117f83592acbc5530087a
• ubuntu 22.04

npm

package.json

• @babel/core 7.24.4
• @babel/eslint-parser 7.24.1
• @babel/plugin-syntax-jsx 7.24.1
• @babel/plugin-syntax-top-level-await 7.14.5
• @babel/preset-env 7.24.4
• @openinf/util-text 1.1.2
• dictionary-en 4.0.0
• eslint 9.0.0
• eslint-config-prettier 9.1.0
• eslint-plugin-json 3.1.0
• eslint-plugin-markdown 4.0.1
• eslint-plugin-prettier 5.1.3
• nps 5.10.0
• postcss 8.4.38
• postcss-html 1.6.0
• prettier 3.2.5
• remark-directive 3.0.0
• remark-frontmatter 5.0.0
• remark-gfm 4.0.0
• remark-github 12.0.0
• remark-heading-id 1.0.1
• remark-hint 1.0.10
• remark-html 16.0.1
• remark-lint 10.0.0
• remark-lint-checkbox-character-style 5.0.0
• remark-lint-checkbox-content-indent 5.0.0
• remark-lint-code-block-style 4.0.0
• remark-lint-definition-spacing 4.0.0
• remark-lint-fenced-code-flag 4.0.0
• remark-lint-first-heading-level 4.0.0
• remark-lint-no-duplicate-headings-in-section 4.0.0
• remark-preset-lint-consistent 6.0.0
• remark-preset-lint-markdown-style-guide 6.0.0
• remark-preset-lint-recommended 7.0.0
• remark-preset-prettier 2.0.1
• remark-retext 6.0.0
• retext-english 5.0.0
• retext-equality 7.0.0
• retext-passive 5.0.0
• retext-profanities 8.0.0
• retext-readability 8.0.0
• retext-repeated-words 5.0.0
• retext-sentence-spacing 6.0.0
• retext-simplify 8.0.0
• retext-spell 6.1.0
• retext-syntax-mentions 4.0.0
• retext-syntax-urls 4.0.0
• strip-comments 2.0.1
• unified 11.0.4
• vnu-jar 23.4.11
• zx 8.0.1
• node ^20.0.0
• pnpm 9.0.6

nvm

.nvmrc

---

• Check this box to trigger a request for Renovate to run again on this repository

🏷️✨ add support for CentOS 7

This probably sounds like a strange request, but where i live, people get certified as Linux Professions experienced w/ this particular distribution and version (CentOS 7) being more important than any others, so the priority is even higher than Debian-based distributions. This is about Enterprise Linux, not really meant to appeal too much to hobbyists and the like.

[feature request] add deps needed by linguist to the image

The reqs listed for Ubuntu are as follow:

• build-essential
• cmake
• pkg-config
• libicu-dev
• zlib1g-dev
• libcurl4-openssl-dev
• libssl-dev
• ruby-dev

Some (most?) of these we have already been installing. However, for ruby-dev, it seems like we should be able to use the one we ordinarily install using a Ruby Version Manager, so it might be able to be excluded from installation.

Refs: https://github.com/github/linguist/blob/HEAD/README.md#dependencies

⚖️ properly license project as determined by contribution guidelines

We are going to tackle OpenINF/.github#642 and the result of that effort should be implemented here as well.

[feature request] publish our ruby fish shell on docker hub

The ruby fish shell docker dev environment that we are using in the openinf/openinf.github.io repository should probably be sharable and available for use elsewhere and between projects. It might be a bit too heavy for our 6 commonjs package repos, though, since they seem like they won't be needing much more than our Node.js Gallium runtime and toolchain to get everything built and taken care of…

/cc @jorgebucaran as i have no experience w/ publishing to docker hub :/

🐋🔥 address local devenv's current FUBAR status

🐛 Bug report

Location

Section of the site codebase where the content SLOCs exist

• 📁 https://github.com/OpenINF/openinf.github.io/tree/live/.devcontainer

Description

Concise explanation of the problem

local dev container has gone AWOL.
it's a known issue (amongst us paying attention) that:
the docker image(s) we had been developing and publishing (as an org)
mainly for projects' docker devcontainers unpublished from the docker hub registry

literally nobody is happy about this (me neither); it's tragic and even somewhat comical:
i really do appreciate now even starting to get nudged by fellow developers
within big tech companies who somewhat expect continuity puting out some offical-ish
souped-up scorching fast Fisher-based Docker devcontainer as we initially set out to do via
OpenINF/docker-fisher w/ Jorge as basically reigning champion of the fish shell ecosystem
and notably somewhat Fish-famous

---

• I would like to work on this issue and submit a pull request.

🦇✨ add bat command

we should add the bat utility to the container

🔗 https://github.com/sharkdp/bat?tab=readme-ov-file#on-ubuntu-using-apt

If your Ubuntu/Debian installation is new enough you can simply run:

sudo apt install bat