opening-hours/opening_hours_map

Map which evaluates opening_hours related tags.

opening_hours_map's Issues

http://openingh.openstreetmap.de/ continues to be offline

Make it possible to change the time to check

Filters should add current Position of the Map

Steps to reproduce:

• open http://openingh.openstreetmap.de/
• move/zoom/scroll the Map
• click on "only errors"

Map is reloaded on standard-position

allow filtering based on osm-key/value parameters

Based on #36

Could you add an option to filter by osm key/value (and key/value set combination).

For example: if somebody want to see only the opening status of italian restaurants (amenity=restaurant +cuisine=italian).

Or is this already available (on https://openingh.ypid.de or somewhere else)?

render in state order (green - yellow - red)

In area with multiple objects it would be helpful to render open ones on top. In some case these may be well hidden.

Not sure what should be done with broken data (purple circles).

http://openingh.openstreetmap.de/?zoom=15&lat=50.08109&lon=19.88797&layers=B0T&filter=none&tags=opening_hours

barrier should have higher priority than operator in naming things

http://www.openstreetmap.org/way/253094249

expected name: tool booth (from barrier key)
displayed name: Fundacja "Miejski Park i Ogród Zoologiczny w Krakowie" (from operator key)

untranslated message on low zoom levels "Die Marker werden erst auf Zoom Stufe 11 geladen. Aktuelle Zoom Stufe ist 10"

use cuisine for displaying name

I would expect that

amenity = fast_food
cuisine = kebab

would be titled "kebab" or at least "fast food - kebab". Currently it is titled fast_food

example: http://www.openstreetmap.org/node/2855481627
maplink: http://openingh.openstreetmap.de/?zoom=18&lat=50.06747&lon=19.91414&layers=B0T&tags=opening_hours

Opening hours one hour off due to DST change

Status (green/red circle) on the map is shown correctly, however in POI's details, opening hours are moved by one hour (see example). I observed the same situation in October.

stray "and" in "prettified and opening_hours value (this value can be safely used in OSM, after all warnings have been solved):"

translation problems "(listopada|listopad)" in pl version

https://www.openstreetmap.org/node/2554310978 viewed in http://ypid.de/~osm/?zoom=16&lat=50.07983&lon=19.88411&layers=B0T&tags=opening_hours using browser requesting pl version results in

but will close today, 20 (listopada|listopad), in 34 minutes.

(listopada|listopad)

is bad

listopada

would be good

listopad

would be generally worse, but even that would be better that (listopada|listopad)

JOSM-QAT no connection

On click on download in qat i get: "Die Internetverbindung funktioniert nicht"
Osmi, Keepright and Osmose works fine.

Josm 8800+java8+win7

mention dependencies

After using make dependencies-get make ready-for-hosting resulted in (among others)

/bin/bash: jq: command not found and /bin/bash: bower: command not found

Hand location over to demo page when clicking on „Test opening_hours“

collection times is not parsing right

• go to: http://openingh.openstreetmap.de/?zoom=16&lat=50.10189&lon=8.68158&layers=B0&filter=none
• switch to collection times

pulls some Bugs:

1. check is for opening_hours (most errors show "defect" time ranges)
2. permalink gets "&tags=collection_times" but http://openingh.openstreetmap.de/?zoom=16&lat=50.10189&lon=8.68158&layers=B0T&filter=none&tags=collection_times shows opening_hours

overpass-api changes pulls a 400 bad request

german diskussion about: http://forum.openstreetmap.org/viewtopic.php?id=26073

Public holidays bug on web

opening-hours/opening_hours.js#73

use craft tag for displaying name

for example http://www.openstreetmap.org/node/2554310978

shop tag is already used

http://taginfo.openstreetmap.org/keys/craft#overview

untranslated in English version "Alle 6 Einträge:"

allow filtering open, closed, unknown, buggy

Often the status is not interesting, but i want to know, where the syntax is not valid so i can fix the osm data.

add check for JS enabled

if i (or somewhere with less knowledge) go to the website with JS disabled i got no message.
But there should be one :)

Display of location info in more narrow when screen is not being moved

Firefox 24.1.1.

Open details of location, click left button of mouse on the map and grab - map is being moved and location info screen is wider. At least in my case it should not get more narrow once I stop moving map.

add link to this github project

Does not evaluate opening_hours attached to OSM ways

I changed the query but still no OSM ways …

opening_hours on a fine multipolygon are not appearing

https://www.openstreetmap.org/relation/4121283#map=16/50.0991/19.9825 is tagged but it is not appearing on http://ypid.de/~osm/?zoom=15&lat=50.09999&lon=19.98186&layers=B0T&tags=opening_hours&filter=none

add option to generate list of objects on the map

I would consider useful to have ability to expot opening hours currently visible on the map to a text-only list.

It would allow to export opening hour data to non-interactive format (main benefit is that it would be printable).

it is likely to be considered to be feature creep - in that case just close it and I will keep code in my own small fork

Wrong suggestion in popup?

Schön formatierter opening_hours Wert [...]:
Mo 09:00-12:00 Tu-Fr 09:00-12:00,15:00-17:00

There is missing an semicolon.

Found at http://openingh.openstreetmap.de/?filter=error&zoom=15&lat=50.77067&lon=12.97856&layers=B0T&tags=opening_hours

"minute" instead of "minutes"

Facility is now open

but will close today, 28 February, in 2 hours and 41 minute.

at http://www.openstreetmap.org/node/2665119605

Link: "josm" or "load all in josm" has no function

in the error popup the links:
"josm" or "load all in josm"
doesnt work anymore (tested in SM,FF,OP,CHR)

Konsole says:
Zeitstempel: 30.08.2014 13:00:05
Fehler: TypeError: top.hiddenframe is undefined
Quelldatei: http://openingh.openstreetmap.de/opening_hours.js/js/helpers.js
Zeile: 6

Have unchecked "https" in josm, doesnt work too.

Tested on http://openingh.openstreetmap.de/?filter=error&zoom=18&lat=50.97925&lon=11.31804&layers=B0T&tags=opening_hours (http://www.openstreetmap.org/way/198003939) and some other in the near.

make links active, which starts with "www" (maybe similar to ticket #226 at opening-hours/opening_hours.js)

Hi all,

I discovered links which starts with "www" (without http or https) for website=www.xxx.xxx and contact:website=www.xxx.xxx are not working.

An example node you can find be running this query:
http://overpass-turbo.eu/s/qbb
http://www.openstreetmap.org/node/2380903579

Viewing the example node using http://openingh.openstreetmap.de looks like:
http://openingh.openstreetmap.de/?zoom=18&lat=50.73593&lon=7.09889&layers=B0T&filter=none&tags=opening_hours
See also picture below: [1]

Maybe this behavior is similar to ticket:
opening-hours/opening_hours.js#226

Thank you & regards
MN

[1]

allow filtering

especially in regions with high density of opening hours one may prefer to ignore some classes of objects.

Would it be welcomed to make PR that would allow to specify in URL parameter allowing to add filter to the overpass query?

Check for am and pm

Example:
"7am-5pm" generates: "07:00-05:00" but should be: "07:00-17:00"

MKnight

Typo

" Alle in JSOM laden"

In demo copyright information about OSM data is missing

see http://www.openstreetmap.org/copyright

Deutsch title diplayed by browser - rest of interface is in English (demo)

Rewrite UI …

• Don’t use document.write …
• Use framework
• Integrate Nominatim search
• Show loading icon for overpass query

partially translated content for browser requesting content in Polish

see any POI:

but will close tomorrow, 19 wrzesień, in 17 hour and 52 minute.

but will close tomorrow - in English
wrzesień - in Polish
hour - in English
minute - in German (?)

Interface, except dates is in English

As there is no available translation entire content should be in English.

Show note when the current day is PH and no PH is specified in value

nonenglish comments

for example in main.js there are:

https://github.com/opening-hours/opening_hours_map/blob/master/js/main.js#L520
https://github.com/opening-hours/opening_hours_map/blob/master/js/main.js#L299
https://github.com/opening-hours/opening_hours_map/blob/master/js/main.js#L287
https://github.com/opening-hours/opening_hours_map/blob/master/js/main.js#L280
https://github.com/opening-hours/opening_hours_map/blob/master/js/main.js#L130
https://github.com/opening-hours/opening_hours_map/blob/master/js/main.js#L114
https://github.com/opening-hours/opening_hours_map/blob/master/js/main.js#L109

Add "real" "load all errors in JOSM"

The function "load all in Josm" should load all visible Errors in JOSM, not only duplicates of the complete Key like now:
javascript:josm('import?url=http%3A%2F%2Foverpass-api.de%2F api%2Fxapi_meta%3F*%5Bopening_hours %3DMo%209.00%20-12.00%20Uhr%20Di%20-%20 Fr%209.00%20-12.00%20und%2015.00%20-17.00%20Uhr%5D')

mirror is down

A mirror is setup up under: http://ypid.de/~osm/

It is currently not working. Main site is working.

recalculate time to closing/opening

Currently once popup is created time to closing/opening stays the same. To recalculate it user must reload page and click again selected place.

It would be preferable to recalculate time till state change every 60 seconds.

https://github.com/openlayers/openlayers/releases/download/release-2.13.1/OpenLayers-2.13.1.tar.gz is gone [PR is waiting]

https://github.com/openlayers/openlayers/releases/download/release-2.13.1/OpenLayers-2.13.1.tar.gz gives for me 404 Github page also in the browser.

As result make dependencies-get mentioned in the readme is failing.

mateusz@Grisznak:~/Desktop/tmp/opening_hours_map$ make dependencies-get
wget --no-clobber -O js/OpenLayers-2.13.1.tar.gz https://github.com/openlayers/openlayers/releases/download/release-2.13.1/OpenLayers-2.13.1.tar.gz
--2017-05-15 07:46:43--  https://github.com/openlayers/openlayers/releases/download/release-2.13.1/OpenLayers-2.13.1.tar.gz
Resolving github.com (github.com)... 192.30.253.112, 192.30.253.113
Connecting to github.com (github.com)|192.30.253.112|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2017-05-15 07:46:43 ERROR 404: Not Found.

make: [js/OpenLayers-2.13.1/OpenLayers.js] Error 8 (ignored)
tar -xzf js/OpenLayers-2.13.1.tar.gz -C js/

gzip: stdin: unexpected end of file
tar: Child returned status 1
tar: Error is not recoverable: exiting now
make: *** [js/OpenLayers-2.13.1/OpenLayers.js] Error 2

create redirect at http://robin.de.marissa.hostorama.ch/osm/opening_hours_map/opening_hours_map.html

Is it possible to redirect to a new adress rather than throw cryptic 404?

Be even more newbie friendly in "helpful warning in case `git verify-commit` fails"

I reached https://www.gnupg.org/gph/en/manual/x457.html (after some googling).

I am still not entirely sure how to find key ID (is it 489A4D5EC353C98A from using RSA key 489A4D5EC353C98A?')

Anyway, maybe add also explicit command necessary to obtain public key?

My attempt ended with

mateusz@Grisznak:~/Desktop/tmp/opening_hours_map$ gpg --keyserver certserver.pgp.com --recv-key 489A4D5EC353C98A
gpg: requesting key C353C98A from hkp server certserver.pgp.com
gpg: keyserver timed out
gpg: keyserver receive failed: keyserver error

(is documentation that I found so old that examples mention dead servers)

next one went better

mateusz@Grisznak:~/Desktop/tmp/opening_hours_map$ gpg --keyserver pool.sks-keyservers.net --recv-key 489A4D5EC353C98A
gpg: requesting key C353C98A from hkp server pool.sks-keyservers.net
gpg: key C353C98A: public key "Robin Schneider (Automatic Signing Key) <[email protected]>" imported
gpg: 3 marginal(s) needed, 1 complete(s) needed, PGP trust model
gpg: depth: 0  valid:   1  signed:   0  trust: 0-, 0q, 0n, 0m, 0f, 1u
gpg: next trustdb check due at 2017-05-26
gpg: Total number processed: 1
gpg:               imported: 1  (RSA: 1)

but I am not entirely sure whatever I used safe keyserver and which one, if any would be better.

gpg: WARNING: This key is not certified with a trusted signature!
gpg:          There is no indication that the signature belongs to the owner.

On make dependencies-get seems to indicate that I should use other keyserver.

(that is from person that I roughly aware how public key cryptography works and never interacted with gpg beyond what is exposed by add-apt-repository)

missing make clean

as result of #46 I downloaded malformed file (404 response) and ended with 0 byte files in opening_hours_map/js/OpenLayers-2.13.1.tar.gz.

As result make dependencies-get is crashing.

mateusz@Grisznak:~/Desktop/tmp/opening_hours_map$ make dependencies-get
wget --no-clobber -O js/OpenLayers-2.13.1.tar.gz https://github.com/openlayers/ol2/releases/download/release-2.13.1/OpenLayers-2.13.1.tar.gz
File `js/OpenLayers-2.13.1.tar.gz' already there; not retrieving.
make: [js/OpenLayers-2.13.1/OpenLayers.js] Error 1 (ignored)
tar -xzf js/OpenLayers-2.13.1.tar.gz -C js/

gzip: stdin: unexpected end of file
tar: Child returned status 1
tar: Error is not recoverable: exiting now
make: *** [js/OpenLayers-2.13.1/OpenLayers.js] Error 2

I expected make clean to fix this but it does not exists.

Die zugrundeliegenden Daten stammen von der Overpass API.

Die zugrundeliegenden Daten stammen von der Overpass API.

Keine Idee grad, wie man das schöner formulieren könnte, aber SO ist das imho nicht richtig, da die Daten von OSM via Overpass-api kommen.
In der englischen Variante ist es ähnlich "falsch".

Give some feedback on failure of 'git verify-commit HEAD'

I guess that git verify-commit check in dependencies-get guards against potential MITM attacks that potentially would lead to execution of arbitrary code.

Butt is not at all clear what one is supposed to do in case of errors like

mateusz@Grisznak:~/Desktop/tmp/opening_hours_map$ make dependencies-get 
git submodule update --init
cd opening_hours.js/ && git verify-commit HEAD && git submodule update --init --recursive
gpg: Signature made nie, 19 mar 2017, 23:08:19 CET
gpg:                using RSA key 489A4D5EC353C98A
gpg: Can't check signature: public key not found
make: *** [dependencies-get] Error 1

(in my case I simply edited makefile to get rid of that check)

Position location if wanted (on button click)

Requested in the OSM Forum

URL with "filter=errorOnly" (permalink-problem?) doesnt work correctly

Steps to reproduce:

• Goto somewhere like here: http://openingh.openstreetmap.de/?zoom=18&lat=48.19384&lon=16.35112&layers=B0T&filter=none&tags=opening_hours
• click Checkbox: Errors only
• Click Permalink, you got: http://openingh.openstreetmap.de/?zoom=18&lat=48.19395&lon=16.35118&layers=B0T&filter=errorOnly&tags=opening_hours
• filter "errors" doesnt work on the Map nor in the checkboxes

Deutsch:
Wenn ich ich die Checkbox "Nur Fehler" auswähle und auf den Permalink klicke bekomme ich zwar eine scheinbar korrekte URL mit &filter=errorOnly aber weder ist danach diе checkbox ausgewählt noch weiss die Karte etwas davon.