openmensa / openmensa Goto Github PK

View Code? Open in Web Editor NEW

71.0 71.0 9.0 3.78 MB

Central hub for canteen information (meals, location ...)

Home Page: https://openmensa.org

License: GNU Affero General Public License v3.0

Ruby 77.59% HTML 1.08% JavaScript 1.27% SCSS 7.25% Sass 0.08% Slim 12.00% Shell 0.16% Dockerfile 0.54% Makefile 0.02%

canteen meals openmensa ruby

openmensa's Introduction

OpenMensa - Die offene Mensa Datenbank

OpenMensa is a free database for canteens. We act as a central exchange for all canteen relevant information, such as canteen list, canteen position and meal menus.

We provide a standardized format to access and provide this information. This reduces the workload for a canteen provider to make their meal menus available on different end points (website, android, iOS ...).

We are currently focused on Germany but are interested to open to other countries.

Getting started

install needed gems
```
bundle install
```
Run test suite
```
bundle exec rspec
```

Contributing

Fork it
Create your feature branch (git checkout -b my-new-feature)
Add specs for your feature
Implement your feature
Commit your changes (git commit -am 'Add some feature')
Push to the branch (git push origin my-new-feature)
Create new Pull Request

License

AGPLv3 License

openmensa's People

Contributors

Stargazers

Watchers

Forkers

nikriek gregoor chk1 knorpelsenf neothethird lukashass leptopoda shimada-toy-box tomkoenecke

openmensa's Issues

Using vulnerable versions of Rails and dependencies

Our current deployment is vulnerable against the following CVEs:

CVE-2016-6316
CVE-2016-6317
Upgrading Rails to something above or equal 4.2.7.1 should solve this.

N+1 Query: SELECT "notes".* FROM "notes" INNER JOIN "meals_notes" ON "notes"."id" = "meals_notes"."note_id" WHERE "meals_notes"."meal_id" = $1

Sentry Issue: OPENMENSA-1Q


Transaction Name	db - SELECT "notes".* FROM "notes" INNER JOIN "...
Parent Span	no value
Repeating Spans (8)	db.sql.active_record - SELECT "notes".* FROM "n...

feed messages table is distorted

On a canteen you can click on the letter ✉ symbol of a feed to see the status of the recent fetches. e.g. https://openmensa.org/feeds/1785/messages

There is a problem with the table on that page:

The HTML of the table looks like this:

<tr>
    <td rowspan="0">+ 1 i class=(reason_map[fetch.reason]) title=t(:feed_fetch, :reasons, fetch.reason)</td>
    <td>17. April, 10:06 Uhr</td>
    <td>Veränderung</td>
    <td class="number">0</td>
    <td class="number">0</td>
    <td class="number">2</td>
    <td class="number">0</td>
    <td class="number">1</td>
</tr>
<tr>
    <td rowspan="0">+ 1 i class=(reason_map[fetch.reason]) title=t(:feed_fetch, :reasons, fetch.reason)</td>
    <td>17. April, 09:00 Uhr</td>
    <td>Keine Veränderung</td>
    <td class="number">0</td>
    <td class="number">0</td>
    <td class="number">0</td>
    <td class="number">0</td>
    <td class="number">0</td>
</tr>
...

Seems to be this file:

openmensa/app/views/feeds/messages.html.slim

Lines 30 to 31 in 42a783f

    
           td rowspan=fetch.messages.size + 1 
        
             i class=(reason_map[fetch.reason]) title=t(:feed_fetch, :reasons, fetch.reason)

Add field for allergy information and other restriction labels

Many visitors of canteens rely on allergy information and labels for vegetarian or vegan food for ethical reasons as well as other restrictions based on faith. If this would be added in a machine-readable way, applications could allow for filtering based on certain dietary restrictions.

Feeds from my parser are not fetched daily.

I wrote a parser for some canteens from the Heidelberg Studierendenwerk and so far everything seemed to be working fine.
But today I noticed that neither the "today" nor the "full" feed are fetched on a daily basis.

An example:
http://openmensa.org/c/277/
It says there:

Feed "today"
Letzte Abruf: vor 10 Stunden
Nächster Abruf: -
Feed "full"
Letzte Veränderung: 04.05.2016
Letzte Abruf: 05.05.2016
Nächster Abruf: -

(I manually updated the "today" feed 10 hours ago)
So why is there no date for "Nächster Abruf"? Is there a setting for automatic fetching that I missed?

Mensa FH Erfurt is not working for Friday

Dear devs at openmensa,

will testing openmensa.org i noticed there is no menu for today:
http://openmensa.org/api/v2/canteens/148/days/2015-10-30/meals
but if u open the other plan on web, there is a menu
http://www.stw-thueringen.de/deutsch/mensen/einrichtungen/erfurt/mensa-altonaer-strasse.html

Hope to see soon some food :D

best regards,
Christoph J.

Anmelden no longer works

Not sure whether it's just me but I don't see a way to log in anymore.

Feature: Group a meal's notes

A meal's notes could support optional groups.

Example

API

{
  "id": 260,
  "name": "Gemüse-Couscouspfanne mit Joghurt-Ingwer-Dip, dazu bunter Blattsalat",
  "notes": [
    "mensaVital"
  ],
  "notegroups": {
    "additives": [
      "Milch",
      "Gluten",
      "Farbstoff"
    ],
    "nutritional-information": [
      "Brennwert = 2144 kJ (512 kcal)",
      "Fett = 13,1g",
      "Kohlenhydrate = 70,6g",
      "Eiweiß = 19,6g"
    ]
  },
  "prices": {
    "student": 2.3,
    "employee": 3.65,
    "other": 4.6
  },
  "category": "Alternativ-Angebot"
}

Feed

<meal>
    <name>Gemüse-Couscouspfanne mit Joghurt-Ingwer-Dip, dazu bunter Blattsalat</name>
    <note>mensaVital</note>
    <note>vegetarisch</note>
    <notegroup name="additives">
        <note>Milch</note>
        <note>Gluten</note>
        <note>Farbstoff</note>
    </notegroup>
    <notegroup name="nutritional-information">
        <note>Brennwert = 2144 kJ (512 kcal)</note>
        <note>Fett = 13,1g</note>
        <note>Kohlenhydrate = 70,6g</note>
        <note>Eiweiß = 19,6g"</note>
    </notegroup>
    <price role="student">2.30</price>
    <price role="employee">3.65</price>
    <price role=other>4.60</price>
</meal>

This would be backwards-compatible, but allow for tydier notes.

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Awaiting Schedule

These updates are awaiting their schedule. Click on a checkbox to get an update now.

Detected dependencies

bundler

Gemfile

ruby ~> 3.3.0

rails "~> 7.1.0"

rails-i18n "~> 7.0"

jsbundling-rails undefined

propshaft undefined

rails-assets-manifest undefined

puma "~> 6.0"

bcrypt undefined

good_job "~> 4.0"

oj undefined

pg "~> 1.2"

slim "~> 5.0"

cancancan "~> 3.2"

omniauth "~> 2.0"

omniauth-facebook undefined

omniauth-github undefined

omniauth-google-oauth2 undefined

omniauth-oauth2 undefined

omniauth-rails_csrf_protection "~> 1.0"

omniauth-twitter undefined

parse-cron undefined

rack-cors undefined

geocoder "~> 1.6"

gravtastic undefined

rails-timeago undefined

simple_form undefined

api-responder undefined

decorate-responder "~> 2.1"

draper "~> 4.0"

has_scope "~> 0.8.0"

paginate-responder "~> 2.0"

responders undefined

will_paginate undefined

sentry-rails undefined

sentry-ruby undefined

stackprof undefined

telegraf undefined

brakeman undefined

listen undefined

spring undefined

spring-commands-rspec undefined

squasher undefined

rubocop "~> 1.65.0"

rubocop-capybara "~> 2.21.0"

rubocop-factory_bot "~> 2.26.0"

rubocop-performance "~> 1.21.0"

rubocop-rails "~> 2.25.0"

rubocop-rspec "~> 2.31.0"

pry undefined

pry-byebug undefined

rspec-collection_matchers undefined

rspec-its undefined

rspec-rails "6.1.4"

capybara "~> 3.35"

capybara-email "~> 3.0"

cuprite "~> 0.13"

factory_bot_rails "~> 6.1"

rails-controller-testing undefined

timecop undefined

webmock undefined

simplecov undefined

simplecov-cobertura undefined

docker-compose

docker-compose.yml

postgres 16-alpine

nginx 1.27-alpine

dockerfile

Dockerfile

docker/dockerfile 1.9

docker.io/node 22-slim

docker.io/ruby 3.3.4-slim-bullseye

docker.io/ruby 3.3.4-slim-bullseye

github-actions

.github/workflows/docs.yml

actions/checkout v4

actions/setup-python v5

actions/upload-pages-artifact v3

actions/deploy-pages v4

ubuntu 22.04

ubuntu 22.04

.github/workflows/test.yml

actions/checkout v4

actions/setup-node v4

ruby/setup-ruby v1

codecov/codecov-action v4

actions/checkout v4

ruby/setup-ruby v1

actions/checkout v4

actions/setup-node v4

actions/checkout v4

docker/setup-buildx-action v3

docker/login-action v3

docker/metadata-action v5

docker/build-push-action v6

actions/checkout v4

postgres 16-alpine

ubuntu 22.04

ubuntu 22.04

ubuntu 22.04

ubuntu 22.04

ubuntu 22.04

npm

package.json

@fortawesome/fontawesome-free ^6.5.2

@rails/ujs ^7.1.3-2

bourbon ^7.3.0

jquery ^3.7.1

jquery.autocomplete ^1.2.0

leaflet ^1.9.4

leaflet-hash ^0.2.1

leaflet.locatecontrol ^0.81.0

leaflet.markercluster ^1.5.3

@gfx/zopfli ^1.0.15

@rsbuild/core ^0.7.0

@rspack/cli ^0.7.0

@rspack/core ^0.7.0

compression-webpack-plugin ^11.1.0

husky ^8.0.3

lint-staged ^15.0.0

prettier ^3.0.0

rspack-manifest-plugin ^5.0.0

sass-embedded ^1.76.0

sass-loader ^14.2.1

node >= 20

yarn 4.3.1

yarn 4.3.1

pipenv

Pipfile

mkdocs-material ~=9.5.2

mkdocs-git-revision-date-plugin ~=0.3.2

mdx-truly-sane-lists ~=1.2

mkdocs-awesome-pages-plugin ~=2.9.0

ruby-version

.ruby-version

ruby 3.3.4

Check this box to trigger a request for Renovate to run again on this repository

GET / redirects to /menu

When manually open https://openmensa.org/ (already logged in) I get redirect to /menu. But not when clicking the header link.

@mswart Is this redirect intended?

New Hamburg parser

@jgraichen

The Hamburg parser from https://github.com/mswart/openmensa-parsers/ is broken.

Since the mswart/openmensa-parsers repository is not maintained and the website of Hamburg has changed significantly, I decided to write a new parser for Hamburg and host it on my own repository: https://github.com/cvzi/mensahd (https://cvzi.github.io/mensahd/hamburg.json)
I added it as a new parser to openmensa (https://openmensa.org/parsers/94).

The only problem is that the old parser is still active and the canteens are now listed twice.
Example:
Old https://openmensa.org/c/122 and new https://openmensa.org/c/1747

I was wondering if it is possible to either disable the old hamburg parser or get access to it on openmensa to change the feed urls?

If that is possible, I'd consider fixing some more of the broken parsers from mswart/openmensa-parsers

Complete the Documentation for "limit" and "page" parameters

Hi,
i want to use these parameters. But i don't know how. The Documentation (https://doc.openmensa.org/api/v2/) is sadly bad.
I want to use it with the "Thüringen" parser.

Änderungsvorschläge in status table

In my parsers there are some canteens that have 1's under "Änderungsvorschläge" in the status table:

I am not sure what that means? If I click on the number, I get to a page that says

Mannheim, Mensa am Schloss
Änderungsvorschläge
15. Mai, 23:24 Uhr

Canteen suggestion page is not moderated

The page on https://openmensa.org/c/new is not moderated. This allows users to post arbitrary content on the page. It seems that this is happening right now (there are some suspicious entries, might be that someone uses that page as a dead drop).

I suggest adding a moderation feature for that page.

Certificate for openmensa.org expired

The SSL certificate for openmensa.org expired today.

Price roles required in XML schema, but documentation says otherwise

The price's role attribute is required in the XML schema. However, the documentation suggests that the roles are optional. Optional prices make sense e. g. for the Aachener Academica, where some meals are subsidized, but others are the same price for everyone.

It is a minimal change that is backwards compatible.

Connection to doc.openmensa.org not possible due to invalid certificate

The domain doc.openmensa.org is not reachable, because the current certificate is only valid for htz22.openmensa.org and openmensa.org.

Support meal pictures

Some canteens provide pictures for meals. It would be nice if the api and feed supported this.

As a starting proposal, I suggest a simple "pictures" additional attribute for meals which contains a list of links to pictures. This list can be empty if there is no picture.

Allow different currencies for the price

not only €.. CHF / SFr would be nice as well, for example for Swiss universities..

Store/handle opening times for canteens

The feed already supports opening times, but at the moment not the application itself.

This feature is extract from next branch as it is not so important but requires a bunch of changes/challenges.

References #4

Complete next branch

As stated in #4

Detect and inform about canteens that have not meals over a longer period

A common but silence error are parsers that did not fail but return a empty list of meals.

The update routine should watch canteens for parsers that "fail" this way.

OpenMensa (prod) stopped updating feeds

Many parsers weren't fetched fetched today, and it looks like some haven't been fetched for a while.

@mswart Could you take a look at the openmensa cron?

support multiple languages

Some canteens must already provide information in multiple languages. With increasing number of people moving around the globe more freely, supporting multiple languages sounds like a natural evolution.

Interesting tool used by frontend web apps, which uses Wikidata as source for food names
http://googleknowledge.github.io/qlabel/demo/menu/

Since I work with linked data, I find it offering some helpful ways to manage multilingual content. From API perspective and recognizing JSON becoming most popular serialization in world of web APIs, this feature of JSON-LD looks very helpful - http://www.w3.org/TR/json-ld/#string-internationalization

iOS app missing in appstore

It seems that the iOS app was removed from the appstore.

Is this expected?

API does not deliver data for canteens of Studentenwerk Dresden

API Endpoint for meals of canteens in Dresden, Zittau, Görlitz and Tharandt returns 404 error
for instance: https://openmensa.org/api/v2/canteens/80/days/2024-01-08/meals

Website down? Project dead?

Parser for mensen at Dresden seems broken

checking for meals returns no offers. (e.g.: https://openmensa.org/c/79)

Can't place canteen on map if address was not found

I created a canteen and entered an address like I did a few times, but with one particular address I received a fully grey map, I was not able to place a marker. There were no map tiles and no marker to move around, I was not able to zoom or pan the map.

The address in question belongs to "Bistro Frieden" :
Scharnhorststraße 100, 48151 Münster, Germany

I suspect this is because the geocoder can not find the address, OSM's nominatim does not find it either.

I managed to find a workaround by filling the coordinate fields with the Firefox devtools (fields are readonly)

Mensa Gebäude X Universität Bielefeld is not working anymore

The Website of Studierendenwerk Bielefeld has changed, so openmensa isn't working anymore and just displays anything as empty: http://www.studierendenwerk-bielefeld.de

Server currently under maintainance (until later this day)

Canteen with null coordinates

http://openmensa.org/api/v2/canteens?limit=50&page=4 currently returns

{
  id: 192,
  name: "Gebze Yüksek Teknoloji Enstitüsü",
  city: "Gebze/Kocaeli",
  address: "Gebze Yüksek Teknoloji Enstitüsü Rektörlüğü P.K141 41400 Gebze/KOCAELİ",
  coordinates: [
    null,
    null
  ]
},

This crashes clients. See domoritz/open-mensa-android#25

Aasee Münster parser stopped working

Hey everyone,

I recently realized the parser for the Aasee canteen in Münster stopped working.

I got in touch with the canteen and they said, they indeed stopped to provide the XML. But they provide an HTML you could use to parse the meals. They send me this link: https://muenster.my-mensa.de/essen.php?v=5326049&hyp=1&lang=de&mensa=aasee#aasee_tag_2020231

So far I didn't implement a parser for openmensa, but if none of you is working on it, I would give it a try.

Cheers.

iCalendar stream for user/canteen

Hi there, I already spoke to Malte about my idea to implement a calendar API for users. I thought about the following scenarios:

There is a public stream for each canteen.
The user can generate a link to a stream based on his canteen favorites. (auth via token)

The url should handle some parameters like "show event for all day" or "event's time based on the canteen's opening hours". A response then contains events with the parsed information for each day. I would also build a small url generator for users based on your decisions.

For the implementation I found ri_cal and/or icalendar.

Please provide me some feedback on what you want me to implement. Thanks :)

Canteens not updated anymore

Some canteens appear to not be updated anymore, even though their parsers appear to work fine.

See the issue on OpenMensa Parsers.

Observations

The "main" canteen for Aachen, the Academica, is normally displayed. However, secondary canteens, which use the same parser, e. g. Ahorn, have not received any updates since a while.

I do not know what differences OpenMensa sees between these parser.

Updated Parsers for Studentenwerk Thüringen

Hi there!

During the last days a pull request at https://github.com/mswart/openmensa-parsers got merged, which added parsers for almost every canteen from Studentenwerk Thüringen.
I will try to document for which canteens a parser already exists but isn't working, and which parsers are completely new.

Canteen Name	City	current status(old parser)	new parser-link
Mensa am Wartenberg	Eisenach	-	http://omfeeds.devtation.de/thueringen/ei-wartenberg/full.xml
Mensa Nordhäuser str.	Erfurt	not working	http://omfeeds.devtation.de/thueringen/ef-nordhaeuser/full.xml
Mensa Altonaer str.	Erfurt	not-working	http://omfeeds.devtation.de/thueringen/ef-altonaer/full.xml
Cafeteria Schlüterstr.	Erfurt	-	http://omfeeds.devtation.de/thueringen/ef-schlueterstr/full.xml
Cafeteria Leipzigers.	Erfurt	-	http://omfeeds.devtation.de/thueringen/ef-leipzigerstr/full.xml
Mensa Weg der Freundschaft	Gera	-	http://omfeeds.devtation.de/thueringen/ge-freundschaft/full.xml
Mensa Ehrenberg	Ilmenau	not working	http://omfeeds.devtation.de/thueringen/il-ehrenberg/full.xml
Cafeteria Ehrenberg	Ilmenau	not-working	http://omfeeds.devtation.de/thueringen/il-cafeteria/full.xml
Nanoteria	Ilmenau	not-working	http://omfeeds.devtation.de/thueringen/il-nanoteria/full.xml
Roentgen Mensa	Ilmenau	-	http://omfeeds.devtation.de/thueringen/il-roentgen/full.xml
Mensa Carl-Zeiss Promenade	Jena	not working	http://omfeeds.devtation.de/thueringen/je-zeiss/full.xml
Cafeteria EAH	Jena	-	http://omfeeds.devtation.de/thueringen/je-eah/full.xml
Mensa Ernst Abbe Platz	Jena	not working	http://omfeeds.devtation.de/thueringen/je-ernstabbe/full.xml
vegeTable	Jena	-	http://omfeeds.devtation.de/thueringen/je-vegeTable/full.xml
Cafeteria zur Rosen	Jena	-	http://omfeeds.devtation.de/thueringen/je-rosen/full.xml
Mensa Philosophenweg	Jena	not working	http://omfeeds.devtation.de/thueringen/je-philosophen/full.xml
Cafeteria Uni Hauptgelände	Jena	-	http://omfeeds.devtation.de/thueringen/je-haupt/full.xml
Cafeteria Bibliothek	Jena	-	http://omfeeds.devtation.de/thueringen/je-bib/full.xml
Mensa Weinberghof	Nordhausen	-	http://omfeeds.devtation.de/thueringen/nh-mensa/full.xml
Mensa Blechhammer	Schmalkalden	-	http://omfeeds.devtation.de/thueringen/sk-mensa/full.xml
Cafeteria am Horn	Weimar	-	http://omfeeds.devtation.de/thueringen/we-horn/full.xml
Mensa am Park	Weimar	not working	http://omfeeds.devtation.de/thueringen/we-park/full.xml
Cafeteria Anna Amalia Bibliothek	Weimar	-	http://omfeeds.devtation.de/thueringen/we-anna/full.xml
Cafeteria Coudraystr.	Weimar	-	http://omfeeds.devtation.de/thueringen/we-coudray/full.xml

It would be great if the new canteens could be added to openmensa and the ones that aren't working at the moment could be changed to use the new parsers :)

Cheers

Allow for dual opening hours and two separate meals per day

some of our mensas have a lunch (mittagessen) and dinner (abendessen), and thus two opening hours. how should this be entered?

<times type="opening">
  <monday open="11:00-14:00; 17:00-20:00" />

and the meals with a category?

<canteen>
<day date="2012-05-29">
  <category name="Mittag - Hauptgericht">
    <meal>
      <name>Rührei mit Rahmspinat und Salzkartoffeln</name>
      <note>ovo-lacto-vegetabil</note>
      <price role="student">1.20</price>
      <price role="employee">2.60</price>
      <price role="other">3.00</price>
    </meal>
    <meal>
      <name>Hähnchengeschnetzeltes mit exotischen Früchten, dazu Bio-Reis und Mischsalat</name>
      <note>mit Geflügelfleisch</note>
      <price role="student">2.00</price>
      <price role="employee">3.35</price>
      <price role="other">4.00</price>
    </meal>
  </category>
  <category name="Mittag - Sonstiges">
    <meal>
      <name>Spargelcremsuppe</name>
      <price role="other">2.00</price>
    </meal>
  </category>
  <category name="Abend - Hauptgericht">
    <meal>
      <name>Spaghetti</name>
      <price role="other">2.00</price>
    </meal>
  </category>
</day>

<day date="2012-05-28">
  <closed/>
</day>
</canteen>

fetching HTTPS feeds with CAcert certificate fail

Hi guys,

since the last update, my feeds do not get fetched anymore, since they fail with a "certificate verify failed". It seems that the updates either induced a new certificate check, or CAcert is no longer listed as a trusted CA.

Best regards,
Kai

Dependabot can't resolve your Ruby dependency files

Dependabot can't resolve your Ruby dependency files.

As a result, Dependabot couldn't update your dependencies.

The error Dependabot encountered was:

Bundler::GemNotFound with message: Could not find rack-cors-1.0.4 in any of the sources

If you think the above is an error on Dependabot's side please don't hesitate to get in touch - we'll do whatever we can to fix it.

New Parser for Würzburg

The Paser for canteen in Würzburg semes to be broken.

Responding to feedback

Currently there seems to be no way to respond to user feedback (or alternatively mark as "resolved")

Timeout when opening parser with many feeds

Currently, I cannot open some parsers that have many feeds, like Zürich: https://openmensa.org/parsers/52 I just get a timeout after 60 s.

My guess after briefly looking at the code (still without any Rails knowledge) is that it just naively loads every message for every feed_fetch for every feed for every canteen (at least I couldn't find any clever DB query) and this just kills performance when you have many feeds with many fetches each by generating thousands of DB queries.

Is the canteen publicly accessible? Company canteens usually aren't, so I could give a hint about that.
Parser-related info/metadata (this is more technical and might or might not be shown to the actual end-user)
- Source URL: As a parser developer, I could give a hint about where I got my information from.
- Parser version
- Developer info (Name, email address, and/or URL) - or, maybe even better, a URL to a website with more information about the parser or developer (this could be a link to Github). It should give enough information to contact the developer in case something is wrong with the parser. So far it is not possible to get this information via the API.

	td rowspan=fetch.messages.size + 1
	i class=(reason_map[fetch.reason]) title=t(:feed_fetch, :reasons, fetch.reason)