openmobilityfoundation/mds-core

An implementation of an MDS Agency Server written in Typescript

mds-core's Issues

Code hygiene per Security Audit v2

PM for security audit pdf.

Implement cursor based pagination for mds-native

[mds-compliance] Rework compliance to support cascading overflows.

Example of what we wish to support: You have a geography A which is a complete subset of geography B (i.e. A is encompassed by B). Geography B has a permitted maximum count of 4000 vehicles for provider x however, provider x also wishes to purchase an additional 3000 spots within geography A. This means, total, provider x can have 7000 vehicles deployed across those two geographies. By ordering the rules such that the rule for geography A is before the rule for geography B, we wish all vehicles which 'match' with the first rule's constraints that cannot fit within the 3000 vehicle bucket will overflow into consideration for bucket for rule B. If there's not room in bucket B (it fills up during evaluation entirely), all overflowed vehicles will be considered violations.

PROPOSAL: mds-core transition to OMF City Services Working group

To date, mds-core has been developed primarily by LADOT and their contractor Ellis and Associations. As part of the code contribution from LADOT to OMF, it is intend that mds-core be transitioned to management by the OMF City Services Working Group. It is our hope that a community of developers and interested stakeholders can be built around mds-core, similar to the community that exists for the Mobility Data Specification itself. That community will drive future development of mds-core with continued contribution from LADOT and their contractors.

Here you will find a proposal to the community for how to accomplish this transition:

https://docs.google.com/presentation/d/1y8WzdK4o2iA_v57zoEMgIuyBWqhyp4VufENAUwFlK1s/edit#slide=id.g643cf86fc3_0_0

We are soliciting feedback on this proposal. It will be presented to the City Services Working Group on an upcoming call as well. Please leave questions, comments, and reactions in this issue, or feel free to email [email protected] directly.

agency relations/tables are not created until first write

When running a clean install i noticed that agency relations/tables are not created until first write.

1. i try to get the existing vehicles (should return an empty list)
   [me@devbox mds-core]$ curl 127.0.0.1:8099/agency/vehicles -H "Content-Type: application/json" -H 'Authorization: Bearer eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJwcm92aWRlcl9pZCI6IjI0MTFkMzk1LTA0ZjItNDdjOS1hYjY2LWQwOWU5ZTNjMzI1MSIsImV4cCI6MjUyNDYwODAwMH0.XUl4kS-xJuXHRlwNA_--9CeM2TlTyepVgVU3ndKCvJo' {"error":"server_error","error_description":"Unknown server error"}
   Logs from agency component:
   "getVehicles fail" "error: relation \"devices\" does not exist"

2. i do a write(no error):
   [me@devbox mds-core]$ curl -d @test_p2_add_vehicle.json -X POST 127.0.0.1:8099/agency/vehicles -H "Content-Type: application/json" -H 'Authorization: Bearer eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJwcm92aWRlcl9pZCI6IjI0MTFkMzk1LTA0ZjItNDdjOS1hYjY2LWQwOWU5ZTNjMzI1MSIsImV4cCI6MjUyNDYwODAwMH0.XUl4kS-xJuXHRlwNA_--9CeM2TlTyepVgVU3ndKCvJo' {}

3. i try to get the existing vehicles (and works!):
   [me@devbox mds-core]$ curl 127.0.0.1:8099/agency/vehicles -H "Content-Type: application/json" -H 'Authorization: Bearer eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJwcm92aWRlcl9pZCI6IjI0MTFkMzk1LTA0ZjItNDdjOS1hYjY2LWQwOWU5ZTNjMzI1MSIsImV4cCI6MjUyNDYwODAwMH0.XUl4kS-xJuXHRlwNA_--9CeM2TlTyepVgVU3ndKCvJo' {"total":1,"links":{"first":"http://agency:4000/agency/vehicles?skip=0&take=1000","last...}

Not sure if this is a bug or a feature.

[mds-compliance] Re-implement Count Minimums

Extension of #97 which only focused on count maximums. After evaluating each Count rule, add a post-processing step which looks to see if there is a minimum for each rule. If there's a minimum, and the corresponding "bucket" for that rule isn't filled enough, then mark the violation as the difference between the two. E.g. if a rule has a min of 10, and there are only 7 vehicles in its bucket, then there's a violation of 3.

Add Circ provider to mds-core

Hi,

I belong to APD, who is responsible by implement your solution on Oporto, Portugal.

We need to use Circ provider on MDS-Core.

The Circ provider is defined here:
https://github.com/openmobilityfoundation/mobility-data-specification/blob/dev/providers.csv

But we found that is not in the code, for example, here:
https://github.com/openmobilityfoundation/mds-core/blob/dev/packages/mds-providers/index.ts

Can you please add this provider?

Thank you!

Docs for Authentication Configuration

Hey,
Im trying to set up a mds-core instance (mds-agency, for now), but i couldn't find documentation on how to configure secrets or public/private keys for jwt token validation, which claims should be set for authentication, ...
The same goes for authorization.

Are there any examples available? Thanks.

Address potential security issues in dependencies

GitHub has identified several mds-core dependencies (handlebars and serialize-javascript) with possible security vulnerabilities. Need to review and address if necessary.

https://github.com/openmobilityfoundation/mds-core/network/alerts

References to service areas

I found references to service areas in https://github.com/openmobilityfoundation/mds-core/blob/develop/packages/mds-agency/api.ts through cleaning up syntax left over from the OMF repository move.

This appears to be a bug resulting from PR #203.

I don't know enough about the code to make serious recommendations. But I do know that the https://github.com/CityOfLosAngeles/mobility-data-specification/tree/dev/agency#service_areas AND the corrected
https://github.com/openmobilityfoundation/mobility-data-specification/tree/dev/agency#service_areas URLs are incorrect.

[INFO] Status of mds-core

Dear OMF runtime producers,

we're currently looking into mds-core and evaluate whether to use it as basis for our implementation.
Unfortunately the repository seems to be a bit deserted, the specification is developing much faster than its runtime.
I would therefore appreciate a maintainer (@schnuerle ?) commenting on what the OMF is up to with this implementation.

At this point in time, we've got the options to

• develop and contribute to mds-core (this would of course be some overhead on our end, but if it helps for the greater good, we'd see what we can do ;)
• just fork it without contributing (we'd go this route if you, the OMF is not aiming at providing a reference implementation on this basis)
• develop something completely new (in Java Spring Boot), with both the options to opensource it or not

What are your thoughts about it, given that you know best about the strategic goals, current and future challenges of OMF and MDS?

Cheers,
Oliver