openmoh/openmohaa

Open re-implementation of Medal of Honor: Allied Assault

openmohaa's Issues

(Basic training) The incorrect location of the truck in the garage

Hi

I notice that the truck in the garage is now visible, which is awesome!
However, the location of this truck is incorrect.
The hood of this truck shouldn't be turned toward the left side of the wall in the garage. I attached the screenshot from the Linux version of Mohaa from icculus.org.

Can you fix it?

Credits in Mohaa, Spearhead and Breakthrough - unnecessary elements

Hi

The credits work now in all three games.

I noticed it displays many unnecessary elements from the game: the compass, the health meter, and the inventory.

Can you fix it?

(Basic training) the invisible truck in the garage

Hi

I noticed that the truck in the garage on the right side is not visible.
The game detects it because I can't move in this area where the truck should be located. In this case, the truck isn't correctly displayed.

(Basic training) I can't pick up the explosives

Hi

I can't pick up the explosives from the crate by using the key e.
Nothing happens when I press this key on my keyboard.

(Basic training) All tents are invisible

Hi

I noticed that in the most recent version all tents are invisible. There are more similar issues on invisible objects in the basic training.

Do you want me to add a list of all of them here?

or

Do you want me to report one by one in the separated issues?

Screenshots?

I think people will be more interested in testing this neat re-implementation and maybe collaborate with some code if you show the current state of this port in the README. Even early screenshots are fine!

(Credits: Mohaa, Spearhead, Breakthrough) Music keeps playing after pressing the ESC key

Hi

I noticed this bug in all three games in Opemohaa.

I start Credits, and then I press the ESC key to go back to the Main menu. In this case, music should stop playing after pressing the ESC key and continue playing when I press this key again or the button Back to Game.

Can you fix it?

(Basic training) double free or corruption (fasttop) DOUBLE SIGNAL FAULT: Received signal 6, exiting...

Hi

I checked the most recent version of Openmohaa, and it freezes at the end of the basic training. It's happening when I open the last door to enter the corridor. In this case, the game freezes, instead bring me back to the map with missions. I had to use the kill command to quit Openmohaa.

https://gist.github.com/gbudny/1bd03acfa036e682a03459dcc03071b1

Can you fix it?

(Basic training) The tank disappears after the explosion.

Hi

In the most recent version of Openmohaa, the tank disappears after the explosion.

Can you fix it?

Door bug

When opening a door, it may get stuck opening 360 degrees, indefinitely

tiki_shared.h: boneType

field ‘boneType’ has incomplete type 'enum boneType_e enum boneType_e boneType'
tiki_shared.h:255:18 (enum boneType_e boneType) no defines, are specified. Please fix.

(Rangers Lead the Way) I can't get out of the truck

Hi

I checked the most recent version of Openmoha. I noticed this mission works again, which is impressive!

However, I can't get out of the truck to walk around on this map.

Can you fix it?

(Credits) munmap_chunk(): invalid pointer DOUBLE SIGNAL FAULT: Received signal 6, exiting...

Hi

I checked the most recent version of Openmohaa. I noticed it always freezes the game when I press the left mouse button to skip credits.

openmohaax86_64-dbg

https://gist.github.com/gbudny/e9c1cedcff3ca543934983477a4c061f

I know that Openmohaa became more unstable and crashed in different places more frequently 2 or 3 days before you released version 0.5.80.

Demo writing: nullstate not properly initialized?

In CL_Record_f, when writing the baselines, they are delta'd against a nullstate which is initialized as

Com_Memset (&nullstate, 0, sizeof(nullstate));

But it should probably be

MSG_GetNullEntityState( &nullstate );

instead, same as in SV_SendClientGameState.

TODO: Finish renderer implementation

Renderer is in an unfinished state

TODO:

• Dynamic lights
• LOD Terrain
• Decals

Non-exhaustive list

(Basic training) tank floats in the air

Hi

I noticed that the tank in the basic training floats in the air.

Can you fix it?

(Breakthrough) Game frequently crashes when I don't use GDB

Hi

I have this weird issue with Openmohaa. I have random crashes, when I load the Basic training or Rangers Lead the Way. It frequently crashes when I try load a movie from Breakthrough, and I think it's the same bug.

I tried to catch this bug many times, and it always works fine when I use GDB, which is weird.

https://gist.github.com/gbudny/8c7203fd31de2e2d4baf35ab9b1e32f3

Can you help me?

HOw i can compile under Slackware(64) 14.2?

HI there i try to compile, but don't work, i do the follow :

cd /tmp
git clone https://github.com/openmoh/openmohaa
cd openmohaa
make

Output :

make[1]: se entra en el directorio '/tmp/openmohaa'

Building openmohaa in build/release-linux-x86_64:
  PLATFORM: linux
  ARCH: x86_64
  COMPILE_PLATFORM: linux
  COMPILE_ARCH: x86_64
  CC: cc

  CFLAGS:
    -MMD
    -Wall
    -fno-strict-aliasing
    -Wimplicit
    -Wstrict-prototypes
    -pipe
    -DUSE_ICON
    -I/usr/include/SDL
    -D_GNU_SOURCE=1
    -D_REENTRANT
    -DUSE_OPENAL
    -DUSE_CURL
    -DUSE_CURL_DLOPEN
    -DUSE_LOCAL_HEADERS
    -DNDEBUG
    -O3
    -fomit-frame-pointer
    -ffast-math
    -funroll-loops
    -falign-loops=2
    -falign-jumps=2
    -falign-functions=2
    -fstrength-reduce

  LDFLAGS:
    -ldl
    -lm

  Output:
    build/release-linux-x86_64/omohaaded.x86_64
    build/release-linux-x86_64/openmohaa.x86_64
    build/release-linux-x86_64/main/cgamex86_64opm.so
    build/release-linux-x86_64/main/gamex86_64opm.so
    build/release-linux-x86_64/main/uix86_64opm.so

make[2]: se entra en el directorio '/tmp/openmohaa'
DED_CC code/server/sv_bot.c
In file included from code/server/server.h:27:0,
                 from code/server/sv_bot.c:24:
code/server/../qcommon/q_shared.h:177:0: aviso: se redefinió "PAD"
 #define PAD(base, alignment) (((base)+(alignment)-1) & ~((alignment)-1))
 ^
code/server/../qcommon/q_shared.h:169:0: nota: esta es la ubicación de la definición previa
 #define PAD(x,y) (((x)+(y)-1) & ~((y)-1))
 ^
In file included from code/server/../qcommon/tiki.h:29:0,
                 from code/server/../qcommon/qcommon.h:27,
                 from code/server/server.h:28,
                 from code/server/sv_bot.c:24:
code/server/../qcommon/../tiki/tiki_shared.h:255:18: error: el campo ‘boneType’ tiene tipo de dato incompleto
  enum boneType_e boneType;
                  ^
In file included from code/server/../qcommon/qcommon.h:27:0,
                 from code/server/server.h:28,
                 from code/server/sv_bot.c:24:
code/server/../qcommon/tiki.h:117:25: error fatal: tiki_script.h: No existe el fichero o el directorio
compilación terminada.
Makefile:1683: fallo en las instrucciones para el objetivo 'build/release-linux-x86_64/ded/sv_bot.o'
make[2]: *** [build/release-linux-x86_64/ded/sv_bot.o] Error 1
make[2]: se sale del directorio '/tmp/openmohaa'
Makefile:847: fallo en las instrucciones para el objetivo 'targets'
make[1]: *** [targets] Error 2
make[1]: se sale del directorio '/tmp/openmohaa'
Makefile:841: fallo en las instrucciones para el objetivo 'release'
make: *** [release] Error 2

/qcommon/str.h:592: void str::tolower(): Assertion `m_data' failed.

Hi

I wanted to check many interesting changes in the most recent version of Openmohaa. Unfortunately, I noticed the same bug that exists when I try to load Basic training, Credits, and maps in the multiplayer mode (Mohaa, Spearhead, Breakthrough).

Ubuntu 22.04

https://gist.github.com/gbudny/2d24e766fd1e13e19392e045093c755e

idtech 3 game engine experts - suggestion

Hello Guys!
It is not issue, but a help. There is a good guys who develop OpenJA - the open source Jedi Academy. They have huge knowledge in developing idtech 3 engine. Ask them maybe on GitHub: ensiform, xycaleth, eezstreet, Razish

TODO: UI implementation

Finish UI implementation by implementing the actual functions body, whatever the method.

Path: /code/uilib

(Basic training) Doors on left side of the building can be opened

Hi

I want to inform you isn't possible to open the door on the left side of the building in the original game.

Can you fix it?

TODO: Finish fgame implementation

A lot of things were done for the game portion and not much is remaining:

• Make Actor class working (credit to Ryback who did an huge part of it)
• Finish Vehicle

Non-exhaustive list

Slight spelling mistake in death messages?

I noticed some slight differences to the base game in the death messages:

openmohaa/code/fgame/player.cpp

Lines 2735 to 2742 in 25c4171

	case MOD_GRENADE:
	if (G_Random() >= 0.5f) {
	s1 = "tripped on";
	s2 = "'s' grenade";
	} else {
	s1 = "is picking";
	s2 = "'s' shrapnel out of his teeth";
	}

openmohaa/code/fgame/player.cpp

Line 2770 in 25c4171

s2 = "'s' SMG";

e.g.
"'s' shrapnel out of his teeth"

instead of

"'s shrapnel out of his teeth"

(extra single quote)

Or is this something that later versions of the game/extensions changed?

Grenade sound

Grenade doesn't emit any sound when bouncing off the ground

The missing intro in Mohaa

Hi

I want to inform you that the intro is missing in Mohaa.

I'm happy that you are working on it because I still keep the old computer with Linux 2.4 to play Mohaa.

[GAMEX]Actor not working properly

So, after reversing 99% of actor funcs. Actor behavior is messed up.
How to test/replicate:
-Place actortest.pk3 from actortest.zip inside main folder.
-open up mohaa with original gamex86.dll
-type in console: "map actortest"
-player gets spawned behind actor.
-try to move, shoot, or make noise.
-actor will look at you and do proper animations [partially broken because no scripts are loaded]
-try same stuff with opm gamex86.dll
-actor looks at you but animations are broken (most noticeable is face animation)

What version of Medal of Honor: Allied Assault War Chest do you use?

Hi

I have a question for people that develop this project.

What version of Medal of Honor: Allied Assault War Chest do you use?

I have crashes during loading maps in the multiplayer mode with Breakthrough that I don't have with the base game and Spearhead. Maybe there are some differences in the GOG version.

Improvement idea: Interpolate fLeanAngle for demo playback

So, when playing back demos at fps that are higher than the sv_fps of the server it was recorded on (or with lower timescale), any leaning is kinda stuttery. It's not in normal gameplay (probably because of clientside prediction code that doesn't run for demo playback) but it is when playing back demos. I think this can be solved by interpolating fLeanAngle the same way that origin, viewangles and origin is interpolated for the playerstate, when playing back demos (or possibly if first person spectating but not sure).

Just a tiny possible improvement over the normal game which has the same "problem".

(Basic training) The tank isn't correctly displayed before and after the explosion

Hi

The tank isn't correctly displayed in the most recent version of Openmohaa,
The main gun and the turret aren't displayed. Additionally, the tank looks as if it was after the explosion.

I checked the version from August 19th, and it doesn't display the missing elements of the tank. However, it looks better before the explosion:

9b15b27

The missing elements of the tank are displayed after the explosion in the version from August 19th:

Can you fix it?

OpenMoHAA FOR ANDROID

Will this program be on android? will we be able to play this classic on a mobile phone?

(Basic training) :329: void Com_Error(int, const char*, ...): Assertion `code != ERR_FATAL' failed.

Hi

I checked the most recent version of Openmohaa.
I noticed that this game in the basic training always crashes when I try to approach the crate with explosives..

DBG:

https://gist.github.com/gbudny/d6d169caeeafece6187c5114103d725f

Can you fix?

Build Error: Hunk_Alloc

sv_bot.c: In function ‘BotImport_HunkAlloc’:
sv_bot.c:309:27: error: ‘h_high’ undeclared (first use in this function)
sv_bot.c:309:27: note: each undeclared identifier is reported only once for each function it appears in
sv_bot.c:309:9: error: too many arguments to function ‘Hunk_Alloc’

Please advise.

TODO: Implement client game module

Start by using cgame from fakk.

Then complete it by implementing features from mohaa, which means:

• A few more FX-related features
• CGame messages
• Nature-related components
• Scoreboard
• Weapon command
• Vehicle
• View model
• Volumetric smoke

(Spearhead) Game crashes after Jack Barnes dies.

Hi

I can load the first map of the single-player mode in Spearhead. The image in the game is blurry for a few seconds, and then I see some objects. In this moment, Jack Barnes dies after landing with the parachute, which doesn't happen in the original game.

https://gist.github.com/gbudny/6c8a79866dca71414c4301e962d78967

However, the most important issue is that the game crashes when he dies:

I uploaded the file core.dmp:

https://we.tl/t-OCESBixgdT

Can you fix it?

Web3 OpenMohaa

Many games are migrating to Web3, in fact, one example is the work done by Lattice (https://twitter.com/latticexyz?lang=es), creating OpCraft (https://github.com/tenetxyz/opcraft- redstone) a Minecraft Web3 clone, I think it would be a good idea to offer you the idea of developing OpenMohaa on Web3.

tiki.h: #include <tiki_script.h>

tiki.h:117 - #include <tiki_script.h>
suggestion: #include "tiki_script.h"

Credits don't work in Mohaa

Hi

I want to inform you that credits don't work in Mohaa.

I can click continue, and then I see it tries to load a game because I see some elements like a gun on the black background.

Clientside project for cmake?

I might just be too inexperienced, but when I generate the Visual Studio projects I seem to be missing anything client game related. For example the file cl_parse.cpp appears to be missing from the entire solution, I can't find stuff that should be in it when I do a global search. To give an example, svc_snapshot is referenced only twice in the solution, once in the enum and once the serverside writing. But nowhere do I see the parsing.

The release does include the client though, so I'm not sure what I'm doing wrong. It must be possible to compile it no?

Supporting crash dumps for occasional crashes ?

https://msdn.microsoft.com/en-us/library/windows/desktop/ee416349(v=vs.85).aspx

TODO: Implement CMake support

The project currently uses Visual Studio solution files (Windows) and Eclipse project files (for Linux). Goal is to use CMake for the entire project instead, for easier contribution.

Must be able to target any platform on any architecture. C++17 standard at minimum should be used for convenience.

Possible binaries outputs:

• Server binaries: omohdedArch and gameArch
• Client binaries (of course the client can host a LAN game): openmohaa, cgameArch

Maybe an option to be able to compile statically, resulting in fgame/cgame combined into the output executable?

Update cryptographic hash primitives and libcurl library

Some security issues related to the use of md5 as a cryptographic hash function:

• collisions (multiples pre-image giving the same hash value) exists
• rainbow table attacks
• not recomanded by standards bodies anymore
• the new function should be implemented via an approved external open source provider

Libcurl library should be updated for improved security as well.

(Breakthrough) Video isn't properly displayed

Hi

I noticed that the first video can be played in the single-player mode, which is impressive. However, the one-fourth of the video is covered by a black rectangle when it is playing.

Can you fix it?

Demo support?

Hi,

I was wondering if you plan to support the demo, which could be useful for people to play some part of the game using this engine, without the need to buy the full game.

(Breakthrough) Palermo doesn't load

Hi

I noticed that the map Palermo doesn't load properly, and gets stuck in the middle of loading.
I had to force this game to quit.

https://gist.github.com/gbudny/70c65f4eeb77e8cd9e441890828de517

(Basic training) I can't move in any direction

Hi

I checked the new version of Openmohaa 0.57.0-alpha on Linux, and I noticed it still has this weird bug. I load the basic training, and frequently I can't walk in any direction. In this case, I have to quit the game and start it again.

Do you have the same issue?

Can you fix it?

That was impressive when I walked to the end of the map.

REAME Location of files in hidden folder .moh

Hi

What files should be added to the folders Main and OpenMoHAA in the hidden folder .moh?

I added cgamex86_64.so and gamex86_64.so to both folders to prevent the game from crashing when I try to load basic training or multiplayer. It doesn't help with the singleplayer campaign.

Do I need to add other files to the Main and OpenMoHAA folders?

(Basic training) The truck merges with the tank

Hi

I frequently see the truck and the tank displayed in the same place.
It looks like they were merged together.

Current state of affairs

Hi guys

What is the current state of affairs with openmohaa?

Has there been any progress on UI? What makes the current client unusable? (I was under the impression MP was fully playable?)

Compilation on VS2017+

Hi

I was wondering if anyone else had successfully compiled under Visual Studio 2017 or above?

I do not have older versions installed on my system so in an attempt to build it at 2017 level (v141) with C++ 14, I receive multiple errors in the CL_InitRef ref function with the assignment of callbacks like "ri.FS_Read = FS_Read;" due to size_t to int conversion issues. Macro redefinition errors and such.

If anyone has any forks adjusted to work with vs2017+ please let me know. I'd love to try help with the project but I am quite partial to the newer VS IDEs.